Bug 1457440 - Stop translating margin, padding, border in the box-model diagram. r=bgrins
authorGabriel Luong <gabriel.luong@gmail.com>
Fri, 27 Apr 2018 15:52:34 -0400
changeset 416141 e5425430461fca727ca0bfab0261248a15f6fd44
parent 416140 653f16ce003a533e822053a042e41c1adcc55763
child 416142 ba50d50797ede3964b69eb1f52d48937b7ea92a8
push id33917
push userapavel@mozilla.com
push dateSat, 28 Apr 2018 17:30:55 +0000
treeherdermozilla-central@08f68e2c892c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1457440
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457440 - Stop translating margin, padding, border in the box-model diagram. r=bgrins
devtools/client/inspector/boxmodel/components/BoxModelMain.js
devtools/client/locales/en-US/boxmodel.properties
--- a/devtools/client/inspector/boxmodel/components/BoxModelMain.js
+++ b/devtools/client/inspector/boxmodel/components/BoxModelMain.js
@@ -484,59 +484,59 @@ class BoxModelMain extends PureComponent
       dom.div(
         {
           className: "boxmodel-box"
         },
         dom.span(
           {
             className: "boxmodel-legend",
             "data-box": "margin",
-            title: BOXMODEL_L10N.getStr("boxmodel.margin"),
+            title: "margin",
           },
-          BOXMODEL_L10N.getStr("boxmodel.margin")
+          "margin"
         ),
         dom.div(
           {
             className: "boxmodel-margins",
             "data-box": "margin",
-            title: BOXMODEL_L10N.getStr("boxmodel.margin"),
+            title: "margin",
             ref: div => {
               this.marginLayout = div;
             },
           },
           dom.span(
             {
               className: "boxmodel-legend",
               "data-box": "border",
-              title: BOXMODEL_L10N.getStr("boxmodel.border"),
+              title: "border",
             },
-            BOXMODEL_L10N.getStr("boxmodel.border")
+            "border"
           ),
           dom.div(
             {
               className: "boxmodel-borders",
               "data-box": "border",
-              title: BOXMODEL_L10N.getStr("boxmodel.border"),
+              title: "border",
               ref: div => {
                 this.borderLayout = div;
               },
             },
             dom.span(
               {
                 className: "boxmodel-legend",
                 "data-box": "padding",
-                title: BOXMODEL_L10N.getStr("boxmodel.padding"),
+                title: "padding",
               },
-              BOXMODEL_L10N.getStr("boxmodel.padding")
+              "padding"
             ),
             dom.div(
               {
                 className: "boxmodel-paddings",
                 "data-box": "padding",
-                title: BOXMODEL_L10N.getStr("boxmodel.padding"),
+                title: "padding",
                 ref: div => {
                   this.paddingLayout = div;
                 },
               },
               dom.div({
                 className: "boxmodel-contents",
                 "data-box": "content",
                 title: BOXMODEL_L10N.getStr("boxmodel.content"),
--- a/devtools/client/locales/en-US/boxmodel.properties
+++ b/devtools/client/locales/en-US/boxmodel.properties
@@ -14,28 +14,16 @@
 # LOCALIZATION NOTE (boxmodel.title) This is the title of the box model panel and is
 # displayed as a label.
 boxmodel.title=Box Model
 
 # LOCALIZATION NOTE (boxmodel.position) This refers to the position in the box model and
 # might be displayed as a label or as a tooltip.
 boxmodel.position=position
 
-# LOCALIZATION NOTE (boxmodel.margin) This refers to the margin in the box model and
-# might be displayed as a label or as a tooltip.
-boxmodel.margin=margin
-
-# LOCALIZATION NOTE (boxmodel.border) This refers to the border in the box model and
-# might be displayed as a label or as a tooltip.
-boxmodel.border=border
-
-# LOCALIZATION NOTE (boxmodel.padding) This refers to the padding in the box model and
-# might be displayed as a label or as a tooltip.
-boxmodel.padding=padding
-
 # LOCALIZATION NOTE (boxmodel.content) This refers to the content in the box model and
 # might be displayed as a label or as a tooltip.
 boxmodel.content=content
 
 # LOCALIZATION NOTE: (boxmodel.geometryButton.tooltip) This label is displayed as a
 # tooltip that appears when hovering over the button that allows users to edit the
 # position of an element in the page.
 boxmodel.geometryButton.tooltip=Edit position