Bug 1414838 - Show stop button again as soon as page loading starts. r=nechen
authorJan Henning <jh+bugzilla@buttercookie.de>
Mon, 06 Nov 2017 20:20:57 +0100
changeset 390417 e46ec8edd9bae2509c417040453dcb695efba328
parent 390416 c5417e806ad5241774950a58f320fa9451105b2b
child 390418 f0fbcf42783fb2b9fd4fb1148f6a124d3091bfad
push id32829
push userapavel@mozilla.com
push dateTue, 07 Nov 2017 10:28:12 +0000
treeherdermozilla-central@597025d8888f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnechen
bugs1414838, 1366672
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1414838 - Show stop button again as soon as page loading starts. r=nechen As of bug 1366672, case START no longer falls through in order to allow for a different behaviour of the progress indicator, however we still need to add UpdateFlags.PROGRESS, so that the stop button shows up as soon as a page starts loading. MozReview-Commit-ID: 3P33JEsS5ic
mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
--- a/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
+++ b/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
@@ -459,16 +459,17 @@ public abstract class BrowserToolbar ext
         }
 
         if (tabs.isSelectedTab(tab)) {
             final EnumSet<UpdateFlags> flags = EnumSet.noneOf(UpdateFlags.class);
 
             // Progress-related handling
             switch (msg) {
                 case START:
+                    flags.add(UpdateFlags.PROGRESS);
                     updateProgressVisibility(tab, Tab.LOAD_PROGRESS_INIT);
                     break;
                 case ADDED:
                 case LOCATION_CHANGE:
                 case LOAD_ERROR:
                 case LOADED:
                 case STOP:
                     flags.add(UpdateFlags.PROGRESS);