Bug 649849 - part 1b, Remove the default -moz-appearance:none for <select> in Fennec theme. r=wjohnston@mozilla.com
authorMats Palmgren <mats@mozilla.com>
Thu, 02 Oct 2014 13:05:16 +0000
changeset 208388 e2d1b98b34e6
parent 208387 161e4dbfff7d
child 208389 f1fd436a75a1
push id27582
push userryanvm@gmail.com
push date2014-10-02 16:20 +0000
treeherdermozilla-central@5d6ec4dddf14 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswjohnston
bugs649849
milestone35.0a1
Bug 649849 - part 1b, Remove the default -moz-appearance:none for <select> in Fennec theme. r=wjohnston@mozilla.com
layout/reftests/css-enabled/select/reftest.list
layout/reftests/native-theme/reftest.list
mobile/android/themes/core/content.css
--- a/layout/reftests/css-enabled/select/reftest.list
+++ b/layout/reftests/css-enabled/select/reftest.list
@@ -1,9 +1,9 @@
 == select-fieldset-1.html select-fieldset-ref.html
-fails-if(Android||B2G) == select-fieldset-2.html select-fieldset-ref-disabled.html
-fails-if(Android||B2G) == select-fieldset-3.html select-fieldset-ref-disabled.html
+fails-if(B2G) == select-fieldset-2.html select-fieldset-ref-disabled.html
+fails-if(B2G) == select-fieldset-3.html select-fieldset-ref-disabled.html
 == select-fieldset-4.html select-fieldset-ref.html
 == select-fieldset-legend-1.html select-fieldset-legend-ref-1.html
-fails-if(Android||B2G) == select-fieldset-legend-2.html select-fieldset-legend-ref-2.html
-fails-if(Android||B2G) == select-fieldset-legend-3.html select-fieldset-legend-ref-3.html
+fails-if(B2G) == select-fieldset-legend-2.html select-fieldset-legend-ref-2.html
+fails-if(B2G) == select-fieldset-legend-3.html select-fieldset-legend-ref-3.html
 == select-fieldset-legend-4.html select-fieldset-legend-ref-4.html
 == select-fieldset-legend-5.html select-fieldset-legend-ref-5.html
--- a/layout/reftests/native-theme/reftest.list
+++ b/layout/reftests/native-theme/reftest.list
@@ -12,17 +12,17 @@
 # The following tests will fail if the platform does not have native
 # theme support (which all platforms should have).
 fails-if(!nativeThemePref) != text-input-native.html text-input-nonnative.html
 == text-input-nonnative-when-styled.html text-input-nonnative-when-styled-ref.html
 fails-if(!nativeThemePref) != textarea-native.html textarea-nonnative.html
 == textarea-nonnative-when-styled.html textarea-nonnative-when-styled-ref.html
 fails-if(!nativeThemePref) != button-native.html button-nonnative.html
 == button-nonnative-when-styled.html button-nonnative-when-styled-ref.html
-fails-if(!nativeThemePref) != combobox-native.html combobox-nonnative.html
+fails-if(!nativeThemePref&&!Android) != combobox-native.html combobox-nonnative.html
 == combobox-nonnative-when-styled.html combobox-nonnative-when-styled-ref.html
 fails-if(!nativeThemePref) needs-focus != listbox-native.html listbox-nonnative.html
 needs-focus == listbox-nonnative-when-styled.html listbox-nonnative-when-styled-ref.html
 fails-if(!nativeThemePref) != radio-native.html radio-nonnative.html
 == radio-still-native-when-styled.html radio-still-native-when-styled-ref.html
 fails-if(!nativeThemePref) != checkbox-native.html checkbox-nonnative.html
 == checkbox-still-native-when-styled.html checkbox-still-native-when-styled-ref.html
 == native-theme-disabled-cascade-levels.html native-theme-disabled-cascade-levels-ref.html
--- a/mobile/android/themes/core/content.css
+++ b/mobile/android/themes/core/content.css
@@ -95,17 +95,16 @@ select[size="1"] > xul|scrollbar,
 select:not([size]):not([multiple]) xul|scrollbarbutton,
 select[size="1"] xul|scrollbarbutton {
   display: block;
   margin-left: 0;
   min-width: 16px;
 }
 
 /* Override inverse OS themes */
-select,
 textarea,
 button,
 xul|button,
 * > input:not([type="image"]) {
   -moz-appearance: none !important;  /* See bug 598421 for fixing the platform */
   border-radius: @form_border_radius@;
 }
 
@@ -144,16 +143,17 @@ input[type="checkbox"] {
 
 input[type="radio"] {
   background: @form_background@
 }
 
 select {
   border-width: 1px;
   padding: 1px;
+  border-radius: @form_border_radius@;
 }
 
 select:not([size]):not([multiple]),
 select[size="0"],
 select[size="1"] {
   padding: 0 1px 0 1px;
 }