Bug 1105271 - Increased size of tabs tray elements on tablet. r=mcomella
authorMichael LoPiccolo <m.lopiccolo3@gmail.com>
Fri, 26 Jun 2015 17:35:17 -0500
changeset 251872 e29408a1923da4eb0a1df236a643906414732180
parent 251871 7d880d3a62cb1d601015f162e273e642a4cca755
child 251873 f6fed0c761ab5d409b20ee0f9f8dce3a0a58e878
push id29015
push userryanvm@gmail.com
push dateWed, 08 Jul 2015 18:21:41 +0000
treeherdermozilla-central@2469f45c4770 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella
bugs1105271
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1105271 - Increased size of tabs tray elements on tablet. r=mcomella
mobile/android/base/resources/layout-large-v11/new_tablet_tabs_panel_back_button.xml
mobile/android/base/resources/layout/tabs_panel_default.xml
mobile/android/base/resources/values-large-v11/dimens.xml
mobile/android/base/resources/values-xlarge-v11/dimens.xml
mobile/android/base/resources/values/dimens.xml
--- a/mobile/android/base/resources/layout-large-v11/new_tablet_tabs_panel_back_button.xml
+++ b/mobile/android/base/resources/layout-large-v11/new_tablet_tabs_panel_back_button.xml
@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <org.mozilla.gecko.tabs.TabPanelBackButton xmlns:android="http://schemas.android.com/apk/res/android"
                                            xmlns:gecko="http://schemas.android.com/apk/res-auto"
                                            android:id="@+id/nav_back"
-                                           android:layout_width="@dimen/tabs_panel_indicator_width"
+                                           android:layout_width="@dimen/tabs_panel_button_width"
                                            android:layout_height="match_parent"
-                                           android:minWidth="@dimen/tabs_panel_indicator_width"
+                                           android:minWidth="@dimen/tabs_panel_button_width"
                                            android:src="@drawable/new_tablet_nav_back"
                                            android:contentDescription="@string/back"
                                            android:background="@drawable/action_bar_button_inverse"
                                            gecko:dividerVerticalPadding="@dimen/new_tablet_tab_panel_divider_vertical_padding"
                                            gecko:rightDivider="@drawable/tab_indicator_divider"/>
 
--- a/mobile/android/base/resources/layout/tabs_panel_default.xml
+++ b/mobile/android/base/resources/layout/tabs_panel_default.xml
@@ -32,23 +32,25 @@
                                                     android:layout="@layout/tabs_panel_indicator"/>
 
             <View android:layout_width="0dip"
                   android:layout_height="match_parent"
                   android:layout_weight="1.0"/>
 
             <ImageButton android:id="@+id/add_tab"
                          style="@style/UrlBar.ImageButton"
+                         android:layout_width="@dimen/tabs_panel_button_width"
                          android:padding="@dimen/browser_toolbar_button_padding"
                          android:src="@drawable/tab_new_level"
                          android:contentDescription="@string/new_tab"
                          android:background="@drawable/action_bar_button_inverse"/>
 
             <ImageButton android:id="@+id/menu"
                          style="@style/UrlBar.ImageButton"
+                         android:layout_width="@dimen/tabs_panel_button_width"
                          android:padding="@dimen/browser_toolbar_button_padding"
                          android:src="@drawable/menu"
                          android:contentDescription="@string/menu"
                          android:background="@drawable/action_bar_button_inverse"
                          android:visibility="gone"/>
 
         </view>
 
--- a/mobile/android/base/resources/values-large-v11/dimens.xml
+++ b/mobile/android/base/resources/values-large-v11/dimens.xml
@@ -14,16 +14,18 @@
 
     <dimen name="browser_toolbar_site_security_height">60dp</dimen>
     <dimen name="browser_toolbar_site_security_width">34dp</dimen>
     <dimen name="browser_toolbar_site_security_margin_right">1dp</dimen>
     <!-- We primarily use padding (instead of margins) to increase the hit area. -->
     <dimen name="browser_toolbar_site_security_padding_vertical">21dp</dimen>
     <dimen name="browser_toolbar_site_security_padding_horizontal">8dp</dimen>
 
+    <dimen name="tabs_panel_indicator_width">72dp</dimen>
+    <dimen name="tabs_panel_button_width">60dp</dimen>
     <dimen name="panel_grid_view_column_width">200dp</dimen>
 
     <dimen name="reading_list_row_height">96dp</dimen>
     <dimen name="reading_list_row_padding_right">15dp</dimen>
 
     <dimen name="tab_queue_container_width">360dp</dimen>
 
     <!-- Should be closer to 0.83 (140/168) but various roundings mean that 0.9 works better -->
--- a/mobile/android/base/resources/values-xlarge-v11/dimens.xml
+++ b/mobile/android/base/resources/values-xlarge-v11/dimens.xml
@@ -1,13 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <resources>
 
     <dimen name="browser_toolbar_height">56dp</dimen>
-    <dimen name="tabs_panel_indicator_width">60dp</dimen>
     <dimen name="panel_grid_view_column_width">250dp</dimen>
     <dimen name="new_tablet_tab_panel_grid_padding">48dp</dimen>
 
 </resources>
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -121,16 +121,17 @@
     <dimen name="prompt_service_icon_size">36dp</dimen>
     <dimen name="prompt_service_icon_text_padding">10dp</dimen>
     <dimen name="prompt_service_inputs_padding">16dp</dimen>
     <dimen name="prompt_service_left_right_text_with_icon_padding">10dp</dimen>
     <dimen name="prompt_service_top_bottom_text_with_icon_padding">8dp</dimen>
     <dimen name="tab_thumbnail_height">90dp</dimen>
     <dimen name="tab_thumbnail_width">160dp</dimen>
     <dimen name="tabs_panel_indicator_width">60dp</dimen>
+    <dimen name="tabs_panel_button_width">48dp</dimen>
     <dimen name="tabs_strip_height">40dp</dimen>
     <dimen name="tabs_strip_button_width">100dp</dimen>
     <dimen name="tabs_strip_button_padding">18dp</dimen>
     <dimen name="tabs_strip_shadow_size">1dp</dimen>
     <dimen name="tabs_layout_horizontal_height">156dp</dimen>
     <dimen name="text_selection_handle_width">47dp</dimen>
     <dimen name="text_selection_handle_height">58dp</dimen>
     <dimen name="text_selection_handle_shadow">11dp</dimen>