Bug 631156 - Bug 628885 breaks non-libxul builds with an undefined reference error for CrashReporter::AppendAppNotesToCrashReport(nsACString_internal const&), r=cjones,a=roc
authorEhsan Akhgari <ehsan@mozilla.com>
Thu, 03 Feb 2011 21:43:29 +1300
changeset 61834 e1d2e090c9a6aa796f2bc4aff97a8e497ee81d4d
parent 61833 133443c095646cb8f83ef10f3b67090b9b80c764
child 61835 b4e9a17e7fe2f98f46c528af4ead056527e1d7b7
push id18515
push userrocallahan@mozilla.com
push dateThu, 03 Feb 2011 08:59:03 +0000
treeherdermozilla-central@274e546e9da9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscjones, roc
bugs631156, 628885
milestone2.0b12pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 631156 - Bug 628885 breaks non-libxul builds with an undefined reference error for CrashReporter::AppendAppNotesToCrashReport(nsACString_internal const&), r=cjones,a=roc
xpcom/base/nsDebugImpl.cpp
--- a/xpcom/base/nsDebugImpl.cpp
+++ b/xpcom/base/nsDebugImpl.cpp
@@ -329,17 +329,17 @@ NS_DebugBreak(PRUint32 aSeverity, const 
    case NS_DEBUG_WARNING:
      return;
 
    case NS_DEBUG_BREAK:
      Break(buf.buffer);
      return;
 
    case NS_DEBUG_ABORT: {
-#ifdef MOZ_CRASHREPORTER
+#if defined(MOZ_CRASHREPORTER) && defined(MOZ_ENABLE_LIBXUL)
      nsCString note("xpcom_runtime_abort(");
      note += buf.buffer;
      note += ")";
      CrashReporter::AppendAppNotesToCrashReport(note);
 #endif  // MOZ_CRASHREPORTER
 
 #if defined(DEBUG) && defined(_WIN32)
      RealBreak();