servo: Merge #13087 - Need better description for mach subcommands #12402 (from yoyo930021:new); r=Wafflespeanut
authoryoyo930021 <yoyo930021@gmail.com>
Sun, 28 Aug 2016 08:50:17 -0500
changeset 339597 e1676ab8fedbebf02e317466a5f28bf31657b215
parent 339596 9fa37a9633e101cb25d1b619eb22ebc933ab94ad
child 339598 e1f923ace1e91e8913e01faefb98ccc08ab3ec9d
push id31307
push usergszorc@mozilla.com
push dateSat, 04 Feb 2017 00:59:06 +0000
treeherdermozilla-central@94079d43835f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersWafflespeanut
servo: Merge #13087 - Need better description for mach subcommands #12402 (from yoyo930021:new); r=Wafflespeanut <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12402 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because is description <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: d807cc2727130a5e2f4f8a05925f7f0bb2243537
servo/python/servo/testing_commands.py
--- a/servo/python/servo/testing_commands.py
+++ b/servo/python/servo/testing_commands.py
@@ -333,30 +333,30 @@ class MachCommands(CommandBase):
         run_file = path.abspath(path.join(test_file_dir, "runtests.py"))
         run_globals = {"__file__": run_file}
         execfile(run_file, run_globals)
 
         verbose = not quiet
         return run_globals["run_tests"](tests, verbose)
 
     @Command('test-wpt-failure',
-             description='Run the web platform tests',
+             description='Run the tests harness that verifies that the test failures are reported correctly',
              category='testing')
     def test_wpt_failure(self):
         self.ensure_bootstrapped()
         return not call([
             "bash",
             path.join("tests", "wpt", "run.sh"),
             "--no-pause-after-test",
             "--include",
             "infrastructure/failing-test.html"
         ], env=self.build_env())
 
     @Command('test-wpt',
-             description='Run the web platform tests',
+             description='Run the regular web platform test suite',
              category='testing',
              parser=create_parser_wpt)
     def test_wpt(self, **kwargs):
         self.ensure_bootstrapped()
         return self.run_test_list_or_dispatch(kwargs["test_list"], "wpt", self._test_wpt, **kwargs)
 
     def _test_wpt(self, **kwargs):
         hosts_file_path = path.join(self.context.topdir, 'tests', 'wpt', 'hosts')
@@ -398,17 +398,17 @@ class MachCommands(CommandBase):
                 binary_args.append("--pref=" + pref)
             kwargs["binary_args"] = binary_args
 
         run_globals = {"__file__": run_file}
         execfile(run_file, run_globals)
         return run_globals["run_tests"](**kwargs)
 
     @Command('update-manifest',
-             description='run test-wpt --manifest-update SKIP_TESTS to regenerate MANIFEST.json',
+             description='Run test-wpt --manifest-update SKIP_TESTS to regenerate MANIFEST.json',
              category='testing',
              parser=create_parser_wpt)
     def update_manifest(self, **kwargs):
         kwargs['test_list'].append(str('SKIP_TESTS'))
         kwargs['manifest_update'] = True
         return self.test_wpt(**kwargs)
 
     @Command('update-wpt',
@@ -458,29 +458,29 @@ class MachCommands(CommandBase):
     @CommandArgument('--release', '-r', action='store_true',
                      help='Run the release build')
     @CommandArgument('--dev', '-d', action='store_true',
                      help='Run the dev build')
     def update_jquery(self, release, dev):
         return self.jquery_test_runner("update", release, dev)
 
     @Command('test-css',
-             description='Run the web platform tests',
+             description='Run the web platform CSS tests',
              category='testing',
              parser=create_parser_wpt)
     def test_css(self, **kwargs):
         self.ensure_bootstrapped()
         return self.run_test_list_or_dispatch(kwargs["test_list"], "css", self._test_css, **kwargs)
 
     def _test_css(self, **kwargs):
         run_file = path.abspath(path.join("tests", "wpt", "run_css.py"))
         return self.wptrunner(run_file, **kwargs)
 
     @Command('update-css',
-             description='Update the web platform tests',
+             description='Update the web platform CSS tests',
              category='testing',
              parser=updatecommandline.create_parser())
     @CommandArgument('--patch', action='store_true', default=False,
                      help='Create an mq patch or git commit containing the changes')
     def update_css(self, patch, **kwargs):
         self.ensure_bootstrapped()
         run_file = path.abspath(path.join("tests", "wpt", "update_css.py"))
         kwargs["no_patch"] = not patch
@@ -489,17 +489,17 @@ class MachCommands(CommandBase):
             print("Are you sure you don't want a patch?")
             return 1
 
         run_globals = {"__file__": run_file}
         execfile(run_file, run_globals)
         return run_globals["update_tests"](**kwargs)
 
     @Command('compare_dromaeo',
-             description='compare outputs of two runs of ./mach test-dromaeo command',
+             description='Compare outputs of two runs of ./mach test-dromaeo command',
              category='testing')
     @CommandArgument('params', default=None, nargs="...",
                      help=" filepaths of output files of two runs of dromaeo test ")
     def compare_dromaeo(self, params):
         prev_op_filename = params[0]
         cur_op_filename = params[1]
         result = {'Test': [], 'Prev_Time': [], 'Cur_Time': [], 'Difference(%)': []}
         with open(prev_op_filename, 'r') as prev_op, open(cur_op_filename, 'r') as cur_op: