Bug 1659589: Remove error event listener that set to stylesheet actor. r=ochameau
authorDaisuke Akatsuka <daisuke@birchill.co.jp>
Tue, 01 Sep 2020 01:44:28 +0000
changeset 547125 e1242e04253e6969871f10c3e38bb6cd906b2587
parent 547124 ad6708adb4cc62da41ae9374681c784e61c1ac9a
child 547126 b3e160c2f1104ae303020ef5738f14dabda509c5
push id37745
push userbtara@mozilla.com
push dateTue, 01 Sep 2020 09:45:42 +0000
treeherdermozilla-central@ea855bdc21ea [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersochameau
bugs1659589
milestone82.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1659589: Remove error event listener that set to stylesheet actor. r=ochameau Depends on D87047 Differential Revision: https://phabricator.services.mozilla.com/D88531
devtools/client/styleeditor/StyleSheetEditor.jsm
--- a/devtools/client/styleeditor/StyleSheetEditor.jsm
+++ b/devtools/client/styleeditor/StyleSheetEditor.jsm
@@ -110,27 +110,25 @@ function StyleSheetEditor(
   if (
     this.styleSheet.href &&
     Services.io.extractScheme(this.styleSheet.href) == "file"
   ) {
     this._styleSheetFilePath = this.styleSheet.href;
   }
 
   this.onPropertyChange = this.onPropertyChange.bind(this);
-  this._onError = this._onError.bind(this);
   this.onMediaRulesChanged = this.onMediaRulesChanged.bind(this);
   this.checkLinkedFileForChanges = this.checkLinkedFileForChanges.bind(this);
   this.markLinkedFileBroken = this.markLinkedFileBroken.bind(this);
   this.saveToFile = this.saveToFile.bind(this);
   this.updateStyleSheet = this.updateStyleSheet.bind(this);
   this._updateStyleSheet = this._updateStyleSheet.bind(this);
   this._onMouseMove = this._onMouseMove.bind(this);
 
   this._focusOnSourceEditorReady = false;
-  this.styleSheet.on("error", this._onError);
   this.savedFile = this.styleSheet.file;
   this.linkCSSFile();
 
   this.emitMediaRulesChanged = throttle(
     this.emitMediaRulesChanged,
     EMIT_MEDIA_RULES_THROTTLING,
     this
   );
@@ -438,25 +436,16 @@ StyleSheetEditor.prototype = {
   /**
    * Forward media-rules-changed event from stylesheet.
    */
   emitMediaRulesChanged: function() {
     this.emit("media-rules-changed", this.mediaRules);
   },
 
   /**
-   * Forward error event from stylesheet.
-   *
-   * @param  {Object} data: The parameters to customize the error message
-   */
-  _onError: function(data) {
-    this.emit("error", data);
-  },
-
-  /**
    * Create source editor and load state into it.
    * @param  {DOMElement} inputElement
    *         Element to load source editor in
    * @param  {CssProperties} cssProperties
    *         A css properties database.
    *
    * @return {Promise}
    *         Promise that will resolve when the style editor is loaded.
@@ -894,17 +883,16 @@ StyleSheetEditor.prototype = {
       ) {
         this._sourceEditor.container.contentWindow.removeEventListener(
           "mousemove",
           this._onMouseMove
         );
       }
       this._sourceEditor.destroy();
     }
-    this.styleSheet.off("error", this._onError);
     this._isDestroyed = true;
   },
 };
 
 /**
  * Find a path on disk for a file given it's hosted uri, the uri of the
  * original resource that generated it (e.g. Sass file), and the location of the
  * local file for that source.