Bug 1416282 - Assert earlier to try to get a more helpful stack.
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sat, 27 Oct 2018 13:16:48 +0200
changeset 443254 e11449a47b08244567e6252a662950f9d1e44edc
parent 443253 7f654e4a9a64e8431a64fa432ca768bec09c13cd
child 443255 6d7686f1082fbfc2ff22854ad7b69201e03370fb
child 443258 3415a6d8d9357a0ba2ad6f63812b9c0a5b14e3e5
push id34947
push userdluca@mozilla.com
push dateSat, 27 Oct 2018 21:53:25 +0000
treeherdermozilla-central@6d7686f1082f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1416282
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1416282 - Assert earlier to try to get a more helpful stack.
servo/components/selectors/builder.rs
--- a/servo/components/selectors/builder.rs
+++ b/servo/components/selectors/builder.rs
@@ -67,17 +67,17 @@ impl<Impl: SelectorImpl> Push<Component<
         self.push_simple_selector(value);
     }
 }
 
 impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
     /// Pushes a simple selector onto the current compound selector.
     #[inline(always)]
     pub fn push_simple_selector(&mut self, ss: Component<Impl>) {
-        debug_assert!(!ss.is_combinator());
+        assert!(!ss.is_combinator());
         self.simple_selectors.push(ss);
         self.current_len += 1;
     }
 
     /// Completes the current compound selector and starts a new one, delimited
     /// by the given combinator.
     #[inline(always)]
     pub fn push_combinator(&mut self, c: Combinator) {