Bug 626667, part2 - get rid GetCachedParent, r=davidb, a=davidb try: -u mochitest-o
authorAlexander Surkov <surkov.alexander@gmail.com>
Sat, 29 Jan 2011 16:02:16 +0800
changeset 61583 e006628cc089ab82641e56c9e9ae08315a97b3a3
parent 61582 4b8113a528f00a023fdfbd6ec499f435c5baf978
child 61584 11db9166ba1c991ae12446351d40bf2e7bce11bd
push id18397
push usersurkov.alexander@gmail.com
push dateSat, 29 Jan 2011 08:03:14 +0000
treeherdermozilla-central@e006628cc089 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdavidb, davidb
bugs626667
milestone2.0b11pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 626667, part2 - get rid GetCachedParent, r=davidb, a=davidb try: -u mochitest-o
accessible/src/base/AccEvent.cpp
accessible/src/base/nsAccessible.h
accessible/src/base/nsDocAccessible.cpp
--- a/accessible/src/base/AccEvent.cpp
+++ b/accessible/src/base/AccEvent.cpp
@@ -316,17 +316,17 @@ AccMutationEvent::
 ////////////////////////////////////////////////////////////////////////////////
 // AccHideEvent
 ////////////////////////////////////////////////////////////////////////////////
 
 AccHideEvent::
   AccHideEvent(nsAccessible* aTarget, nsINode* aTargetNode) :
   AccMutationEvent(::nsIAccessibleEvent::EVENT_HIDE, aTarget, aTargetNode)
 {
-  mParent = mAccessible->GetCachedParent();
+  mParent = mAccessible->GetParent();
   mNextSibling = mAccessible->GetCachedNextSibling();
   mPrevSibling = mAccessible->GetCachedPrevSibling();
 }
 
 
 ////////////////////////////////////////////////////////////////////////////////
 // AccShowEvent
 ////////////////////////////////////////////////////////////////////////////////
--- a/accessible/src/base/nsAccessible.h
+++ b/accessible/src/base/nsAccessible.h
@@ -301,17 +301,16 @@ public:
   /**
    * Return index of the given embedded accessible child.
    */
   PRInt32 GetIndexOfEmbeddedChild(nsAccessible* aChild);
 
   /**
    * Return cached accessible of parent-child relatives.
    */
-  nsAccessible* GetCachedParent() const { return mParent; }
   nsAccessible* GetCachedNextSibling() const
   {
     return mParent ?
       mParent->mChildren.SafeElementAt(mIndexInParent + 1, nsnull).get() : nsnull;
   }
   nsAccessible* GetCachedPrevSibling() const
   {
     return mParent ?
--- a/accessible/src/base/nsDocAccessible.cpp
+++ b/accessible/src/base/nsDocAccessible.cpp
@@ -602,17 +602,17 @@ nsDocAccessible::GetAccessible(nsINode* 
     accessible = const_cast<nsDocAccessible*>(this);
   }
 
 #ifdef DEBUG
   // All cached accessible nodes should be in the parent
   // It will assert if not all the children were created
   // when they were first cached, and no invalidation
   // ever corrected parent accessible's child cache.
-  nsAccessible* parent(accessible->GetCachedParent());
+  nsAccessible* parent(accessible->GetParent());
   if (parent)
     parent->TestChildCache(accessible);
 #endif
 
   return accessible;
 }
 
 ////////////////////////////////////////////////////////////////////////////////