Bug 1366156 - Temporarily disable the collection of content js delay event telemetry probes to investigate whether they are the cause of child process INPUT_EVENT_RESPONSE_MS regressions; r=farre
authorEhsan Akhgari <ehsan@mozilla.com>
Fri, 19 May 2017 00:58:18 -0400
changeset 359360 dfdebc342d2e519761cec89c60bc16a9404ca9b3
parent 359359 b7d23ef00079f2256528f3bcd08ac32344f48287
child 359361 095aca8a91e68b8b4a723dc016becb37b9c5d1ff
push id31853
push userkwierso@gmail.com
push dateFri, 19 May 2017 22:14:28 +0000
treeherdermozilla-central@8d60d0f82511 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfarre
bugs1366156
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1366156 - Temporarily disable the collection of content js delay event telemetry probes to investigate whether they are the cause of child process INPUT_EVENT_RESPONSE_MS regressions; r=farre
ipc/glue/BackgroundChildImpl.cpp
xpcom/threads/SchedulerGroup.cpp
--- a/ipc/glue/BackgroundChildImpl.cpp
+++ b/ipc/glue/BackgroundChildImpl.cpp
@@ -564,21 +564,24 @@ BackgroundChildImpl::DeallocPGamepadTest
   delete static_cast<dom::GamepadTestChannelChild*>(aActor);
   return true;
 }
 
 #ifdef EARLY_BETA_OR_EARLIER
 void
 BackgroundChildImpl::OnChannelReceivedMessage(const Message& aMsg)
 {
+// Telemetry collection temporarily disabled in bug 1366156.
+#if 0
   if (aMsg.type() == layout::PVsync::MessageType::Msg_Notify__ID) {
     // Not really necessary to look at the message payload, it will be
     // <0.5ms away from TimeStamp::Now()
     SchedulerGroup::MarkVsyncReceived();
   }
+#endif
 }
 #endif
 
 dom::PWebAuthnTransactionChild*
 BackgroundChildImpl::AllocPWebAuthnTransactionChild()
 {
   MOZ_CRASH("PWebAuthnTransaction actor should be manually constructed!");
   return nullptr;
--- a/xpcom/threads/SchedulerGroup.cpp
+++ b/xpcom/threads/SchedulerGroup.cpp
@@ -56,28 +56,34 @@ static Atomic<uint64_t> gEarliestUnproce
 class MOZ_RAII AutoCollectVsyncTelemetry final
 {
 public:
   explicit AutoCollectVsyncTelemetry(SchedulerGroup::Runnable* aRunnable
                                      MOZ_GUARD_OBJECT_NOTIFIER_PARAM)
     : mIsBackground(aRunnable->IsBackground())
   {
     MOZ_GUARD_OBJECT_NOTIFIER_INIT;
+// Telemetry collection temporarily disabled in bug 1366156.
+#if 0
 #ifdef EARLY_BETA_OR_EARLIER
     aRunnable->GetName(mKey);
     mStart = TimeStamp::Now();
 #endif
+#endif
   }
   ~AutoCollectVsyncTelemetry()
   {
+// Telemetry collection temporarily disabled in bug 1366156.
+#if 0
 #ifdef EARLY_BETA_OR_EARLIER
     if (Telemetry::CanRecordBase()) {
       CollectTelemetry();
     }
 #endif
+#endif
   }
 
 private:
   void CollectTelemetry();
 
   bool mIsBackground;
   nsCString mKey;
   TimeStamp mStart;