Bug 1159650 - Remove incorrect value assertions in BluetoothGattCharacteristic and BluetoothGattDescriptor. r=btian
authorJocelyn Liu <joliu@mozilla.com>
Wed, 29 Apr 2015 19:53:00 -0400
changeset 242037 df6cfb090e06632d95469ef9d27368e5dafaf6f7
parent 242036 5e40e02cb8725ad9b02e6cabc83ac272edf285df
child 242038 6f5fc21d5ea60ed8707fed65a32f45582414b417
push id28675
push userkwierso@gmail.com
push dateSat, 02 May 2015 00:22:37 +0000
treeherdermozilla-central@767d72d50db8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbtian
bugs1159650
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1159650 - Remove incorrect value assertions in BluetoothGattCharacteristic and BluetoothGattDescriptor. r=btian
dom/bluetooth/bluetooth2/BluetoothGattCharacteristic.cpp
dom/bluetooth/bluetooth2/BluetoothGattDescriptor.cpp
--- a/dom/bluetooth/bluetooth2/BluetoothGattCharacteristic.cpp
+++ b/dom/bluetooth/bluetooth2/BluetoothGattCharacteristic.cpp
@@ -190,18 +190,16 @@ BluetoothGattCharacteristic::WrapObject(
 {
   return BluetoothGattCharacteristicBinding::Wrap(aContext, this, aGivenProto);
 }
 
 void
 BluetoothGattCharacteristic::GetValue(JSContext* cx,
                                       JS::MutableHandle<JSObject*> aValue) const
 {
-  MOZ_ASSERT(aValue);
-
   aValue.set(mValue.IsEmpty()
              ? nullptr
              : ArrayBuffer::Create(cx, mValue.Length(), mValue.Elements()));
 }
 
 void
 BluetoothGattCharacteristic::GetProperties(
   mozilla::dom::GattCharacteristicProperties& aProperties) const
--- a/dom/bluetooth/bluetooth2/BluetoothGattDescriptor.cpp
+++ b/dom/bluetooth/bluetooth2/BluetoothGattDescriptor.cpp
@@ -107,18 +107,16 @@ BluetoothGattDescriptor::WrapObject(JSCo
 {
   return BluetoothGattDescriptorBinding::Wrap(aContext, this, aGivenProto);
 }
 
 void
 BluetoothGattDescriptor::GetValue(JSContext* cx,
                                   JS::MutableHandle<JSObject*> aValue) const
 {
-  MOZ_ASSERT(aValue);
-
   aValue.set(mValue.IsEmpty()
              ? nullptr
              : ArrayBuffer::Create(cx, mValue.Length(), mValue.Elements()));
 }
 
 class ReadValueTask final : public BluetoothReplyRunnable
 {
 public: