Bug 1528919 [wpt PR 15458] - Remove default padding for cue text rendering, a=testonly
☠☠ backed out by 66b1aba3fb43 ☠ ☠
authorSriram <srirama.m@samsung.com>
Wed, 06 Mar 2019 10:35:22 +0000
changeset 464274 df087069273bff0542e3ac040d32526220438fa9
parent 464273 43debb14a0040caf856018d8eee0f318de3dd8a7
child 464275 05ff2e535c6e27596cb51cce0794ecb13aaa902e
push id35713
push usercbrindusan@mozilla.com
push dateFri, 15 Mar 2019 21:55:43 +0000
treeherdermozilla-central@66b1aba3fb43 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1528919, 15458, 930608, 843136, 1475567, 633624
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528919 [wpt PR 15458] - Remove default padding for cue text rendering, a=testonly Automatic update from web-platform-tests Remove default padding for cue text rendering Per spec there is no default padding for text track cue rendering. Removing the default padding for cue text. BUG=930608, 843136 Change-Id: If931c1faff528a87d8a78808f30225ebe2377072 Reviewed-on: https://chromium-review.googlesource.com/c/1475567 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#633624} -- wpt-commits: a51d2e77614c6baff6c42b02ecd4915b19c020b2 wpt-pr: 15458
testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue-ref.html
testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue.html
testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-line-doesnt-fit-ref.html
testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-transformed-video-ref.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue-ref.html
@@ -0,0 +1,27 @@
+<!DOCTYPE html>
+<html class="reftest-wait">
+<title>Reference for track rendering with empty cue</title>
+<script src="/common/reftest-wait.js"></script>
+<style>
+html { overflow:hidden }
+body { margin:0 }
+.container {
+  display: inline-block;
+  position: relative;
+}
+</style>
+<div class="container">
+  <video width="320" height="180">
+    <source src="/media/white.webm" type="video/webm">
+    <source src="/media/white.mp4" type="video/mp4">
+    <script>
+      var video = document.querySelector("video");
+      video.addEventListener('playing', () => {
+        video.pause();
+        takeScreenshot();
+      }, { once: true});
+      video.play();
+    </script>
+  </video>
+</div>
+</html>
\ No newline at end of file
--- a/testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue.html
+++ b/testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue.html
@@ -1,16 +1,26 @@
 <!DOCTYPE html>
-<title>Empty cues</title>
-<script src="/common/media.js"></script>
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script>
-async_test(function(t) {
-    var video = document.createElement("video");
-    video.src = getVideoURI("/media/test");
-    video.addTextTrack("captions", "regular captions track", "en");
-    video.textTracks[0].addCue(new VTTCue(0, 4, ""));
+<html class="reftest-wait">
+<title>Track rendering with empty cue</title>
+<link rel="match" href="track-cue-rendering-empty-cue-ref.html">
+<style>
+html { overflow:hidden }
+body { margin:0 }
+</style>
+<script src="/common/reftest-wait.js"></script>
+<video width="320" height="180">
+  <source src="/media/white.webm" type="video/webm">
+  <source src="/media/white.mp4" type="video/mp4">
+  <script>
+    var video = document.querySelector("video");
+    var track = video.addTextTrack("captions", "regular captions track", "en");
+    track.addCue(new VTTCue(0, 4, ""));
+    track.mode = "showing";
 
-    video.onplaying = t.step_func_done();
+    video.addEventListener('playing', () => {
+      video.pause();
+      takeScreenshot();
+    }, { once: true});
     video.play();
-});
-</script>
\ No newline at end of file
+  </script>
+</video>
+</html>
\ No newline at end of file
--- a/testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-line-doesnt-fit-ref.html
+++ b/testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-line-doesnt-fit-ref.html
@@ -15,17 +15,16 @@
   right: 0;
   overflow: hidden;
 }
 .cue > span {
   font-family: sans-serif;
   background: green;
   color: green;
   font-size: 120px;
-  padding: 2px;
 }
 </style>
 <div class="container">
   <video autoplay onplaying="this.onplaying = null; this.pause(); takeScreenshot();">
     <source src="/media/white.webm" type="video/webm">
     <source src="/media/white.mp4" type="video/mp4">
   </video>
   <div class="cue"><span>PAS</span></div>
--- a/testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-transformed-video-ref.html
+++ b/testing/web-platform/tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-transformed-video-ref.html
@@ -17,17 +17,16 @@
   overflow: hidden;
   text-align: start;
 }
 .cue > span {
   font-family: sans-serif;
   background: green;
   color: green;
   font-size: 50px;
-  padding: 2px;
 }
 </style>
 <div class="container">
   <video autoplay onplaying="this.onplaying = null; this.pause(); takeScreenshot();">
     <source src="/media/white.webm" type="video/webm">
     <source src="/media/white.mp4" type="video/mp4">
   </video>
   <div class="cue"><span>XXX</span></div>