Bug 1509603 [wpt PR 14217] - Set default for manifest_update flag appropriately., a=testonly
authorJosh Matthews <josh@joshmatthews.net>
Fri, 30 Nov 2018 18:01:29 +0000
changeset 450002 dde5b3ab8b5d0a887cc399f14c8c6fe7e26400e9
parent 450001 08797c16266cdff62504a362f0f9b40d635cdc1e
child 450003 01034b130bc60235f297cd7799273bad7a5d70a5
push id35189
push userccoroiu@mozilla.com
push dateTue, 11 Dec 2018 21:33:05 +0000
treeherdermozilla-central@ac7f3beb6333 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1509603, 14217
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1509603 [wpt PR 14217] - Set default for manifest_update flag appropriately., a=testonly Automatic update from web-platform-tests Set default for manifest_update flag appropriately. -- wpt-commits: 81607985fc9485cbf9f3d0a8ae74359f885eb36b wpt-pr: 14217
testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
@@ -42,17 +42,17 @@ def create_parser(product_choices=None):
         config_data = config.load()
         product_choices = products.products_enabled(config_data)
 
     parser = argparse.ArgumentParser(description="""Runner for web-platform-tests tests.""",
                                      usage="""%(prog)s [OPTION]... [TEST]...
 
 TEST is either the full path to a test file to run, or the URL of a test excluding
 scheme host and port.""")
-    parser.add_argument("--manifest-update", action="store_true", default=True,
+    parser.add_argument("--manifest-update", action="store_true", default=None,
                         help="Regenerate the test manifest.")
     parser.add_argument("--no-manifest-update", action="store_false", dest="manifest_update",
                         help="Prevent regeneration of the test manifest.")
     parser.add_argument("--manifest-download", action="store_true", default=None,
                         help="Attempt to download a preexisting manifest when updating.")
 
     parser.add_argument("--timeout-multiplier", action="store", type=float, default=None,
                         help="Multiplier relative to standard test timeout to use")
@@ -429,16 +429,19 @@ def check_paths(kwargs):
 
 
 def check_args(kwargs):
     set_from_config(kwargs)
 
     if kwargs["product"] is None:
         kwargs["product"] = "firefox"
 
+    if kwargs["manifest_update"] is None:
+        kwargs["manifest_update"] = True
+
     if "sauce" in kwargs["product"]:
         kwargs["pause_after_test"] = False
 
     if kwargs["test_list"]:
         if kwargs["include"] is not None:
             kwargs["include"].extend(kwargs["test_list"])
         else:
             kwargs["include"] = kwargs["test_list"]