Bug 569994: Fix GCC warning "suggest parentheses around && within ||" in nsTreeBodyFrame.cpp. r=ehsan
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 04 Jun 2010 13:38:17 -0700
changeset 43104 ddd93345ad4896c3165e36f83c76e6a8f68ef8ed
parent 43103 979fbcd8bb298f5272d459743fb427b8086e4205
child 43105 661a75f690120fd61308e7cec893e866dd9c0e87
push id13619
push userdholbert@mozilla.com
push dateFri, 04 Jun 2010 20:39:45 +0000
treeherdermozilla-central@661a75f69012 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs569994
milestone1.9.3a5pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 569994: Fix GCC warning "suggest parentheses around && within ||" in nsTreeBodyFrame.cpp. r=ehsan
layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp
--- a/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp
+++ b/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp
@@ -1544,18 +1544,18 @@ nsTreeBodyFrame::GetItemWithinCellAt(nsc
     // If we're the primary column, we have indentation and a twisty.
     PRInt32 level;
     mView->GetLevel(aRowIndex, &level);
 
     if (!isRTL)
       currX += mIndentation*level;
     remainingWidth -= mIndentation*level;
 
-    if (isRTL && aX > currX + remainingWidth ||
-        !isRTL && aX < currX) {
+    if ((isRTL && aX > currX + remainingWidth) ||
+        (!isRTL && aX < currX)) {
       // The user clicked within the indentation.
       return nsCSSAnonBoxes::moztreecell;
     }
 
     // Always leave space for the twisty.
     nsRect twistyRect(currX, cellRect.y, remainingWidth, cellRect.height);
     PRBool hasTwisty = PR_FALSE;
     PRBool isContainer = PR_FALSE;