Bug 1282795 - Make InvokeState final to silence some -Wdelete-non-virtual-dtor warnings caused by Maybe<InvokeState>. r=froydnj
authorJeff Walden <jwalden@mit.edu>
Tue, 28 Jun 2016 17:11:35 +0100
changeset 303080 ddd5a4c1edc8774f7a0179856ecfec36164a4795
parent 303079 9c4675f6970fe850de47cffb3b1fb504d35fa563
child 303081 cd248c790c8c9d3ca3eba319858244259d7cba79
push id30379
push usercbook@mozilla.com
push dateWed, 29 Jun 2016 14:13:35 +0000
treeherdermozilla-central@b69a5bbb5e40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1282795
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1282795 - Make InvokeState final to silence some -Wdelete-non-virtual-dtor warnings caused by Maybe<InvokeState>. r=froydnj
js/src/vm/Interpreter.h
--- a/js/src/vm/Interpreter.h
+++ b/js/src/vm/Interpreter.h
@@ -271,17 +271,17 @@ class ExecuteState : public RunState
 
     virtual void setReturnValue(Value v) {
         if (result_)
             *result_ = v;
     }
 };
 
 // Data to invoke a function.
-class InvokeState : public RunState
+class InvokeState final : public RunState
 {
     const CallArgs& args_;
     MaybeConstruct construct_;
     bool createSingleton_;
 
   public:
     InvokeState(JSContext* cx, const CallArgs& args, MaybeConstruct construct)
       : RunState(cx, Invoke, args.callee().as<JSFunction>().nonLazyScript()),