Bug 1525402 - Bump cbindgen to 0.8.6. r=kvark
authorAlexis Beingessner <a.beingessner@gmail.com>
Tue, 07 May 2019 01:40:15 +0000
changeset 472817 ddce4ed9bb05e90f16187c66c798737110ca4be9
parent 472816 5ce032a6115e0ff4980487738194cbaf83a8585d
child 472818 0c2296965b7b07a50a8b8a643de442f03f196b27
push id35978
push usershindli@mozilla.com
push dateTue, 07 May 2019 09:44:39 +0000
treeherdermozilla-central@7aee5a30dd15 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskvark
bugs1525402
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1525402 - Bump cbindgen to 0.8.6. r=kvark This version adds support for Rust 2018's new externs Differential Revision: https://phabricator.services.mozilla.com/D29565
build/moz.configure/bindgen.configure
taskcluster/scripts/misc/build-cbindgen.sh
--- a/build/moz.configure/bindgen.configure
+++ b/build/moz.configure/bindgen.configure
@@ -10,17 +10,17 @@ cbindgen_is_needed = depends(build_proje
 option(env='CBINDGEN', nargs=1, when=cbindgen_is_needed,
        help='Path to cbindgen')
 
 
 @imports(_from='textwrap', _import='dedent')
 def check_cbindgen_version(cbindgen, fatal=False):
     log.debug("trying cbindgen: %s" % cbindgen)
 
-    cbindgen_min_version = Version('0.8.3')
+    cbindgen_min_version = Version('0.8.6')
 
     # cbindgen x.y.z
     version = Version(check_cmd_output(cbindgen, '--version').strip().split(" ")[1])
     log.debug("%s has version %s" % (cbindgen, version))
     if version >= cbindgen_min_version:
         return True
     if not fatal:
         return False
--- a/taskcluster/scripts/misc/build-cbindgen.sh
+++ b/taskcluster/scripts/misc/build-cbindgen.sh
@@ -1,14 +1,14 @@
 #!/bin/bash
 set -x -e -v
 
 # If you update this, make sure to update the minimum version in
 # build/moz.configure/bindgen.configure as well.
-CBINDGEN_REVISION=ba02367253bcffb6f4dcfe4bc27005e9cae78edd # v0.8.3
+CBINDGEN_REVISION=5ec5a82d268c8fe907767394ee7ad15718f3f09d # v0.8.6
 TARGET="$1"
 
 case "$(uname -s)" in
 Linux)
     WORKSPACE=$HOME/workspace
     UPLOAD_DIR=$HOME/artifacts
     COMPRESS_EXT=xz
     ;;