Bug 1198730: fix simple bug in PMTUD disable that clears all other flags r=tuexen
authorRandell Jesup <rjesup@jesup.org>
Wed, 26 Aug 2015 10:05:39 -0400
changeset 259391 dda56b1c5210e9e983d9a24c92b5a9986fdf60b1
parent 259390 c3b9538afc427bb568c6f43e90e9db2a75656243
child 259392 ba8758c89322f23eb570432cfd72a9ae535e330b
push id29277
push userryanvm@gmail.com
push dateWed, 26 Aug 2015 18:32:23 +0000
treeherdermozilla-central@fea87cbeaa6b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstuexen
bugs1198730
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1198730: fix simple bug in PMTUD disable that clears all other flags r=tuexen
netwerk/sctp/datachannel/DataChannel.cpp
--- a/netwerk/sctp/datachannel/DataChannel.cpp
+++ b/netwerk/sctp/datachannel/DataChannel.cpp
@@ -608,17 +608,17 @@ DataChannelConnection::CompleteConnect(T
       opt_len = (socklen_t)sizeof(struct sctp_paddrparams);
       r = usrsctp_getsockopt(mMasterSocket, IPPROTO_SCTP, SCTP_PEER_ADDR_PARAMS,
                              &paddrparams, &opt_len);
       if (r < 0) {
         LOG(("usrsctp_getsockopt failed: %d", r));
       } else {
         // draft-ietf-rtcweb-data-channel-13 section 5: max initial MTU IPV4 1200, IPV6 1280
         paddrparams.spp_pathmtu = 1200; // safe for either
-        paddrparams.spp_flags &= !SPP_PMTUD_ENABLE;
+        paddrparams.spp_flags &= ~SPP_PMTUD_ENABLE;
         paddrparams.spp_flags |= SPP_PMTUD_DISABLE;
         opt_len = (socklen_t)sizeof(struct sctp_paddrparams);
         r = usrsctp_setsockopt(mMasterSocket, IPPROTO_SCTP, SCTP_PEER_ADDR_PARAMS,
                                &paddrparams, opt_len);
         if (r < 0) {
           LOG(("usrsctp_getsockopt failed: %d", r));
         } else {
           LOG(("usrsctp: PMTUD disabled, MTU set to %u", paddrparams.spp_pathmtu));