| author | Tim Nguyen <ntim.bugs@gmail.com> |
| Tue, 18 Feb 2020 02:55:46 +0000 | |
| changeset 514356 | dc4f43236bcf4b320340e772264c22eb0d228885 |
| parent 514355 | 061d47c2c5c7cd1724854596b0ac718b726223df |
| child 514357 | 714d07041daf9496ff4217b84ad18051dfd01626 |
| push id | 37133 |
| push user | ncsoregi@mozilla.com |
| push date | Tue, 18 Feb 2020 09:37:36 +0000 |
| treeherder | mozilla-central@5f2e62175414 [default view] [failures only] |
| perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
| reviewers | gw |
| bugs | 1615614 |
| milestone | 75.0a1 |
| first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
| last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
| gfx/wr/webrender/res/brush_conic_gradient.glsl | file | annotate | diff | comparison | revisions | |
| gfx/wr/webrender/tests/angle_shader_validation.rs | file | annotate | diff | comparison | revisions |
--- a/gfx/wr/webrender/res/brush_conic_gradient.glsl +++ b/gfx/wr/webrender/res/brush_conic_gradient.glsl @@ -109,18 +109,18 @@ Fragment conic_gradient_brush_fs() { pos.y = V_REPEATED_SIZE.y; } #else // Apply potential horizontal and vertical repetitions. vec2 pos = mod(V_POS, V_REPEATED_SIZE); #endif vec2 current_dir = pos - V_CENTER; - float current_angle = atan(current_dir.y, current_dir.x) + (PI / 2 - V_ANGLE); - float offset = mod(current_angle / (2 * PI), 1.0); + float current_angle = atan(current_dir.y, current_dir.x) + (PI / 2.0 - V_ANGLE); + float offset = mod(current_angle / (2.0 * PI), 1.0); vec4 color = sample_gradient(V_GRADIENT_ADDRESS, offset, V_GRADIENT_REPEAT); #ifdef WR_FEATURE_ALPHA_PASS color *= init_transform_fs(V_LOCAL_POS); #endif
--- a/gfx/wr/webrender/tests/angle_shader_validation.rs +++ b/gfx/wr/webrender/tests/angle_shader_validation.rs @@ -101,16 +101,20 @@ const SHADERS: &[Shader] = &[ name: "brush_blend", features: BRUSH_FEATURES, }, Shader { name: "brush_mix_blend", features: BRUSH_FEATURES, }, Shader { + name: "brush_conic_gradient", + features: GRADIENT_FEATURES, + }, + Shader { name: "brush_radial_gradient", features: GRADIENT_FEATURES, }, Shader { name: "brush_linear_gradient", features: GRADIENT_FEATURES, }, Shader {