Bug 1034043 - Fix remaining use of "awlaysAsk" attribute in applications pref pane. r=Unfocused
author<kernp25@yahoo.com>
Thu, 03 Jul 2014 06:04:00 +1200
changeset 192535 dc44c1bd01a40f372f274ef75c842947dcda6498
parent 192502 1dc6b294800d93529cbc0bece6603d85f8685f6b
child 192536 54cb0b2e118b617fd2ca61811b54cd461ee57f10
push id27089
push usercbook@mozilla.com
push dateMon, 07 Jul 2014 12:44:49 +0000
treeherdermozilla-central@9b0206fad5f2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersUnfocused
bugs1034043
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1034043 - Fix remaining use of "awlaysAsk" attribute in applications pref pane. r=Unfocused
browser/components/preferences/applications.js
browser/components/preferences/in-content/applications.js
--- a/browser/components/preferences/applications.js
+++ b/browser/components/preferences/applications.js
@@ -1401,17 +1401,17 @@ var gApplicationsPane = {
       internalMenuItem.setAttribute("label", label);
       internalMenuItem.setAttribute("tooltiptext", label);
       internalMenuItem.setAttribute(APP_ICON_ATTR_NAME, "ask");
       menuPopup.appendChild(internalMenuItem);
     }
 
     {
       var askMenuItem = document.createElement("menuitem");
-      askMenuItem.setAttribute("alwaysAsk", "true");
+      askMenuItem.setAttribute("action", Ci.nsIHandlerInfo.alwaysAsk);
       let label;
       if (isFeedType(handlerInfo.type))
         label = this._prefsBundle.getFormattedString("previewInApp",
                                                      [this._brandShortName]);
       else
         label = this._prefsBundle.getString("alwaysAsk");
       askMenuItem.setAttribute("label", label);
       askMenuItem.setAttribute("tooltiptext", label);
--- a/browser/components/preferences/in-content/applications.js
+++ b/browser/components/preferences/in-content/applications.js
@@ -1393,17 +1393,17 @@ var gApplicationsPane = {
       internalMenuItem.setAttribute("label", label);
       internalMenuItem.setAttribute("tooltiptext", label);
       internalMenuItem.setAttribute(APP_ICON_ATTR_NAME, "ask");
       menuPopup.appendChild(internalMenuItem);
     }
 
     {
       var askMenuItem = document.createElement("menuitem");
-      askMenuItem.setAttribute("alwaysAsk", "true");
+      askMenuItem.setAttribute("action", Ci.nsIHandlerInfo.alwaysAsk);
       let label;
       if (isFeedType(handlerInfo.type))
         label = this._prefsBundle.getFormattedString("previewInApp",
                                                      [this._brandShortName]);
       else
         label = this._prefsBundle.getString("alwaysAsk");
       askMenuItem.setAttribute("label", label);
       askMenuItem.setAttribute("tooltiptext", label);