Bug 1440711 - Enable no-unused-vars for global scope on jsm files in accessible/. r=surkov
authorMark Banner <standard8@mozilla.com>
Fri, 23 Feb 2018 16:50:43 +0000
changeset 405038 dc2195c2b23914521c48fa21d40fea1a2db0db54
parent 405037 c9f3519a5cb4284c3c8e45608aa424a90f460e51
child 405039 cdfaf636da2f0c9de4dbfd7ad533796eeb802971
push id33501
push usernbeleuzu@mozilla.com
push dateSat, 24 Feb 2018 00:22:35 +0000
treeherdermozilla-central@1960b018c1f5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssurkov
bugs1440711
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1440711 - Enable no-unused-vars for global scope on jsm files in accessible/. r=surkov MozReview-Commit-ID: DMsHpliLTOi
.eslintrc.js
accessible/jsat/AccessFu.jsm
accessible/jsat/EventManager.jsm
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -48,17 +48,16 @@ module.exports = {
     ],
     "rules": {
       "mozilla/use-services": "off",
     }
   }, {
     // XXX Bug 1434446. These directories have jsm files still being fixed, so
     // turn off global no-unused-vars checking for them.
     "files": [
-      "accessible/**/*.jsm",
       "browser/components/**/*.jsm",
       "browser/extensions/**/*.jsm",
       "services/sync/**/*.jsm",
       "toolkit/**/*.jsm",
     ],
     "rules": {
       "mozilla/mark-exported-symbols-as-used": "error",
       "no-unused-vars": ["error", {
--- a/accessible/jsat/AccessFu.jsm
+++ b/accessible/jsat/AccessFu.jsm
@@ -1,34 +1,32 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-/* exported AccessFu */
-
 "use strict";
 
-this.EXPORTED_SYMBOLS = ["AccessFu"]; // jshint ignore:line
+this.EXPORTED_SYMBOLS = ["AccessFu"];
 
 ChromeUtils.import("resource://gre/modules/Services.jsm");
 ChromeUtils.import("resource://gre/modules/accessibility/Utils.jsm");
 
 if (Utils.MozBuildApp === "mobile/android") {
   ChromeUtils.import("resource://gre/modules/Messaging.jsm");
 }
 
-const ACCESSFU_DISABLE = 0; // jshint ignore:line
+// const ACCESSFU_DISABLE = 0;
 const ACCESSFU_ENABLE = 1;
 const ACCESSFU_AUTO = 2;
 
 const SCREENREADER_SETTING = "accessibility.screenreader";
 const QUICKNAV_MODES_PREF = "accessibility.accessfu.quicknav_modes";
 const QUICKNAV_INDEX_PREF = "accessibility.accessfu.quicknav_index";
 
-this.AccessFu = { // jshint ignore:line
+this.AccessFu = {
   /**
    * Initialize chrome-layer accessibility functionality.
    * If accessibility is enabled on the platform, then a special accessibility
    * mode is started.
    */
   attach: function attach(aWindow) {
     Utils.init(aWindow);
 
--- a/accessible/jsat/EventManager.jsm
+++ b/accessible/jsat/EventManager.jsm
@@ -1,16 +1,14 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 "use strict";
 
-const TEXT_NODE = 3;
-
 ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
 ChromeUtils.defineModuleGetter(this, "Services",
   "resource://gre/modules/Services.jsm");
 ChromeUtils.defineModuleGetter(this, "Utils",
   "resource://gre/modules/accessibility/Utils.jsm");
 ChromeUtils.defineModuleGetter(this, "Logger",
   "resource://gre/modules/accessibility/Utils.jsm");
 ChromeUtils.defineModuleGetter(this, "Presentation",