Bug 1624046 - Always write results with --write-results, r=remote-protocol-reviewers,maja_zf
authorJames Graham <james@hoppipolla.co.uk>
Mon, 23 Mar 2020 15:25:10 +0000
changeset 520229 dbabf2e388fa750b4901df8dfab60d8a17a0c5ff
parent 520228 ab2525a1da3b62585c7434247fa86be8e6cbb04b
child 520230 82d5ba25c1a8311f4252b1df52e216152e2f3158
push id37245
push useropoprus@mozilla.com
push dateTue, 24 Mar 2020 21:46:41 +0000
treeherdermozilla-central@dbabf2e388fa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersremote-protocol-reviewers, maja_zf
bugs1624046
milestone76.0a1
first release with
nightly linux32
dbabf2e388fa / 76.0a1 / 20200324214641 / files
nightly linux64
dbabf2e388fa / 76.0a1 / 20200324214641 / files
nightly mac
dbabf2e388fa / 76.0a1 / 20200324214641 / files
nightly win32
dbabf2e388fa / 76.0a1 / 20200324214641 / files
nightly win64
dbabf2e388fa / 76.0a1 / 20200324214641 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1624046 - Always write results with --write-results, r=remote-protocol-reviewers,maja_zf Differential Revision: https://phabricator.services.mozilla.com/D67861
remote/mach_commands.py
--- a/remote/mach_commands.py
+++ b/remote/mach_commands.py
@@ -354,17 +354,17 @@ class PuppeteerRunner(MozbuildObject):
         output_handler.after_end(params.get("subset", False))
 
         # Non-zero return codes are non-fatal for now since we have some
         # issues with unresolved promises that shouldn't otherwise block
         # running the tests
         if proc.returncode != 0:
             logger.warning("npm exited with code %s" % proc.returncode)
 
-        if params["write_results"] and output_handler.has_unexpected:
+        if params["write_results"]:
             with open(params["write_results"], "w") as f:
                 json.dump(output_handler.new_expected(), f, indent=2,
                           separators=(",", ": "))
 
         if output_handler.has_unexpected:
             exit(1, "Got unexpected results")