Bug 1412868: Remove Gecko_GetLookAndFeelSystemColor from the static analysis whitelist. r=manishearth
authorBrad Werth <bwerth@mozilla.com>
Mon, 30 Oct 2017 08:47:01 -0700
changeset 389069 da6b544b9891b2998db542fc881e5a9e133dd554
parent 389068 f895a4c8197c2886a26ca02ef1b0f28e2897d880
child 389070 27a4ccb808ea959aba8837a13ef89bcfffd19598
push id32777
push userarchaeopteryx@coole-files.de
push dateMon, 30 Oct 2017 22:44:45 +0000
treeherdermozilla-central@dd0f265a1300 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmanishearth
bugs1412868
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1412868: Remove Gecko_GetLookAndFeelSystemColor from the static analysis whitelist. r=manishearth MozReview-Commit-ID: 7gf3CZM3ypv
js/src/devtools/rootAnalysis/analyzeHeapWrites.js
--- a/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
+++ b/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
@@ -487,17 +487,16 @@ function ignoreContents(entry)
         "Gecko_NewCSSValueSharedList",
         "Gecko_CSSValue_InitSharedList",
 
         // Unable to trace through dataflow, but straightforward if inspected.
         "Gecko_NewNoneTransform",
 
         // Need main thread assertions or other fixes.
         /EffectCompositor::GetServoAnimationRule/,
-        /Gecko_GetLookAndFeelSystemColor/,
     ];
     if (entry.matches(whitelist))
         return true;
 
     if (entry.isSafeArgument(0)) {
         var heapWhitelist = [
             // Operations on heap structures pointed to by arrays and strings are
             // threadsafe as long as the array/string itself is threadsafe.