author | Ehsan Akhgari <ehsan@mozilla.com> |
Fri, 02 Jan 2015 21:10:46 -0500 | |
changeset 221936 | da6a98c3a8d16ea1a13d930e989e09322e5c92d5 |
parent 221935 | 5dba1e33ab69724d2eb973c578f9b520dc78f759 |
child 221937 | 1d64b972dce25f19b3ce1d49f9d3c8313968c5d4 |
push id | 28050 |
push user | philringnalda@gmail.com |
push date | Sun, 04 Jan 2015 04:02:52 +0000 |
treeherder | mozilla-central@55f3224d7513 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | roc |
bugs | 1117263 |
milestone | 37.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/gfx/layers/ImageContainer.h +++ b/gfx/layers/ImageContainer.h @@ -805,26 +805,26 @@ public: * The surface must not be modified after this call!!! */ void SetData(const Data& aData) { mSize = aData.mSize; mSourceSurface = aData.mSourceSurface; } - virtual TemporaryRef<gfx::SourceSurface> GetAsSourceSurface() + virtual TemporaryRef<gfx::SourceSurface> GetAsSourceSurface() MOZ_OVERRIDE { return mSourceSurface.get(); } - virtual ISharedImage* AsSharedImage() { return this; } - virtual uint8_t* GetBuffer() { return nullptr; } + virtual ISharedImage* AsSharedImage() MOZ_OVERRIDE { return this; } + virtual uint8_t* GetBuffer() MOZ_OVERRIDE { return nullptr; } virtual TextureClient* GetTextureClient(CompositableClient* aClient) MOZ_OVERRIDE; - gfx::IntSize GetSize() { return mSize; } + virtual gfx::IntSize GetSize() MOZ_OVERRIDE { return mSize; } CairoImage(); ~CairoImage(); gfx::IntSize mSize; nsCountedRef<nsMainThreadSourceSurfaceRef> mSourceSurface; nsDataHashtable<nsUint32HashKey, RefPtr<TextureClient> > mTextureClients;
--- a/gfx/layers/ImageLayers.h +++ b/gfx/layers/ImageLayers.h @@ -86,18 +86,18 @@ public: mDisallowBigImage = aDisallowBigImage; Mutated(); } } protected: ImageLayer(LayerManager* aManager, void* aImplData); ~ImageLayer(); - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); - virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; + virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent) MOZ_OVERRIDE; nsRefPtr<ImageContainer> mContainer; GraphicsFilter mFilter; gfx::IntSize mScaleToSize; ScaleMode mScaleMode; bool mDisallowBigImage; gfx::Matrix4x4 mEffectiveTransformForBuffer; };
--- a/gfx/layers/LayerScope.cpp +++ b/gfx/layers/LayerScope.cpp @@ -573,28 +573,28 @@ public: NS_DECL_THREADSAFE_ISUPPORTS DebugListener() { } /* nsIServerSocketListener */ NS_IMETHODIMP OnSocketAccepted(nsIServerSocket *aServ, - nsISocketTransport *aTransport) + nsISocketTransport *aTransport) MOZ_OVERRIDE { if (!WebSocketHelper::GetSocketManager()) return NS_OK; printf_stderr("*** LayerScope: Accepted connection\n"); WebSocketHelper::GetSocketManager()->AddConnection(aTransport); return NS_OK; } NS_IMETHODIMP OnStopListening(nsIServerSocket *aServ, - nsresult aStatus) + nsresult aStatus) MOZ_OVERRIDE { return NS_OK; } }; NS_IMPL_ISUPPORTS(DebugListener, nsIServerSocketListener); @@ -620,17 +620,17 @@ public: DebugGLData *d; while ((d = mList.popFirst()) != nullptr) delete d; } /* nsIRunnable impl; send the data */ - NS_IMETHODIMP Run() { + NS_IMETHODIMP Run() MOZ_OVERRIDE { DebugGLData *d; nsresult rv = NS_OK; while ((d = mList.popFirst()) != nullptr) { UniquePtr<DebugGLData> cleaner(d); if (!d->Write()) { rv = NS_ERROR_FAILURE; break;
--- a/gfx/layers/Layers.h +++ b/gfx/layers/Layers.h @@ -98,19 +98,19 @@ class SurfaceDescriptor; class Compositor; struct TextureFactoryIdentifier; struct EffectMask; namespace layerscope { class LayersPacket; } -#define MOZ_LAYER_DECL_NAME(n, e) \ - virtual const char* Name() const { return n; } \ - virtual LayerType GetType() const { return e; } +#define MOZ_LAYER_DECL_NAME(n, e) \ + virtual const char* Name() const MOZ_OVERRIDE { return n; } \ + virtual LayerType GetType() const MOZ_OVERRIDE { return e; } /** * Base class for userdata objects attached to layers and layer managers. */ class LayerUserData { public: virtual ~LayerUserData() {} }; @@ -1718,21 +1718,21 @@ public: */ void SetAllowResidualTranslation(bool aAllow) { mAllowResidualTranslation = aAllow; } /** * Can be used anytime */ const nsIntRegion& GetValidRegion() const { return mValidRegion; } - virtual PaintedLayer* AsPaintedLayer() { return this; } + virtual PaintedLayer* AsPaintedLayer() MOZ_OVERRIDE { return this; } MOZ_LAYER_DECL_NAME("PaintedLayer", TYPE_PAINTED) - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { gfx::Matrix4x4 idealTransform = GetLocalTransform() * aTransformToSurface; gfx::Matrix residual; mEffectiveTransform = SnapTransformTranslation(idealTransform, mAllowResidualTranslation ? &residual : nullptr); // The residual can only be a translation because SnapTransformTranslation // only changes the transform if it's a translation NS_ASSERTION(residual.IsTranslation(), @@ -1768,19 +1768,19 @@ protected: , mValidRegion() , mCreationHint(aCreationHint) , mUsedForReadback(false) , mAllowResidualTranslation(false) { mContentFlags = 0; // Clear NO_TEXT, NO_TEXT_OVER_TRANSPARENT } - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; - virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent); + virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent) MOZ_OVERRIDE; /** * ComputeEffectiveTransforms snaps the ideal transform to get mEffectiveTransform. * mResidualTranslation is the translation that should be applied *before* * mEffectiveTransform to get the ideal transform. */ gfxPoint mResidualTranslation; nsIntRegion mValidRegion; @@ -1850,41 +1850,41 @@ public: } MOZ_LAYERS_LOG_IF_SHADOWABLE(this, ("Layer::Mutated(%p) InheritedScale", this)); mInheritedXScale = aXScale; mInheritedYScale = aYScale; Mutated(); } - virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs); + virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs) MOZ_OVERRIDE; void SortChildrenBy3DZOrder(nsTArray<Layer*>& aArray); // These getters can be used anytime. - virtual ContainerLayer* AsContainerLayer() { return this; } - virtual const ContainerLayer* AsContainerLayer() const { return this; } + virtual ContainerLayer* AsContainerLayer() MOZ_OVERRIDE { return this; } + virtual const ContainerLayer* AsContainerLayer() const MOZ_OVERRIDE { return this; } - virtual Layer* GetFirstChild() const { return mFirstChild; } - virtual Layer* GetLastChild() const { return mLastChild; } + virtual Layer* GetFirstChild() const MOZ_OVERRIDE { return mFirstChild; } + virtual Layer* GetLastChild() const MOZ_OVERRIDE { return mLastChild; } float GetPreXScale() const { return mPreXScale; } float GetPreYScale() const { return mPreYScale; } float GetInheritedXScale() const { return mInheritedXScale; } float GetInheritedYScale() const { return mInheritedYScale; } MOZ_LAYER_DECL_NAME("ContainerLayer", TYPE_CONTAINER) /** * ContainerLayer backends need to override ComputeEffectiveTransforms * since the decision about whether to use a temporary surface for the * container is backend-specific. ComputeEffectiveTransforms must also set * mUseIntermediateSurface. */ - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) = 0; + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE = 0; /** * Call this only after ComputeEffectiveTransforms has been invoked * on this layer. * Returns true if this will use an intermediate surface. This is largely * backend-dependent, but it affects the operation of GetEffectiveOpacity(). */ bool UseIntermediateSurface() { return mUseIntermediateSurface; } @@ -1951,19 +1951,19 @@ protected: */ void DefaultComputeSupportsComponentAlphaChildren(bool* aNeedsSurfaceCopy = nullptr); /** * Loops over the children calling ComputeEffectiveTransforms on them. */ void ComputeEffectiveTransformsForChildren(const gfx::Matrix4x4& aTransformToSurface); - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; - virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent); + virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent) MOZ_OVERRIDE; Layer* mFirstChild; Layer* mLastChild; float mPreXScale; float mPreYScale; // The resolution scale inherited from the parent layer. This will already // be part of mTransform. float mInheritedXScale; @@ -1979,17 +1979,17 @@ protected: /** * A Layer which just renders a solid color in its visible region. It actually * can fill any area that contains the visible region, so if you need to * restrict the area filled, set a clip region on this layer. */ class ColorLayer : public Layer { public: - virtual ColorLayer* AsColorLayer() { return this; } + virtual ColorLayer* AsColorLayer() MOZ_OVERRIDE { return this; } /** * CONSTRUCTION PHASE ONLY * Set the color of the layer. */ virtual void SetColor(const gfxRGBA& aColor) { if (mColor != aColor) { @@ -2012,32 +2012,32 @@ public: return mBounds; } // This getter can be used anytime. virtual const gfxRGBA& GetColor() { return mColor; } MOZ_LAYER_DECL_NAME("ColorLayer", TYPE_COLOR) - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { gfx::Matrix4x4 idealTransform = GetLocalTransform() * aTransformToSurface; mEffectiveTransform = SnapTransformTranslation(idealTransform, nullptr); ComputeEffectiveTransformForMaskLayer(aTransformToSurface); } protected: ColorLayer(LayerManager* aManager, void* aImplData) : Layer(aManager, aImplData), mColor(0.0, 0.0, 0.0, 0.0) {} - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; - virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent); + virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent) MOZ_OVERRIDE; nsIntRect mBounds; gfxRGBA mColor; }; /** * A Layer for HTML Canvas elements. It's backed by either a * gfxASurface or a GLContext (for WebGL layers), and has some control @@ -2158,17 +2158,17 @@ public: mFilter = aFilter; Mutated(); } } GraphicsFilter GetFilter() const { return mFilter; } MOZ_LAYER_DECL_NAME("CanvasLayer", TYPE_CANVAS) - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { // Snap our local transform first, and snap the inherited transform as well. // This makes our snapping equivalent to what would happen if our content // was drawn into a PaintedLayer (gfxContext would snap using the local // transform, then we'd snap again when compositing the PaintedLayer). mEffectiveTransform = SnapTransform(GetLocalTransform(), gfxRect(0, 0, mBounds.width, mBounds.height), nullptr)* @@ -2182,19 +2182,19 @@ protected: , mPreTransCallback(nullptr) , mPreTransCallbackData(nullptr) , mPostTransCallback(nullptr) , mPostTransCallbackData(nullptr) , mFilter(GraphicsFilter::FILTER_GOOD) , mDirty(false) {} - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; - virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent); + virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent) MOZ_OVERRIDE; void FireDidTransactionCallback() { if (mPostTransCallback) { mPostTransCallback(mPostTransCallbackData); } } @@ -2234,20 +2234,20 @@ private: */ class RefLayer : public ContainerLayer { friend class LayerManager; private: virtual bool InsertAfter(Layer* aChild, Layer* aAfter) MOZ_OVERRIDE { MOZ_CRASH(); return false; } - virtual bool RemoveChild(Layer* aChild) + virtual bool RemoveChild(Layer* aChild) MOZ_OVERRIDE { MOZ_CRASH(); return false; } - virtual bool RepositionChild(Layer* aChild, Layer* aAfter) + virtual bool RepositionChild(Layer* aChild, Layer* aAfter) MOZ_OVERRIDE { MOZ_CRASH(); return false; } using Layer::SetFrameMetrics; public: /** * CONSTRUCTION PHASE ONLY * Set the ID of the layer's referent. @@ -2290,35 +2290,35 @@ public: */ void DetachReferentLayer(Layer* aLayer) { mFirstChild = mLastChild = nullptr; aLayer->SetParent(nullptr); } // These getters can be used anytime. - virtual RefLayer* AsRefLayer() { return this; } + virtual RefLayer* AsRefLayer() MOZ_OVERRIDE { return this; } virtual int64_t GetReferentId() { return mId; } /** * DRAWING PHASE ONLY */ - virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs); + virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs) MOZ_OVERRIDE; MOZ_LAYER_DECL_NAME("RefLayer", TYPE_REF) protected: RefLayer(LayerManager* aManager, void* aImplData) : ContainerLayer(aManager, aImplData) , mId(0) {} - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; - virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent); + virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent) MOZ_OVERRIDE; Layer* mTempReferent; // 0 is a special value that means "no ID". uint64_t mId; }; void SetAntialiasingFlags(Layer* aLayer, gfx::DrawTarget* aTarget);
--- a/gfx/layers/MacIOSurfaceImage.h +++ b/gfx/layers/MacIOSurfaceImage.h @@ -16,23 +16,23 @@ namespace mozilla { namespace layers { class MacIOSurfaceImage : public Image, public ISharedImage { public: void SetSurface(MacIOSurface* aSurface) { mSurface = aSurface; } MacIOSurface* GetSurface() { return mSurface; } - gfx::IntSize GetSize() { + gfx::IntSize GetSize() MOZ_OVERRIDE { return gfx::IntSize(mSurface->GetDevicePixelWidth(), mSurface->GetDevicePixelHeight()); } virtual ISharedImage* AsSharedImage() MOZ_OVERRIDE { return this; } - virtual TemporaryRef<gfx::SourceSurface> GetAsSourceSurface(); + virtual TemporaryRef<gfx::SourceSurface> GetAsSourceSurface() MOZ_OVERRIDE; virtual TextureClient* GetTextureClient(CompositableClient* aClient) MOZ_OVERRIDE; virtual uint8_t* GetBuffer() MOZ_OVERRIDE { return nullptr; } MacIOSurfaceImage() : Image(nullptr, ImageFormat::MAC_IOSURFACE) {} private: RefPtr<MacIOSurface> mSurface;
--- a/gfx/layers/ReadbackLayer.h +++ b/gfx/layers/ReadbackLayer.h @@ -82,17 +82,17 @@ public: * * This API exists to work around the limitations of transparent windowless * plugin rendering APIs. It should not be used for anything else. */ class ReadbackLayer : public Layer { public: MOZ_LAYER_DECL_NAME("ReadbackLayer", TYPE_READBACK) - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { // Snap our local transform first, and snap the inherited transform as well. // This makes our snapping equivalent to what would happen if our content // was drawn into a PaintedLayer (gfxContext would snap using the local // transform, then we'd snap again when compositing the PaintedLayer). mEffectiveTransform = SnapTransform(GetLocalTransform(), gfxRect(0, 0, mSize.width, mSize.height), nullptr)* @@ -169,19 +169,19 @@ protected: Layer(aManager, aImplData), mSequenceCounter(0), mSize(0,0), mBackgroundLayer(nullptr), mBackgroundLayerOffset(0, 0), mBackgroundColor(gfxRGBA(0,0,0,0)) {} - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; - virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent); + virtual void DumpPacket(layerscope::LayersPacket* aPacket, const void* aParent) MOZ_OVERRIDE; uint64_t mSequenceCounter; nsAutoPtr<ReadbackSink> mSink; nsIntSize mSize; // This can refer to any (earlier) sibling PaintedLayer. That PaintedLayer // must have mUsedForReadback set on it. If the PaintedLayer is removed // for the container, this will be set to null by NotifyPaintedLayerRemoved.
--- a/gfx/layers/basic/BasicCanvasLayer.h +++ b/gfx/layers/basic/BasicCanvasLayer.h @@ -22,17 +22,17 @@ class BasicCanvasLayer : public Copyable public BasicImplData { public: explicit BasicCanvasLayer(BasicLayerManager* aLayerManager) : CopyableCanvasLayer(aLayerManager, static_cast<BasicImplData*>(MOZ_THIS_IN_INITIALIZER_LIST())) { } - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(BasicManager()->InConstruction(), "Can only set properties in construction phase"); CanvasLayer::SetVisibleRegion(aRegion); } virtual void Paint(gfx::DrawTarget* aDT, const gfx::Point& aDeviceOffset,
--- a/gfx/layers/basic/BasicColorLayer.cpp +++ b/gfx/layers/basic/BasicColorLayer.cpp @@ -35,17 +35,17 @@ public: protected: virtual ~BasicColorLayer() { MOZ_COUNT_DTOR(BasicColorLayer); } public: - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(BasicManager()->InConstruction(), "Can only set properties in construction phase"); ColorLayer::SetVisibleRegion(aRegion); } virtual void Paint(DrawTarget* aDT, const gfx::Point& aDeviceOffset,
--- a/gfx/layers/basic/BasicCompositor.h +++ b/gfx/layers/basic/BasicCompositor.h @@ -97,29 +97,29 @@ public: gfx::Rect *aRenderBoundsOut = nullptr) MOZ_OVERRIDE; virtual void EndFrame() MOZ_OVERRIDE; virtual void EndFrameForExternalComposition(const gfx::Matrix& aTransform) MOZ_OVERRIDE { NS_RUNTIMEABORT("We shouldn't ever hit this"); } virtual void AbortFrame() MOZ_OVERRIDE; - virtual bool SupportsPartialTextureUpdate() { return true; } + virtual bool SupportsPartialTextureUpdate() MOZ_OVERRIDE { return true; } virtual bool CanUseCanvasLayerForSize(const gfx::IntSize &aSize) MOZ_OVERRIDE { return true; } virtual int32_t GetMaxTextureSize() const MOZ_OVERRIDE { return INT32_MAX; } virtual void SetDestinationSurfaceSize(const gfx::IntSize& aSize) MOZ_OVERRIDE { } virtual void SetScreenRenderOffset(const ScreenPoint& aOffset) MOZ_OVERRIDE { } - virtual void MakeCurrent(MakeCurrentFlags aFlags = 0) { } + virtual void MakeCurrent(MakeCurrentFlags aFlags = 0) MOZ_OVERRIDE { } virtual void PrepareViewport(const gfx::IntSize& aSize) MOZ_OVERRIDE { } - virtual const char* Name() const { return "Basic"; } + virtual const char* Name() const MOZ_OVERRIDE { return "Basic"; } virtual LayersBackend GetBackendType() const MOZ_OVERRIDE { return LayersBackend::LAYERS_BASIC; } virtual nsIWidget* GetWidget() const MOZ_OVERRIDE { return mWidget; } gfx::DrawTarget *GetDrawTarget() { return mDrawTarget; }
--- a/gfx/layers/basic/BasicContainerLayer.h +++ b/gfx/layers/basic/BasicContainerLayer.h @@ -25,50 +25,50 @@ public: { MOZ_COUNT_CTOR(BasicContainerLayer); mSupportsComponentAlphaChildren = true; } protected: virtual ~BasicContainerLayer(); public: - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(BasicManager()->InConstruction(), "Can only set properties in construction phase"); ContainerLayer::SetVisibleRegion(aRegion); } - virtual bool InsertAfter(Layer* aChild, Layer* aAfter) + virtual bool InsertAfter(Layer* aChild, Layer* aAfter) MOZ_OVERRIDE { if (!BasicManager()->InConstruction()) { NS_ERROR("Can only set properties in construction phase"); return false; } return ContainerLayer::InsertAfter(aChild, aAfter); } - virtual bool RemoveChild(Layer* aChild) + virtual bool RemoveChild(Layer* aChild) MOZ_OVERRIDE { if (!BasicManager()->InConstruction()) { NS_ERROR("Can only set properties in construction phase"); return false; } return ContainerLayer::RemoveChild(aChild); } - virtual bool RepositionChild(Layer* aChild, Layer* aAfter) + virtual bool RepositionChild(Layer* aChild, Layer* aAfter) MOZ_OVERRIDE { if (!BasicManager()->InConstruction()) { NS_ERROR("Can only set properties in construction phase"); return false; } return ContainerLayer::RepositionChild(aChild, aAfter); } - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface); + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE; /** * Returns true when: * a) no (non-hidden) childrens' visible areas overlap in * (aInRect intersected with this layer's visible region). * b) the (non-hidden) childrens' visible areas cover * (aInRect intersected with this layer's visible region). * c) this layer and all (non-hidden) children have transforms that are translations
--- a/gfx/layers/basic/BasicImageLayer.cpp +++ b/gfx/layers/basic/BasicImageLayer.cpp @@ -34,17 +34,17 @@ public: } protected: virtual ~BasicImageLayer() { MOZ_COUNT_DTOR(BasicImageLayer); } public: - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(BasicManager()->InConstruction(), "Can only set properties in construction phase"); ImageLayer::SetVisibleRegion(aRegion); } virtual void Paint(DrawTarget* aDT, const gfx::Point& aDeviceOffset,
--- a/gfx/layers/basic/BasicImages.cpp +++ b/gfx/layers/basic/BasicImages.cpp @@ -43,20 +43,20 @@ public: { if (mDecodedBuffer) { // Right now this only happens if the Image was never drawn, otherwise // this will have been tossed away at surface destruction. mRecycleBin->RecycleBuffer(mDecodedBuffer.forget(), mSize.height * mStride); } } - virtual void SetData(const Data& aData); - virtual void SetDelayedConversion(bool aDelayed) { mDelayedConversion = aDelayed; } + virtual void SetData(const Data& aData) MOZ_OVERRIDE; + virtual void SetDelayedConversion(bool aDelayed) MOZ_OVERRIDE { mDelayedConversion = aDelayed; } - TemporaryRef<gfx::SourceSurface> GetAsSourceSurface(); + TemporaryRef<gfx::SourceSurface> GetAsSourceSurface() MOZ_OVERRIDE; virtual size_t SizeOfIncludingThis(MallocSizeOf aMallocSizeOf) const MOZ_OVERRIDE { return aMallocSizeOf(this) + SizeOfExcludingThis(aMallocSizeOf); } virtual size_t SizeOfExcludingThis(MallocSizeOf aMallocSizeOf) const MOZ_OVERRIDE {
--- a/gfx/layers/basic/BasicLayers.h +++ b/gfx/layers/basic/BasicLayers.h @@ -91,67 +91,67 @@ public: */ void SetDefaultTarget(gfxContext* aContext); virtual void SetDefaultTargetConfiguration(BufferMode aDoubleBuffering, ScreenRotation aRotation); gfxContext* GetDefaultTarget() { return mDefaultTarget; } nsIWidget* GetRetainerWidget() { return mWidget; } void ClearRetainerWidget() { mWidget = nullptr; } - virtual bool IsWidgetLayerManager() { return mWidget != nullptr; } - virtual bool IsInactiveLayerManager() { return mType == BLM_INACTIVE; } + virtual bool IsWidgetLayerManager() MOZ_OVERRIDE { return mWidget != nullptr; } + virtual bool IsInactiveLayerManager() MOZ_OVERRIDE { return mType == BLM_INACTIVE; } - virtual void BeginTransaction(); - virtual void BeginTransactionWithTarget(gfxContext* aTarget); - virtual bool EndEmptyTransaction(EndTransactionFlags aFlags = END_DEFAULT); + virtual void BeginTransaction() MOZ_OVERRIDE; + virtual void BeginTransactionWithTarget(gfxContext* aTarget) MOZ_OVERRIDE; + virtual bool EndEmptyTransaction(EndTransactionFlags aFlags = END_DEFAULT) MOZ_OVERRIDE; virtual void EndTransaction(DrawPaintedLayerCallback aCallback, void* aCallbackData, - EndTransactionFlags aFlags = END_DEFAULT); - virtual bool ShouldAvoidComponentAlphaLayers() { return IsWidgetLayerManager(); } + EndTransactionFlags aFlags = END_DEFAULT) MOZ_OVERRIDE; + virtual bool ShouldAvoidComponentAlphaLayers() MOZ_OVERRIDE { return IsWidgetLayerManager(); } void AbortTransaction(); - virtual void SetRoot(Layer* aLayer); + virtual void SetRoot(Layer* aLayer) MOZ_OVERRIDE; - virtual already_AddRefed<PaintedLayer> CreatePaintedLayer(); - virtual already_AddRefed<ContainerLayer> CreateContainerLayer(); - virtual already_AddRefed<ImageLayer> CreateImageLayer(); - virtual already_AddRefed<CanvasLayer> CreateCanvasLayer(); - virtual already_AddRefed<ColorLayer> CreateColorLayer(); - virtual already_AddRefed<ReadbackLayer> CreateReadbackLayer(); + virtual already_AddRefed<PaintedLayer> CreatePaintedLayer() MOZ_OVERRIDE; + virtual already_AddRefed<ContainerLayer> CreateContainerLayer() MOZ_OVERRIDE; + virtual already_AddRefed<ImageLayer> CreateImageLayer() MOZ_OVERRIDE; + virtual already_AddRefed<CanvasLayer> CreateCanvasLayer() MOZ_OVERRIDE; + virtual already_AddRefed<ColorLayer> CreateColorLayer() MOZ_OVERRIDE; + virtual already_AddRefed<ReadbackLayer> CreateReadbackLayer() MOZ_OVERRIDE; virtual ImageFactory *GetImageFactory(); - virtual LayersBackend GetBackendType() { return LayersBackend::LAYERS_BASIC; } - virtual void GetBackendName(nsAString& name) { name.AssignLiteral("Basic"); } + virtual LayersBackend GetBackendType() MOZ_OVERRIDE { return LayersBackend::LAYERS_BASIC; } + virtual void GetBackendName(nsAString& name) MOZ_OVERRIDE { name.AssignLiteral("Basic"); } bool InConstruction() { return mPhase == PHASE_CONSTRUCTION; } #ifdef DEBUG bool InDrawing() { return mPhase == PHASE_DRAWING; } bool InForward() { return mPhase == PHASE_FORWARD; } #endif bool InTransaction() { return mPhase != PHASE_NONE; } gfxContext* GetTarget() { return mTarget; } void SetTarget(gfxContext* aTarget) { mUsingDefaultTarget = false; mTarget = aTarget; } bool IsRetained() { return mWidget != nullptr; } - virtual const char* Name() const { return "Basic"; } + virtual const char* Name() const MOZ_OVERRIDE { return "Basic"; } // Clear the cached contents of this layer tree. virtual void ClearCachedResources(Layer* aSubtree = nullptr) MOZ_OVERRIDE; void SetTransactionIncomplete() { mTransactionIncomplete = true; } bool IsTransactionIncomplete() { return mTransactionIncomplete; } already_AddRefed<gfxContext> PushGroupForLayer(gfxContext* aContext, Layer* aLayer, const nsIntRegion& aRegion, bool* aNeedsClipToVisibleRegion); - virtual bool IsCompositingCheap() { return false; } - virtual int32_t GetMaxTextureSize() const { return INT32_MAX; } + virtual bool IsCompositingCheap() MOZ_OVERRIDE { return false; } + virtual int32_t GetMaxTextureSize() const MOZ_OVERRIDE { return INT32_MAX; } bool CompositorMightResample() { return mCompositorMightResample; } virtual bool SupportsMixBlendModes(EnumSet<gfx::CompositionOp>& aMixBlendModes) MOZ_OVERRIDE { return true; } protected: enum TransactionPhase { PHASE_NONE, PHASE_CONSTRUCTION, PHASE_DRAWING, PHASE_FORWARD };
--- a/gfx/layers/basic/BasicPaintedLayer.h +++ b/gfx/layers/basic/BasicPaintedLayer.h @@ -40,49 +40,49 @@ public: protected: virtual ~BasicPaintedLayer() { MOZ_COUNT_DTOR(BasicPaintedLayer); } public: - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(BasicManager()->InConstruction(), "Can only set properties in construction phase"); PaintedLayer::SetVisibleRegion(aRegion); } - virtual void InvalidateRegion(const nsIntRegion& aRegion) + virtual void InvalidateRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(BasicManager()->InConstruction(), "Can only set properties in construction phase"); mInvalidRegion.Or(mInvalidRegion, aRegion); mInvalidRegion.SimplifyOutward(20); mValidRegion.Sub(mValidRegion, mInvalidRegion); } virtual void PaintThebes(gfxContext* aContext, Layer* aMaskLayer, LayerManager::DrawPaintedLayerCallback aCallback, - void* aCallbackData); + void* aCallbackData) MOZ_OVERRIDE; virtual void Validate(LayerManager::DrawPaintedLayerCallback aCallback, void* aCallbackData, ReadbackProcessor* aReadback) MOZ_OVERRIDE; - virtual void ClearCachedResources() + virtual void ClearCachedResources() MOZ_OVERRIDE { if (mContentClient) { mContentClient->Clear(); } mValidRegion.SetEmpty(); } - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { if (!BasicManager()->IsRetained()) { // Don't do any snapping of our transform, since we're just going to // draw straight through without intermediate buffers. mEffectiveTransform = GetLocalTransform() * aTransformToSurface; if (gfxPoint(0,0) != mResidualTranslation) { mResidualTranslation = gfxPoint(0,0); mValidRegion.SetEmpty();
--- a/gfx/layers/basic/MacIOSurfaceTextureHostBasic.h +++ b/gfx/layers/basic/MacIOSurfaceTextureHostBasic.h @@ -72,17 +72,17 @@ public: virtual TemporaryRef<gfx::DataSourceSurface> GetAsSurface() MOZ_OVERRIDE { return nullptr; // XXX - implement this (for MOZ_DUMP_PAINTING) } virtual gfx::IntSize GetSize() const MOZ_OVERRIDE; #ifdef MOZ_LAYERS_HAVE_LOG - virtual const char* Name() { return "MacIOSurfaceTextureHostBasic"; } + virtual const char* Name() MOZ_OVERRIDE { return "MacIOSurfaceTextureHostBasic"; } #endif protected: RefPtr<BasicCompositor> mCompositor; RefPtr<MacIOSurfaceTextureSourceBasic> mTextureSource; RefPtr<MacIOSurface> mSurface; };
--- a/gfx/layers/client/CanvasClient.h +++ b/gfx/layers/client/CanvasClient.h @@ -71,17 +71,17 @@ class CanvasClient2D : public CanvasClie { public: CanvasClient2D(CompositableForwarder* aLayerForwarder, TextureFlags aFlags) : CanvasClient(aLayerForwarder, aFlags) { } - TextureInfo GetTextureInfo() const + TextureInfo GetTextureInfo() const MOZ_OVERRIDE { return TextureInfo(CompositableType::IMAGE, mTextureFlags); } virtual void Clear() MOZ_OVERRIDE { mBuffer = nullptr; }
--- a/gfx/layers/client/ClientContainerLayer.h +++ b/gfx/layers/client/ClientContainerLayer.h @@ -41,17 +41,17 @@ protected: while (mFirstChild) { ContainerLayer::RemoveChild(mFirstChild); } MOZ_COUNT_DTOR(ClientContainerLayer); } public: - virtual void RenderLayer() + virtual void RenderLayer() MOZ_OVERRIDE { if (GetMaskLayer()) { ToClientLayer(GetMaskLayer())->RenderLayer(); } DefaultComputeSupportsComponentAlphaChildren(); nsAutoTArray<Layer*, 12> children; @@ -70,17 +70,17 @@ public: if (!ClientManager()->GetRepeatTransaction() && !child->GetInvalidRegion().IsEmpty()) { child->Mutated(); } } } - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(ClientManager()->InConstruction(), "Can only set properties in construction phase"); ContainerLayer::SetVisibleRegion(aRegion); } virtual bool InsertAfter(Layer* aChild, Layer* aAfter) MOZ_OVERRIDE { if(!ClientManager()->InConstruction()) { @@ -123,20 +123,20 @@ public: return false; } ClientManager()->AsShadowForwarder()->RepositionChild(ClientManager()->Hold(this), ClientManager()->Hold(aChild), aAfter ? ClientManager()->Hold(aAfter) : nullptr); return true; } - virtual Layer* AsLayer() { return this; } - virtual ShadowableLayer* AsShadowableLayer() { return this; } + virtual Layer* AsLayer() MOZ_OVERRIDE { return this; } + virtual ShadowableLayer* AsShadowableLayer() MOZ_OVERRIDE { return this; } - virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) + virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { DefaultComputeEffectiveTransforms(aTransformToSurface); } void ForceIntermediateSurface() { mUseIntermediateSurface = true; } void SetSupportsComponentAlphaChildren(bool aSupports) { mSupportsComponentAlphaChildren = aSupports; }
--- a/gfx/layers/client/ClientImageLayer.cpp +++ b/gfx/layers/client/ClientImageLayer.cpp @@ -42,39 +42,39 @@ protected: } virtual void SetContainer(ImageContainer* aContainer) MOZ_OVERRIDE { ImageLayer::SetContainer(aContainer); mImageClientTypeContainer = CompositableType::UNKNOWN; } - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(ClientManager()->InConstruction(), "Can only set properties in construction phase"); ImageLayer::SetVisibleRegion(aRegion); } - virtual void RenderLayer(); + virtual void RenderLayer() MOZ_OVERRIDE; virtual void ClearCachedResources() MOZ_OVERRIDE { DestroyBackBuffer(); } - virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs) + virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs) MOZ_OVERRIDE { aAttrs = ImageLayerAttributes(mFilter, mScaleToSize, mScaleMode); } - virtual Layer* AsLayer() { return this; } - virtual ShadowableLayer* AsShadowableLayer() { return this; } + virtual Layer* AsLayer() MOZ_OVERRIDE { return this; } + virtual ShadowableLayer* AsShadowableLayer() MOZ_OVERRIDE { return this; } - virtual void Disconnect() + virtual void Disconnect() MOZ_OVERRIDE { DestroyBackBuffer(); ClientLayer::Disconnect(); } void DestroyBackBuffer() { if (mImageClient) {
--- a/gfx/layers/client/ClientLayerManager.h +++ b/gfx/layers/client/ClientLayerManager.h @@ -40,68 +40,68 @@ class TextureClientPool; class ClientLayerManager MOZ_FINAL : public LayerManager { typedef nsTArray<nsRefPtr<Layer> > LayerRefArray; public: explicit ClientLayerManager(nsIWidget* aWidget); - virtual void Destroy() + virtual void Destroy() MOZ_OVERRIDE { LayerManager::Destroy(); ClearCachedResources(); } protected: virtual ~ClientLayerManager(); public: - virtual ShadowLayerForwarder* AsShadowForwarder() + virtual ShadowLayerForwarder* AsShadowForwarder() MOZ_OVERRIDE { return mForwarder; } - virtual ClientLayerManager* AsClientLayerManager() + virtual ClientLayerManager* AsClientLayerManager() MOZ_OVERRIDE { return this; } - virtual int32_t GetMaxTextureSize() const; + virtual int32_t GetMaxTextureSize() const MOZ_OVERRIDE; virtual void SetDefaultTargetConfiguration(BufferMode aDoubleBuffering, ScreenRotation aRotation); - virtual void BeginTransactionWithTarget(gfxContext* aTarget); - virtual void BeginTransaction(); - virtual bool EndEmptyTransaction(EndTransactionFlags aFlags = END_DEFAULT); + virtual void BeginTransactionWithTarget(gfxContext* aTarget) MOZ_OVERRIDE; + virtual void BeginTransaction() MOZ_OVERRIDE; + virtual bool EndEmptyTransaction(EndTransactionFlags aFlags = END_DEFAULT) MOZ_OVERRIDE; virtual void EndTransaction(DrawPaintedLayerCallback aCallback, void* aCallbackData, - EndTransactionFlags aFlags = END_DEFAULT); + EndTransactionFlags aFlags = END_DEFAULT) MOZ_OVERRIDE; - virtual LayersBackend GetBackendType() { return LayersBackend::LAYERS_CLIENT; } + virtual LayersBackend GetBackendType() MOZ_OVERRIDE { return LayersBackend::LAYERS_CLIENT; } virtual LayersBackend GetCompositorBackendType() MOZ_OVERRIDE { return AsShadowForwarder()->GetCompositorBackendType(); } - virtual void GetBackendName(nsAString& name); - virtual const char* Name() const { return "Client"; } + virtual void GetBackendName(nsAString& name) MOZ_OVERRIDE; + virtual const char* Name() const MOZ_OVERRIDE { return "Client"; } - virtual void SetRoot(Layer* aLayer); + virtual void SetRoot(Layer* aLayer) MOZ_OVERRIDE; - virtual void Mutated(Layer* aLayer); + virtual void Mutated(Layer* aLayer) MOZ_OVERRIDE; - virtual bool IsOptimizedFor(PaintedLayer* aLayer, PaintedLayerCreationHint aHint); + virtual bool IsOptimizedFor(PaintedLayer* aLayer, PaintedLayerCreationHint aHint) MOZ_OVERRIDE; - virtual already_AddRefed<PaintedLayer> CreatePaintedLayer(); - virtual already_AddRefed<PaintedLayer> CreatePaintedLayerWithHint(PaintedLayerCreationHint aHint); - virtual already_AddRefed<ContainerLayer> CreateContainerLayer(); - virtual already_AddRefed<ImageLayer> CreateImageLayer(); - virtual already_AddRefed<CanvasLayer> CreateCanvasLayer(); - virtual already_AddRefed<ReadbackLayer> CreateReadbackLayer(); - virtual already_AddRefed<ColorLayer> CreateColorLayer(); - virtual already_AddRefed<RefLayer> CreateRefLayer(); + virtual already_AddRefed<PaintedLayer> CreatePaintedLayer() MOZ_OVERRIDE; + virtual already_AddRefed<PaintedLayer> CreatePaintedLayerWithHint(PaintedLayerCreationHint aHint) MOZ_OVERRIDE; + virtual already_AddRefed<ContainerLayer> CreateContainerLayer() MOZ_OVERRIDE; + virtual already_AddRefed<ImageLayer> CreateImageLayer() MOZ_OVERRIDE; + virtual already_AddRefed<CanvasLayer> CreateCanvasLayer() MOZ_OVERRIDE; + virtual already_AddRefed<ReadbackLayer> CreateReadbackLayer() MOZ_OVERRIDE; + virtual already_AddRefed<ColorLayer> CreateColorLayer() MOZ_OVERRIDE; + virtual already_AddRefed<RefLayer> CreateRefLayer() MOZ_OVERRIDE; TextureFactoryIdentifier GetTextureFactoryIdentifier() { return mForwarder->GetTextureFactoryIdentifier(); } virtual void FlushRendering() MOZ_OVERRIDE; void SendInvalidRegion(const nsIntRegion& aRegion); @@ -112,18 +112,18 @@ public: nsTArray<float>& aFrameIntervals) MOZ_OVERRIDE; virtual bool NeedsWidgetInvalidation() MOZ_OVERRIDE { return false; } ShadowableLayer* Hold(Layer* aLayer); bool HasShadowManager() const { return mForwarder->HasShadowManager(); } - virtual bool IsCompositingCheap(); - virtual bool HasShadowManagerInternal() const { return HasShadowManager(); } + virtual bool IsCompositingCheap() MOZ_OVERRIDE; + virtual bool HasShadowManagerInternal() const MOZ_OVERRIDE { return HasShadowManager(); } virtual void SetIsFirstPaint() MOZ_OVERRIDE; TextureClientPool* GetTexturePool(gfx::SurfaceFormat aFormat); /// Utility methods for managing texture clients. void ReturnTextureClientDeferred(TextureClient& aClient); void ReturnTextureClient(TextureClient& aClient); @@ -154,17 +154,17 @@ public: void* GetPaintedLayerCallbackData() const { return mPaintedLayerCallbackData; } CompositorChild* GetRemoteRenderer(); CompositorChild* GetCompositorChild(); // Disable component alpha layers with the software compositor. - virtual bool ShouldAvoidComponentAlphaLayers() { return !IsCompositingCheap(); } + virtual bool ShouldAvoidComponentAlphaLayers() MOZ_OVERRIDE { return !IsCompositingCheap(); } /** * Called for each iteration of a progressive tile update. Updates * aMetrics with the current scroll offset and scale being used to composite * the primary scrollable layer in this manager, to determine what area * intersects with the target composition bounds. * aDrawingCritical will be true if the current drawing operation is using * the critical displayport.
--- a/gfx/layers/client/ClientPaintedLayer.h +++ b/gfx/layers/client/ClientPaintedLayer.h @@ -49,63 +49,63 @@ protected: if (mContentClient) { mContentClient->OnDetach(); mContentClient = nullptr; } MOZ_COUNT_DTOR(ClientPaintedLayer); } public: - virtual void SetVisibleRegion(const nsIntRegion& aRegion) + virtual void SetVisibleRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(ClientManager()->InConstruction(), "Can only set properties in construction phase"); PaintedLayer::SetVisibleRegion(aRegion); } - virtual void InvalidateRegion(const nsIntRegion& aRegion) + virtual void InvalidateRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_ASSERTION(ClientManager()->InConstruction(), "Can only set properties in construction phase"); mInvalidRegion.Or(mInvalidRegion, aRegion); mInvalidRegion.SimplifyOutward(20); mValidRegion.Sub(mValidRegion, mInvalidRegion); } - virtual void RenderLayer() { RenderLayerWithReadback(nullptr); } + virtual void RenderLayer() MOZ_OVERRIDE { RenderLayerWithReadback(nullptr); } virtual void RenderLayerWithReadback(ReadbackProcessor *aReadback) MOZ_OVERRIDE; - virtual void ClearCachedResources() + virtual void ClearCachedResources() MOZ_OVERRIDE { if (mContentClient) { mContentClient->Clear(); } mValidRegion.SetEmpty(); DestroyBackBuffer(); } - virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs) + virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs) MOZ_OVERRIDE { aAttrs = PaintedLayerAttributes(GetValidRegion()); } ClientLayerManager* ClientManager() { return static_cast<ClientLayerManager*>(mManager); } - virtual Layer* AsLayer() { return this; } - virtual ShadowableLayer* AsShadowableLayer() { return this; } + virtual Layer* AsLayer() MOZ_OVERRIDE { return this; } + virtual ShadowableLayer* AsShadowableLayer() MOZ_OVERRIDE { return this; } virtual CompositableClient* GetCompositableClient() MOZ_OVERRIDE { return mContentClient; } - virtual void Disconnect() + virtual void Disconnect() MOZ_OVERRIDE { mContentClient = nullptr; ClientLayer::Disconnect(); } protected: void PaintThebes();
--- a/gfx/layers/client/ClientTiledPaintedLayer.h +++ b/gfx/layers/client/ClientTiledPaintedLayer.h @@ -46,37 +46,37 @@ public: protected: ~ClientTiledPaintedLayer(); virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; public: // Override name to distinguish it from ClientPaintedLayer in layer dumps - virtual const char* Name() const { return "TiledPaintedLayer"; } + virtual const char* Name() const MOZ_OVERRIDE { return "TiledPaintedLayer"; } // PaintedLayer - virtual Layer* AsLayer() { return this; } - virtual void InvalidateRegion(const nsIntRegion& aRegion) { + virtual Layer* AsLayer() MOZ_OVERRIDE { return this; } + virtual void InvalidateRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { mInvalidRegion.Or(mInvalidRegion, aRegion); mInvalidRegion.SimplifyOutward(20); mValidRegion.Sub(mValidRegion, mInvalidRegion); mLowPrecisionValidRegion.Sub(mLowPrecisionValidRegion, mInvalidRegion); } // Shadow methods - virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs); - virtual ShadowableLayer* AsShadowableLayer() { return this; } + virtual void FillSpecificAttributes(SpecificLayerAttributes& aAttrs) MOZ_OVERRIDE; + virtual ShadowableLayer* AsShadowableLayer() MOZ_OVERRIDE { return this; } - virtual void Disconnect() + virtual void Disconnect() MOZ_OVERRIDE { ClientLayer::Disconnect(); } - virtual void RenderLayer(); + virtual void RenderLayer() MOZ_OVERRIDE; virtual void ClearCachedResources() MOZ_OVERRIDE; /** * Helper method to find the nearest ancestor layers which * scroll and have a displayport. The parameters are out-params * which hold the return values; the values passed in may be null. */
--- a/gfx/layers/client/ContentClient.h +++ b/gfx/layers/client/ContentClient.h @@ -132,17 +132,17 @@ class ContentClientBasic MOZ_FINAL : pub , protected RotatedContentBuffer { public: ContentClientBasic(); typedef RotatedContentBuffer::PaintState PaintState; typedef RotatedContentBuffer::ContentType ContentType; - virtual void Clear() { RotatedContentBuffer::Clear(); } + virtual void Clear() MOZ_OVERRIDE { RotatedContentBuffer::Clear(); } virtual PaintState BeginPaintBuffer(PaintedLayer* aLayer, uint32_t aFlags) MOZ_OVERRIDE { return RotatedContentBuffer::BeginPaint(aLayer, aFlags); } virtual gfx::DrawTarget* BorrowDrawTargetForPainting(PaintState& aPaintState, RotatedContentBuffer::DrawIterator* aIter = nullptr) MOZ_OVERRIDE { @@ -201,17 +201,17 @@ public: , mIsNewBuffer(false) , mFrontAndBackBufferDiffer(false) , mSurfaceFormat(gfx::SurfaceFormat::B8G8R8A8) {} typedef RotatedContentBuffer::PaintState PaintState; typedef RotatedContentBuffer::ContentType ContentType; - virtual void Clear() + virtual void Clear() MOZ_OVERRIDE { RotatedContentBuffer::Clear(); mTextureClient = nullptr; mTextureClientOnWhite = nullptr; } virtual void Dump(std::stringstream& aStream, const char* aPrefix="", @@ -240,17 +240,17 @@ public: * None of the underlying buffer attributes (rect, rotation) * are affected by mapping/unmapping. */ virtual void BeginPaint() MOZ_OVERRIDE; virtual void EndPaint(nsTArray<ReadbackProcessor::Update>* aReadbackUpdates = nullptr) MOZ_OVERRIDE; virtual void Updated(const nsIntRegion& aRegionToDraw, const nsIntRegion& aVisibleRegion, - bool aDidSelfCopy); + bool aDidSelfCopy) MOZ_OVERRIDE; virtual void SwapBuffers(const nsIntRegion& aFrontUpdatedRegion) MOZ_OVERRIDE; // Expose these protected methods from the superclass. virtual const nsIntRect& BufferRect() const { return RotatedContentBuffer::BufferRect(); } @@ -411,22 +411,22 @@ public: , mHasBufferOnWhite(false) { mTextureInfo.mCompositableType = CompositableType::CONTENT_INC; } typedef RotatedContentBuffer::PaintState PaintState; typedef RotatedContentBuffer::ContentType ContentType; - virtual TextureInfo GetTextureInfo() const + virtual TextureInfo GetTextureInfo() const MOZ_OVERRIDE { return mTextureInfo; } - virtual void Clear() + virtual void Clear() MOZ_OVERRIDE { mBufferRect.SetEmpty(); mHasBuffer = false; mHasBufferOnWhite = false; } virtual PaintState BeginPaintBuffer(PaintedLayer* aLayer, uint32_t aFlags) MOZ_OVERRIDE; @@ -434,19 +434,19 @@ public: RotatedContentBuffer::DrawIterator* aIter = nullptr) MOZ_OVERRIDE; virtual void ReturnDrawTargetToBuffer(gfx::DrawTarget*& aReturned) MOZ_OVERRIDE { BorrowDrawTarget::ReturnDrawTarget(aReturned); } virtual void Updated(const nsIntRegion& aRegionToDraw, const nsIntRegion& aVisibleRegion, - bool aDidSelfCopy); + bool aDidSelfCopy) MOZ_OVERRIDE; - virtual void EndPaint(nsTArray<ReadbackProcessor::Update>* aReadbackUpdates = nullptr) + virtual void EndPaint(nsTArray<ReadbackProcessor::Update>* aReadbackUpdates = nullptr) MOZ_OVERRIDE { if (IsSurfaceDescriptorValid(mUpdateDescriptor)) { mForwarder->DestroySharedSurface(&mUpdateDescriptor); } if (IsSurfaceDescriptorValid(mUpdateDescriptorOnWhite)) { mForwarder->DestroySharedSurface(&mUpdateDescriptorOnWhite); } ContentClientRemote::EndPaint(aReadbackUpdates);
--- a/gfx/layers/client/ImageClient.h +++ b/gfx/layers/client/ImageClient.h @@ -94,17 +94,17 @@ protected: */ class ImageClientSingle : public ImageClient { public: ImageClientSingle(CompositableForwarder* aFwd, TextureFlags aFlags, CompositableType aType); - virtual bool UpdateImage(ImageContainer* aContainer, uint32_t aContentFlags); + virtual bool UpdateImage(ImageContainer* aContainer, uint32_t aContentFlags) MOZ_OVERRIDE; virtual void OnDetach() MOZ_OVERRIDE; virtual bool AddTextureClient(TextureClient* aTexture) MOZ_OVERRIDE; virtual TextureInfo GetTextureInfo() const MOZ_OVERRIDE; virtual already_AddRefed<Image> CreateImage(ImageFormat aFormat) MOZ_OVERRIDE; @@ -124,18 +124,18 @@ protected: * We store the ImageBridge id in the TextureClientIdentifier. */ class ImageClientBridge : public ImageClient { public: ImageClientBridge(CompositableForwarder* aFwd, TextureFlags aFlags); - virtual bool UpdateImage(ImageContainer* aContainer, uint32_t aContentFlags); - virtual bool Connect() { return false; } + virtual bool UpdateImage(ImageContainer* aContainer, uint32_t aContentFlags) MOZ_OVERRIDE; + virtual bool Connect() MOZ_OVERRIDE { return false; } virtual void Updated() {} void SetLayer(ShadowableLayer* aLayer) { mLayer = aLayer; } virtual TextureInfo GetTextureInfo() const MOZ_OVERRIDE {
--- a/gfx/layers/client/TextureClient.cpp +++ b/gfx/layers/client/TextureClient.cpp @@ -88,17 +88,17 @@ public: , mTextureClient(nullptr) , mKeep(nullptr) , mIPCOpen(false) { } bool Recv__delete__() MOZ_OVERRIDE; - bool RecvCompositorRecycle() + bool RecvCompositorRecycle() MOZ_OVERRIDE { RECYCLE_LOG("Receive recycle %p (%p)\n", mTextureClient, mWaitForRecycle.get()); mWaitForRecycle = nullptr; return true; } void WaitForCompositorRecycle() {
--- a/gfx/layers/client/TextureClient.h +++ b/gfx/layers/client/TextureClient.h @@ -553,21 +553,21 @@ class BufferTextureClient : public Textu , public TextureClientYCbCr { public: BufferTextureClient(ISurfaceAllocator* aAllocator, gfx::SurfaceFormat aFormat, gfx::BackendType aBackend, TextureFlags aFlags); virtual ~BufferTextureClient(); - virtual bool IsAllocated() const = 0; + virtual bool IsAllocated() const MOZ_OVERRIDE = 0; virtual uint8_t* GetBuffer() const = 0; - virtual gfx::IntSize GetSize() const { return mSize; } + virtual gfx::IntSize GetSize() const MOZ_OVERRIDE { return mSize; } virtual bool Lock(OpenMode aMode) MOZ_OVERRIDE; virtual void Unlock() MOZ_OVERRIDE; virtual bool IsLocked() const MOZ_OVERRIDE { return mLocked; } uint8_t* GetLockedData() const;
--- a/gfx/layers/composite/ContainerLayerComposite.h +++ b/gfx/layers/composite/ContainerLayerComposite.h @@ -70,17 +70,17 @@ public: for (Layer* l = GetFirstChild(); l; l = l->GetNextSibling()) { LayerComposite* child = l->AsLayerComposite(); child->SetLayerManager(aManager); } } virtual void Destroy() MOZ_OVERRIDE; - LayerComposite* GetFirstChildComposite(); + LayerComposite* GetFirstChildComposite() MOZ_OVERRIDE; virtual void RenderLayer(const nsIntRect& aClipRect) MOZ_OVERRIDE; virtual void Prepare(const RenderTargetIntRect& aClipRect) MOZ_OVERRIDE; virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { DefaultComputeEffectiveTransforms(aTransformToSurface); } @@ -136,17 +136,17 @@ protected: ~RefLayerComposite(); public: /** LayerOGL implementation */ Layer* GetLayer() MOZ_OVERRIDE { return this; } void Destroy() MOZ_OVERRIDE; - LayerComposite* GetFirstChildComposite(); + LayerComposite* GetFirstChildComposite() MOZ_OVERRIDE; virtual void RenderLayer(const nsIntRect& aClipRect) MOZ_OVERRIDE; virtual void Prepare(const RenderTargetIntRect& aClipRect) MOZ_OVERRIDE; virtual void ComputeEffectiveTransforms(const gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE { DefaultComputeEffectiveTransforms(aTransformToSurface); }
--- a/gfx/layers/composite/ContentHost.h +++ b/gfx/layers/composite/ContentHost.h @@ -120,17 +120,17 @@ public: , mLocked(false) { } virtual void Composite(EffectChain& aEffectChain, float aOpacity, const gfx::Matrix4x4& aTransform, const gfx::Filter& aFilter, const gfx::Rect& aClipRect, - const nsIntRegion* aVisibleRegion = nullptr); + const nsIntRegion* aVisibleRegion = nullptr) MOZ_OVERRIDE; virtual void SetCompositor(Compositor* aCompositor) MOZ_OVERRIDE; virtual TemporaryRef<gfx::DataSourceSurface> GetAsSurface() MOZ_OVERRIDE; virtual void Dump(std::stringstream& aStream, const char* aPrefix="", bool aDumpHtml=false) MOZ_OVERRIDE; @@ -161,17 +161,17 @@ public: MOZ_ASSERT(mLocked); mTextureHost->Unlock(); if (mTextureHostOnWhite) { mTextureHostOnWhite->Unlock(); } mLocked = false; } - LayerRenderState GetRenderState(); + LayerRenderState GetRenderState() MOZ_OVERRIDE; virtual TemporaryRef<TexturedEffect> GenEffect(const gfx::Filter& aFilter) MOZ_OVERRIDE; protected: CompositableTextureHostRef mTextureHost; CompositableTextureHostRef mTextureHostOnWhite; CompositableTextureSourceRef mTextureSource; CompositableTextureSourceRef mTextureSourceOnWhite; @@ -234,45 +234,45 @@ public: * avoid blocking the main thread. */ class ContentHostIncremental : public ContentHostBase { public: explicit ContentHostIncremental(const TextureInfo& aTextureInfo); ~ContentHostIncremental(); - virtual CompositableType GetType() { return CompositableType::CONTENT_INC; } + virtual CompositableType GetType() MOZ_OVERRIDE { return CompositableType::CONTENT_INC; } virtual LayerRenderState GetRenderState() MOZ_OVERRIDE { return LayerRenderState(); } virtual bool CreatedIncrementalTexture(ISurfaceAllocator* aAllocator, const TextureInfo& aTextureInfo, const nsIntRect& aBufferRect) MOZ_OVERRIDE; virtual void UpdateIncremental(TextureIdentifier aTextureId, SurfaceDescriptor& aSurface, const nsIntRegion& aUpdated, const nsIntRect& aBufferRect, const nsIntPoint& aBufferRotation) MOZ_OVERRIDE; virtual bool UpdateThebes(const ThebesBufferData& aData, const nsIntRegion& aUpdated, const nsIntRegion& aOldValidRegionBack, - nsIntRegion* aUpdatedRegionBack) + nsIntRegion* aUpdatedRegionBack) MOZ_OVERRIDE { NS_ERROR("Shouldn't call this"); return false; } virtual void Composite(EffectChain& aEffectChain, float aOpacity, const gfx::Matrix4x4& aTransform, const gfx::Filter& aFilter, const gfx::Rect& aClipRect, - const nsIntRegion* aVisibleRegion = nullptr); + const nsIntRegion* aVisibleRegion = nullptr) MOZ_OVERRIDE; virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; virtual bool Lock() MOZ_OVERRIDE { MOZ_ASSERT(!mLocked); ProcessTextureUpdates(); mLocked = true; return true;
--- a/gfx/layers/composite/ImageHost.h +++ b/gfx/layers/composite/ImageHost.h @@ -38,17 +38,17 @@ struct EffectChain; * ImageHost. Works with ImageClientSingle and ImageClientBuffered */ class ImageHost : public CompositableHost { public: explicit ImageHost(const TextureInfo& aTextureInfo); ~ImageHost(); - virtual CompositableType GetType() { return mTextureInfo.mCompositableType; } + virtual CompositableType GetType() MOZ_OVERRIDE { return mTextureInfo.mCompositableType; } virtual void Composite(EffectChain& aEffectChain, float aOpacity, const gfx::Matrix4x4& aTransform, const gfx::Filter& aFilter, const gfx::Rect& aClipRect, const nsIntRegion* aVisibleRegion = nullptr) MOZ_OVERRIDE; @@ -61,21 +61,21 @@ public: virtual void SetCompositor(Compositor* aCompositor) MOZ_OVERRIDE; virtual void SetPictureRect(const nsIntRect& aPictureRect) MOZ_OVERRIDE { mPictureRect = aPictureRect; mHasPictureRect = true; } - gfx::IntSize GetImageSize() const; + gfx::IntSize GetImageSize() const MOZ_OVERRIDE; virtual LayerRenderState GetRenderState() MOZ_OVERRIDE; - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; virtual void Dump(std::stringstream& aStream, const char* aPrefix = "", bool aDumpHtml = false) MOZ_OVERRIDE; virtual TemporaryRef<gfx::DataSourceSurface> GetAsSurface() MOZ_OVERRIDE; virtual bool Lock() MOZ_OVERRIDE;
--- a/gfx/layers/composite/ImageLayerComposite.h +++ b/gfx/layers/composite/ImageLayerComposite.h @@ -49,29 +49,29 @@ public: { LayerComposite::SetLayerManager(aManager); mManager = aManager; if (mImageHost) { mImageHost->SetCompositor(mCompositor); } } - virtual void RenderLayer(const nsIntRect& aClipRect); + virtual void RenderLayer(const nsIntRect& aClipRect) MOZ_OVERRIDE; virtual void ComputeEffectiveTransforms(const mozilla::gfx::Matrix4x4& aTransformToSurface) MOZ_OVERRIDE; virtual void CleanupResources() MOZ_OVERRIDE; CompositableHost* GetCompositableHost() MOZ_OVERRIDE; virtual void GenEffectChain(EffectChain& aEffect) MOZ_OVERRIDE; virtual LayerComposite* AsLayerComposite() MOZ_OVERRIDE { return this; } - virtual const char* Name() const { return "ImageLayerComposite"; } + virtual const char* Name() const MOZ_OVERRIDE { return "ImageLayerComposite"; } protected: virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; private: gfx::Filter GetEffectFilter(); private:
--- a/gfx/layers/composite/PaintedLayerComposite.h +++ b/gfx/layers/composite/PaintedLayerComposite.h @@ -62,17 +62,17 @@ public: virtual void CleanupResources() MOZ_OVERRIDE; virtual void GenEffectChain(EffectChain& aEffect) MOZ_OVERRIDE; virtual bool SetCompositableHost(CompositableHost* aHost) MOZ_OVERRIDE; virtual LayerComposite* AsLayerComposite() MOZ_OVERRIDE { return this; } - virtual void InvalidateRegion(const nsIntRegion& aRegion) + virtual void InvalidateRegion(const nsIntRegion& aRegion) MOZ_OVERRIDE { NS_RUNTIMEABORT("PaintedLayerComposites can't fill invalidated regions"); } void SetValidRegion(const nsIntRegion& aRegion) { MOZ_LAYERS_LOG_IF_SHADOWABLE(this, ("Layer::Mutated(%p) ValidRegion", this)); mValidRegion = aRegion;
--- a/gfx/layers/composite/TextureHost.h +++ b/gfx/layers/composite/TextureHost.h @@ -729,17 +729,17 @@ public: return mTexSource; } virtual gfx::SurfaceFormat GetFormat() const MOZ_OVERRIDE; virtual gfx::IntSize GetSize() const MOZ_OVERRIDE; #ifdef MOZ_LAYERS_HAVE_LOG - virtual const char* Name() { return "SharedSurfaceTextureHost"; } + virtual const char* Name() MOZ_OVERRIDE { return "SharedSurfaceTextureHost"; } #endif protected: void EnsureTexSource(); bool mIsLocked; gl::SharedSurface* const mSurf; RefPtr<Compositor> mCompositor;
--- a/gfx/layers/composite/TiledContentHost.h +++ b/gfx/layers/composite/TiledContentHost.h @@ -215,62 +215,62 @@ public: { return LayerRenderState(); } virtual bool UpdateThebes(const ThebesBufferData& aData, const nsIntRegion& aUpdated, const nsIntRegion& aOldValidRegionBack, - nsIntRegion* aUpdatedRegionBack) + nsIntRegion* aUpdatedRegionBack) MOZ_OVERRIDE { NS_ERROR("N/A for tiled layers"); return false; } - const nsIntRegion& GetValidLowPrecisionRegion() const + const nsIntRegion& GetValidLowPrecisionRegion() const MOZ_OVERRIDE { return mLowPrecisionTiledBuffer.GetValidRegion(); } - virtual void SetCompositor(Compositor* aCompositor) + virtual void SetCompositor(Compositor* aCompositor) MOZ_OVERRIDE { CompositableHost::SetCompositor(aCompositor); mTiledBuffer.SetCompositor(aCompositor); mLowPrecisionTiledBuffer.SetCompositor(aCompositor); mOldTiledBuffer.SetCompositor(aCompositor); mOldLowPrecisionTiledBuffer.SetCompositor(aCompositor); } virtual bool UseTiledLayerBuffer(ISurfaceAllocator* aAllocator, const SurfaceDescriptorTiles& aTiledDescriptor) MOZ_OVERRIDE; void Composite(EffectChain& aEffectChain, float aOpacity, const gfx::Matrix4x4& aTransform, const gfx::Filter& aFilter, const gfx::Rect& aClipRect, - const nsIntRegion* aVisibleRegion = nullptr); + const nsIntRegion* aVisibleRegion = nullptr) MOZ_OVERRIDE; - virtual CompositableType GetType() { return CompositableType::CONTENT_TILED; } + virtual CompositableType GetType() MOZ_OVERRIDE { return CompositableType::CONTENT_TILED; } virtual TiledLayerComposer* AsTiledLayerComposer() MOZ_OVERRIDE { return this; } virtual void Attach(Layer* aLayer, Compositor* aCompositor, AttachFlags aFlags = NO_FLAGS) MOZ_OVERRIDE; virtual void Detach(Layer* aLayer = nullptr, AttachFlags aFlags = NO_FLAGS) MOZ_OVERRIDE; virtual void Dump(std::stringstream& aStream, const char* aPrefix="", bool aDumpHtml=false) MOZ_OVERRIDE; - virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix); + virtual void PrintInfo(std::stringstream& aStream, const char* aPrefix) MOZ_OVERRIDE; #if defined(MOZ_WIDGET_GONK) && ANDROID_VERSION >= 17 /** * Store a fence that will signal when the current buffer is no longer being read. * Similar to android's GLConsumer::setReleaseFence() */ virtual void SetReleaseFence(const android::sp<android::Fence>& aReleaseFence) {
--- a/gfx/layers/ipc/CompositorParent.cpp +++ b/gfx/layers/ipc/CompositorParent.cpp @@ -1381,20 +1381,20 @@ public: virtual bool RecvRequestOverfill() MOZ_OVERRIDE { return true; } virtual bool RecvWillStop() MOZ_OVERRIDE { return true; } virtual bool RecvStop() MOZ_OVERRIDE { return true; } virtual bool RecvPause() MOZ_OVERRIDE { return true; } virtual bool RecvResume() MOZ_OVERRIDE { return true; } virtual bool RecvNotifyChildCreated(const uint64_t& child) MOZ_OVERRIDE; virtual bool RecvAdoptChild(const uint64_t& child) MOZ_OVERRIDE { return false; } virtual bool RecvMakeSnapshot(const SurfaceDescriptor& aInSnapshot, - const nsIntRect& aRect) + const nsIntRect& aRect) MOZ_OVERRIDE { return true; } virtual bool RecvFlushRendering() MOZ_OVERRIDE { return true; } - virtual bool RecvNotifyRegionInvalidated(const nsIntRegion& aRegion) { return true; } + virtual bool RecvNotifyRegionInvalidated(const nsIntRegion& aRegion) MOZ_OVERRIDE { return true; } virtual bool RecvStartFrameTimeRecording(const int32_t& aBufferSize, uint32_t* aOutStartIndex) MOZ_OVERRIDE { return true; } virtual bool RecvStopFrameTimeRecording(const uint32_t& aStartIndex, InfallibleTArray<float>* intervals) MOZ_OVERRIDE { return true; } virtual bool RecvGetTileSize(int32_t* aWidth, int32_t* aHeight) MOZ_OVERRIDE { *aWidth = gfxPlatform::GetPlatform()->GetTileWidth(); *aHeight = gfxPlatform::GetPlatform()->GetTileHeight(); return true; }
--- a/gfx/layers/ipc/ISurfaceAllocator.h +++ b/gfx/layers/ipc/ISurfaceAllocator.h @@ -220,17 +220,17 @@ public: } static void WillFree(void* aPointer) { sAmount -= MallocSizeOfOnFree(aPointer); } NS_IMETHOD CollectReports(nsIHandleReportCallback* aHandleReport, - nsISupports* aData, bool aAnonymize) + nsISupports* aData, bool aAnonymize) MOZ_OVERRIDE { return MOZ_COLLECT_REPORT( "explicit/gfx/heap-textures", KIND_HEAP, UNITS_BYTES, sAmount, "Heap memory shared between threads by texture clients and hosts."); } private: static mozilla::Atomic<size_t> sAmount;
--- a/gfx/layers/ipc/ImageBridgeChild.h +++ b/gfx/layers/ipc/ImageBridgeChild.h @@ -298,24 +298,24 @@ public: mozilla::ipc::SharedMemory::SharedMemoryType aType, mozilla::ipc::Shmem* aShmem) MOZ_OVERRIDE; /** * See ISurfaceAllocator.h * Can be used from any thread. * If used outside the ImageBridgeChild thread, it will proxy a synchronous * call on the ImageBridgeChild thread. */ - virtual void DeallocShmem(mozilla::ipc::Shmem& aShmem); + virtual void DeallocShmem(mozilla::ipc::Shmem& aShmem) MOZ_OVERRIDE; virtual PTextureChild* CreateTexture(const SurfaceDescriptor& aSharedData, TextureFlags aFlags) MOZ_OVERRIDE; virtual bool IsSameProcess() const MOZ_OVERRIDE; - virtual void SendPendingAsyncMessges(); + virtual void SendPendingAsyncMessges() MOZ_OVERRIDE; void MarkShutDown(); protected: ImageBridgeChild(); bool DispatchAllocShmemInternal(size_t aSize, SharedMemory::SharedMemoryType aType, Shmem* aShmem, bool aUnsafe);
--- a/gfx/layers/ipc/LayerTransactionParent.h +++ b/gfx/layers/ipc/LayerTransactionParent.h @@ -58,23 +58,23 @@ public: LayerManagerComposite* layer_manager() const { return mLayerManager; } uint64_t GetId() const { return mId; } Layer* GetRoot() const { return mRoot; } // ISurfaceAllocator virtual bool AllocShmem(size_t aSize, ipc::SharedMemory::SharedMemoryType aType, - ipc::Shmem* aShmem) { + ipc::Shmem* aShmem) MOZ_OVERRIDE { return PLayerTransactionParent::AllocShmem(aSize, aType, aShmem); } virtual bool AllocUnsafeShmem(size_t aSize, ipc::SharedMemory::SharedMemoryType aType, - ipc::Shmem* aShmem) { + ipc::Shmem* aShmem) MOZ_OVERRIDE { return PLayerTransactionParent::AllocUnsafeShmem(aSize, aType, aShmem); } virtual void DeallocShmem(ipc::Shmem& aShmem) MOZ_OVERRIDE { PLayerTransactionParent::DeallocShmem(aShmem); }
--- a/gfx/layers/ipc/ShadowLayers.h +++ b/gfx/layers/ipc/ShadowLayers.h @@ -137,17 +137,17 @@ class ShadowLayerForwarder : public Comp public: virtual ~ShadowLayerForwarder(); /** * Setup the IPDL actor for aCompositable to be part of layers * transactions. */ - void Connect(CompositableClient* aCompositable); + void Connect(CompositableClient* aCompositable) MOZ_OVERRIDE; virtual PTextureChild* CreateTexture(const SurfaceDescriptor& aSharedData, TextureFlags aFlags) MOZ_OVERRIDE; virtual void CreatedIncrementalBuffer(CompositableClient* aCompositable, const TextureInfo& aTextureInfo, const nsIntRect& aBufferRect) MOZ_OVERRIDE; @@ -264,17 +264,17 @@ public: const nsIntRegion& aUpdatedRegion, const nsIntRect& aBufferRect, const nsIntPoint& aBufferRotation) MOZ_OVERRIDE; /** * Communicate the picture rect of an image to the compositor */ void UpdatePictureRect(CompositableClient* aCompositable, - const nsIntRect& aRect); + const nsIntRect& aRect) MOZ_OVERRIDE; /** * See CompositableForwarder::UpdatedTexture */ virtual void UpdatedTexture(CompositableClient* aCompositable, TextureClient* aTexture, nsIntRegion* aRegion) MOZ_OVERRIDE; @@ -314,17 +314,17 @@ public: void SetShadowManager(PLayerTransactionChild* aShadowManager); void StopReceiveAsyncParentMessge(); void ClearCachedResources(); void Composite(); - virtual void SendPendingAsyncMessges(); + virtual void SendPendingAsyncMessges() MOZ_OVERRIDE; /** * True if this is forwarding to a LayerManagerComposite. */ bool HasShadowManager() const { return !!mShadowManager; } LayerTransactionChild* GetShadowManager() const { return mShadowManager.get(); } virtual void WindowOverlayChanged() { mWindowOverlayChanged = true; }
--- a/gfx/layers/ipc/SharedBufferManagerParent.h +++ b/gfx/layers/ipc/SharedBufferManagerParent.h @@ -50,18 +50,18 @@ public: SharedBufferManagerParent(Transport* aTransport, ProcessId aOwner, base::Thread* aThread); virtual ~SharedBufferManagerParent(); /** * When the IPC channel down or something bad make this Manager die, clear all the buffer reference! */ virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE; - virtual bool RecvAllocateGrallocBuffer(const IntSize&, const uint32_t&, const uint32_t&, mozilla::layers::MaybeMagicGrallocBufferHandle*); - virtual bool RecvDropGrallocBuffer(const mozilla::layers::MaybeMagicGrallocBufferHandle& handle); + virtual bool RecvAllocateGrallocBuffer(const IntSize&, const uint32_t&, const uint32_t&, mozilla::layers::MaybeMagicGrallocBufferHandle*) MOZ_OVERRIDE; + virtual bool RecvDropGrallocBuffer(const mozilla::layers::MaybeMagicGrallocBufferHandle& handle) MOZ_OVERRIDE; /** * Break the buffer's sharing state, decrease buffer reference for both side */ static void DropGrallocBuffer(ProcessId id, mozilla::layers::SurfaceDescriptor aDesc); // Overriden from IToplevelProtocol IToplevelProtocol*
--- a/gfx/layers/ipc/SharedRGBImage.h +++ b/gfx/layers/ipc/SharedRGBImage.h @@ -47,21 +47,21 @@ protected: public: virtual ISharedImage* AsSharedImage() MOZ_OVERRIDE { return this; } virtual TextureClient* GetTextureClient(CompositableClient* aClient) MOZ_OVERRIDE; virtual uint8_t* GetBuffer() MOZ_OVERRIDE; - gfx::IntSize GetSize(); + gfx::IntSize GetSize() MOZ_OVERRIDE; size_t GetBufferSize(); - TemporaryRef<gfx::SourceSurface> GetAsSourceSurface(); + TemporaryRef<gfx::SourceSurface> GetAsSourceSurface() MOZ_OVERRIDE; bool Allocate(gfx::IntSize aSize, gfx::SurfaceFormat aFormat); private: gfx::IntSize mSize; RefPtr<ImageClient> mCompositable; RefPtr<BufferTextureClient> mTextureClient; };
--- a/gfx/layers/opengl/CompositingRenderTargetOGL.h +++ b/gfx/layers/opengl/CompositingRenderTargetOGL.h @@ -141,17 +141,17 @@ public: gfx::SurfaceFormat GetFormat() const MOZ_OVERRIDE { // XXX - Should it be implemented ? is the above assert true ? MOZ_ASSERT(false, "Not implemented"); return gfx::SurfaceFormat::UNKNOWN; } #ifdef MOZ_DUMP_PAINTING - virtual TemporaryRef<gfx::DataSourceSurface> Dump(Compositor* aCompositor); + virtual TemporaryRef<gfx::DataSourceSurface> Dump(Compositor* aCompositor) MOZ_OVERRIDE; #endif const gfx::IntSize& GetInitSize() const { return mInitParams.mSize; } private: /**
--- a/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.h +++ b/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.h @@ -28,17 +28,17 @@ public: virtual void Unlock() MOZ_OVERRIDE; virtual bool IsLocked() const MOZ_OVERRIDE; virtual bool IsAllocated() const MOZ_OVERRIDE { return !!mSurface; } virtual bool ToSurfaceDescriptor(SurfaceDescriptor& aOutDescriptor) MOZ_OVERRIDE; - virtual gfx::IntSize GetSize() const; + virtual gfx::IntSize GetSize() const MOZ_OVERRIDE; virtual bool HasInternalBuffer() const MOZ_OVERRIDE { return false; } virtual TemporaryRef<gfx::DataSourceSurface> GetAsSurface() MOZ_OVERRIDE; // This TextureClient should not be used in a context where we use CreateSimilar // (ex. component alpha) because the underlying texture data is always created by // an external producer.
--- a/gfx/layers/opengl/MacIOSurfaceTextureHostOGL.h +++ b/gfx/layers/opengl/MacIOSurfaceTextureHostOGL.h @@ -23,32 +23,32 @@ namespace layers { class MacIOSurfaceTextureSourceOGL : public TextureSource , public TextureSourceOGL { public: MacIOSurfaceTextureSourceOGL(CompositorOGL* aCompositor, MacIOSurface* aSurface); virtual ~MacIOSurfaceTextureSourceOGL(); - virtual TextureSourceOGL* AsSourceOGL() { return this; } + virtual TextureSourceOGL* AsSourceOGL() MOZ_OVERRIDE { return this; } virtual void BindTexture(GLenum activetex, gfx::Filter aFilter) MOZ_OVERRIDE; virtual bool IsValid() const MOZ_OVERRIDE { return !!gl(); } virtual gfx::IntSize GetSize() const MOZ_OVERRIDE; virtual gfx::SurfaceFormat GetFormat() const MOZ_OVERRIDE; - virtual GLenum GetTextureTarget() const { return LOCAL_GL_TEXTURE_RECTANGLE_ARB; } + virtual GLenum GetTextureTarget() const MOZ_OVERRIDE { return LOCAL_GL_TEXTURE_RECTANGLE_ARB; } virtual GLenum GetWrapMode() const MOZ_OVERRIDE { return LOCAL_GL_CLAMP_TO_EDGE; } // MacIOSurfaceTextureSourceOGL doesn't own any gl texture - virtual void DeallocateDeviceData() {} + virtual void DeallocateDeviceData() MOZ_OVERRIDE {} virtual void SetCompositor(Compositor* aCompositor) MOZ_OVERRIDE; gl::GLContext* gl() const; protected: RefPtr<CompositorOGL> mCompositor; RefPtr<MacIOSurface> mSurface; @@ -84,17 +84,17 @@ public: return nullptr; // XXX - implement this (for MOZ_DUMP_PAINTING) } gl::GLContext* gl() const; virtual gfx::IntSize GetSize() const MOZ_OVERRIDE; #ifdef MOZ_LAYERS_HAVE_LOG - virtual const char* Name() { return "MacIOSurfaceTextureHostOGL"; } + virtual const char* Name() MOZ_OVERRIDE { return "MacIOSurfaceTextureHostOGL"; } #endif protected: RefPtr<CompositorOGL> mCompositor; RefPtr<MacIOSurfaceTextureSourceOGL> mTextureSource; RefPtr<MacIOSurface> mSurface; };
--- a/gfx/layers/opengl/TextureClientOGL.h +++ b/gfx/layers/opengl/TextureClientOGL.h @@ -29,17 +29,17 @@ public: TextureFlags aFlags, EGLImageImage* aImage, gfx::IntSize aSize); virtual bool IsAllocated() const MOZ_OVERRIDE { return true; } virtual bool HasInternalBuffer() const MOZ_OVERRIDE { return false; } - virtual gfx::IntSize GetSize() const { return mSize; } + virtual gfx::IntSize GetSize() const MOZ_OVERRIDE { return mSize; } virtual bool ToSurfaceDescriptor(SurfaceDescriptor& aOutDescriptor) MOZ_OVERRIDE; // Useless functions. virtual bool Lock(OpenMode mode) MOZ_OVERRIDE; virtual void Unlock() MOZ_OVERRIDE;
--- a/gfx/layers/opengl/TextureHostOGL.h +++ b/gfx/layers/opengl/TextureHostOGL.h @@ -204,17 +204,17 @@ public: void EnsureBuffer(const nsIntSize& aSize, gfxContentType aContentType); void CopyTo(const nsIntRect& aSourceRect, DataTextureSource* aDest, const nsIntRect& aDestRect); - virtual TextureImageTextureSourceOGL* AsTextureImageTextureSource() { return this; } + virtual TextureImageTextureSourceOGL* AsTextureImageTextureSource() MOZ_OVERRIDE { return this; } // TextureSource virtual void DeallocateDeviceData() MOZ_OVERRIDE { mTexImage = nullptr; SetUpdateSerial(0); } @@ -298,17 +298,17 @@ public: virtual void BindTexture(GLenum activetex, gfx::Filter aFilter) MOZ_OVERRIDE; virtual bool IsValid() const MOZ_OVERRIDE; virtual gfx::IntSize GetSize() const MOZ_OVERRIDE { return mSize; } virtual gfx::SurfaceFormat GetFormat() const MOZ_OVERRIDE { return mFormat; } - virtual GLenum GetTextureTarget() const { return mTextureTarget; } + virtual GLenum GetTextureTarget() const MOZ_OVERRIDE { return mTextureTarget; } virtual GLenum GetWrapMode() const MOZ_OVERRIDE { return LOCAL_GL_CLAMP_TO_EDGE; } virtual void DeallocateDeviceData() MOZ_OVERRIDE; virtual void SetCompositor(Compositor* aCompositor) MOZ_OVERRIDE; void SetSize(gfx::IntSize aSize) { mSize = aSize; } @@ -434,29 +434,29 @@ class EGLImageTextureSource : public Tex public: EGLImageTextureSource(CompositorOGL* aCompositor, EGLImage aImage, gfx::SurfaceFormat aFormat, GLenum aTarget, GLenum aWrapMode, gfx::IntSize aSize); - virtual TextureSourceOGL* AsSourceOGL() { return this; } + virtual TextureSourceOGL* AsSourceOGL() MOZ_OVERRIDE { return this; } virtual void BindTexture(GLenum activetex, gfx::Filter aFilter) MOZ_OVERRIDE; virtual bool IsValid() const MOZ_OVERRIDE; virtual gfx::IntSize GetSize() const MOZ_OVERRIDE { return mSize; } virtual gfx::SurfaceFormat GetFormat() const MOZ_OVERRIDE { return mFormat; } virtual gfx::Matrix4x4 GetTextureTransform() MOZ_OVERRIDE; - virtual GLenum GetTextureTarget() const { return mTextureTarget; } + virtual GLenum GetTextureTarget() const MOZ_OVERRIDE { return mTextureTarget; } virtual GLenum GetWrapMode() const MOZ_OVERRIDE { return mWrapMode; } // We don't own anything. virtual void DeallocateDeviceData() MOZ_OVERRIDE {} virtual void SetCompositor(Compositor* aCompositor) MOZ_OVERRIDE; @@ -501,17 +501,17 @@ public: { return nullptr; // XXX - implement this (for MOZ_DUMP_PAINTING) } gl::GLContext* gl() const; virtual gfx::IntSize GetSize() const MOZ_OVERRIDE { return mSize; } - virtual const char* Name() { return "EGLImageTextureHost"; } + virtual const char* Name() MOZ_OVERRIDE { return "EGLImageTextureHost"; } protected: const EGLImage mImage; const EGLSync mSync; const gfx::IntSize mSize; RefPtr<CompositorOGL> mCompositor; RefPtr<EGLImageTextureSource> mTextureSource; };