Bug 1585830 - Fix remote type check in browser_new_content_window_from_chrome_principal.js to work with Fission. r=mconley
authorAndrew McCreight <continuation@gmail.com>
Thu, 03 Oct 2019 16:59:05 +0000
changeset 496205 da487c9c5d6c20e6c5f5f017d08104be0312f7c6
parent 496203 685cadf88d086be58c4808d68633680dfa4a1e53
child 496206 f3804bb2592c3107beaea6ad0181c83cee42f56b
push id36647
push usernerli@mozilla.com
push dateFri, 04 Oct 2019 04:09:18 +0000
treeherdermozilla-central@678d4d2c3c4d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1585830
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1585830 - Fix remote type check in browser_new_content_window_from_chrome_principal.js to work with Fission. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D47991
toolkit/components/windowwatcher/test/browser.ini
toolkit/components/windowwatcher/test/browser_new_content_window_from_chrome_principal.js
--- a/toolkit/components/windowwatcher/test/browser.ini
+++ b/toolkit/components/windowwatcher/test/browser.ini
@@ -1,10 +1,9 @@
 [DEFAULT]
 tags = openwindow
 
 [browser_new_content_window_chromeflags.js]
 [browser_new_remote_window_flags.js]
 run-if = e10s
 [browser_new_content_window_from_chrome_principal.js]
-fail-if = fission
 [browser_new_sized_window.js]
 skip-if = os == 'win' # Bug 1276802 - Opening windows from content on Windows might not get the size right
--- a/toolkit/components/windowwatcher/test/browser_new_content_window_from_chrome_principal.js
+++ b/toolkit/components/windowwatcher/test/browser_new_content_window_from_chrome_principal.js
@@ -18,19 +18,18 @@ add_task(async function test_chrome_open
   });
 
   await ContentTask.spawn(gBrowser.selectedBrowser, null, async function() {
     content.open("http://example.com/", "_blank");
   });
 
   let win = await newWinPromise;
   let browser = win.gBrowser.selectedBrowser;
-  Assert.equal(
-    browser.remoteType,
-    "web",
+  Assert.ok(
+    E10SUtils.isWebRemoteType(browser.remoteType),
     "Should have the default content remote type."
   );
 
   await ContentTask.spawn(browser, null, async function() {
     Assert.ok(
       !content.document.nodePrincipal.isSystemPrincipal,
       "We should not have a system principal."
     );