Bug 1518462 - Consolidate panel footer button dimensions. r=ntim
authorDão Gottwald <dao@mozilla.com>
Tue, 08 Jan 2019 13:54:41 +0000
changeset 452912 d9ae6a8272b04b0f2ae5a76242436acae163cf55
parent 452890 cc4350821ea2def4ed60e47e0eaad5e82403fb4d
child 452913 2cd349b2685c6a570742af2af578971dbe5bc044
push id35334
push userrmaries@mozilla.com
push dateTue, 08 Jan 2019 21:58:40 +0000
treeherdermozilla-central@e08a0bb35c03 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersntim
bugs1518462
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518462 - Consolidate panel footer button dimensions. r=ntim Differential Revision: https://phabricator.services.mozilla.com/D15935
browser/themes/shared/controlcenter/panel.inc.css
browser/themes/shared/downloads/downloads.inc.css
browser/themes/shared/places/editBookmarkPanel.inc.css
toolkit/themes/shared/global.inc.css
toolkit/themes/shared/popupnotification.inc.css
--- a/browser/themes/shared/controlcenter/panel.inc.css
+++ b/browser/themes/shared/controlcenter/panel.inc.css
@@ -158,17 +158,16 @@
   padding-inline-start: 0px;
   color: var(--panel-disabled-color);
 }
 
 /* CONTENT */
 
 .identity-popup-content-blocking-empty-label,
 #tracking-protection-preferences-button > .toolbarbutton-text,
-.identity-popup-footer,
 .tracking-protection-button,
 #identity-popup-trackersView-strict-info > label,
 .identity-popup-cookiesView-list-header,
 .identity-popup-content-blocking-list-item > label,
 #identity-popup-mainView-panel-header > label,
 #identity-popup-trackersView > .panel-header,
 #identity-popup-securityView > .panel-header,
 #identity-popup-breakageReportView > .panel-header,
@@ -308,21 +307,16 @@
   border-top: 1px solid var(--panel-separator-color);
   padding-inline-end: 1em;
 }
 
 #identity-popup-more-info-footer {
   margin-top: 1em;
 }
 
-.identity-popup-footer > button {
-  margin: 0;
-  padding: 8px 20px;
-}
-
 #identity-popup-content-verifier ~ description {
   margin-top: 1em;
   color: var(--panel-disabled-color);
 }
 
 description#identity-popup-content-verified-by,
 description#identity-popup-content-owner,
 description#identity-popup-content-verifier,
--- a/browser/themes/shared/downloads/downloads.inc.css
+++ b/browser/themes/shared/downloads/downloads.inc.css
@@ -34,23 +34,16 @@
 @item@ > toolbarseparator {
   margin: 0;
   border: 0;
   min-width: 0;
   border-left: 1px solid var(--panel-separator-color);
   -moz-appearance: none;
 }
 
-.downloadsPanelFooterButton {
-  margin: 0;
-  padding: 0;
-  min-width: 0;
-  min-height: 40px;
-}
-
 .downloadsPanelFooterButton:hover {
   outline: 1px solid var(--arrowpanel-dimmed);
 }
 
 .downloadsPanelFooterButton:hover:active,
 .downloadsPanelFooterButton[open="true"] {
   outline: 1px solid var(--arrowpanel-dimmed-further);
 }
--- a/browser/themes/shared/places/editBookmarkPanel.inc.css
+++ b/browser/themes/shared/places/editBookmarkPanel.inc.css
@@ -52,15 +52,13 @@ html|img#editBookmarkPanelFavicon[src] {
 }
 
 #editBookmarkPanelBottomButtons {
   display: flex;
 }
 
 .editBookmarkPanelBottomButton {
   flex: 1;
-  margin: 0;
-  padding: .8em 0;
 }
 
 .editBookmarkPanelBottomButton:not(:last-child) {
   border-inline-end: 1px solid var(--panel-separator-color);
 }
--- a/toolkit/themes/shared/global.inc.css
+++ b/toolkit/themes/shared/global.inc.css
@@ -55,16 +55,19 @@
   background-color: var(--arrowpanel-dimmed);
 }
 
 .panel-footer > button {
   -moz-appearance: none;
   border-top: 1px solid var(--panel-separator-color);
   /* !important overrides :hover and :active colors from button.css: */
   color: inherit !important;
+  min-width: 0;
+  margin: 0;
+  padding: .9em;
 }
 
 .panel-footer > button[disabled] {
   color: var(--panel-disabled-color) !important;
 }
 
 .panel-footer > button:-moz-focusring {
   outline: 1px dotted;
--- a/toolkit/themes/shared/popupnotification.inc.css
+++ b/toolkit/themes/shared/popupnotification.inc.css
@@ -53,19 +53,16 @@
 }
 
 .popup-notification-button-container:hover > toolbarseparator {
   margin: 0;
 }
 
 .popup-notification-button {
   flex: 1;
-  margin: 0;
-  min-width: 0;
-  min-height: 41px;
 }
 
 .popup-notification-primary-button:not([alone]) {
   flex: 0 50%;
 }
 
 .popup-notification-secondary-button[hidden="true"] ~ .popup-notification-primary-button {
   flex: 1;