Bug 1426452 - Remove check_top_objdir() call from CompileDB; r=chmanchester
authorMike Shal <mshal@mozilla.com>
Wed, 20 Dec 2017 13:44:34 -0500
changeset 397062 d8e5cace54dca1de98a9581aa66562e7b5f6847c
parent 397061 41168df03ca6d90b175c86aabd899535d075ab22
child 397063 3ce865c24dd7348a8ca710656c1e76918542897e
push id33123
push userncsoregi@mozilla.com
push dateThu, 21 Dec 2017 10:00:47 +0000
treeherdermozilla-central@06a19fbe2581 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1426452, 1224450
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1426452 - Remove check_top_objdir() call from CompileDB; r=chmanchester Prior to bug 1224450, CompileDB used data from the Makefiles to generate the compilation command-lines. Now that the data is derived entirely from moz.build, we don't need to check that the Makefile is present. This enables a simple "ac_add_options --build-backends=CompileDB" mozconfig to work without building a make backend first. MozReview-Commit-ID: 9tYumyUyg5Y
python/mozbuild/mozbuild/compilation/database.py
--- a/python/mozbuild/mozbuild/compilation/database.py
+++ b/python/mozbuild/mozbuild/compilation/database.py
@@ -2,17 +2,16 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this file,
 # You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # This modules provides functionality for dealing with code completion.
 
 import os
 import types
 
-from mozbuild.compilation import util
 from mozbuild.backend.common import CommonBackend
 from mozbuild.frontend.data import (
     ComputedFlags,
     Sources,
     GeneratedSources,
     DirectoryTraversal,
     Linkable,
     LocalInclude,
@@ -29,18 +28,16 @@ from collections import (
     defaultdict,
     OrderedDict,
 )
 
 
 class CompileDBBackend(CommonBackend):
     def _init(self):
         CommonBackend._init(self)
-        if not util.check_top_objdir(self.environment.topobjdir):
-            raise Exception()
 
         # The database we're going to dump out to.
         self._db = OrderedDict()
 
         # The cache for per-directory flags
         self._flags = {}
 
         self._envs = {}