Backed out changeset d461adfd884e (bug 1365309)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Fri, 11 Aug 2017 09:29:03 +0200
changeset 374271 d7a7569e436a330711c0cd8b622c399b14fb3190
parent 374270 2145dba678d8f69a35149a120908445e55f02587
child 374272 d5bdc2c7ca34dcb6a51365aee8aef45cd76854c7
push id32318
push userkwierso@gmail.com
push dateFri, 11 Aug 2017 20:16:01 +0000
treeherdermozilla-central@80ff3f300e05 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1365309
milestone57.0a1
backs outd461adfd884e329934bff39cb9afd0258b04d2de
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset d461adfd884e (bug 1365309)
tools/profiler/tests/gtest/GeckoProfiler.cpp
--- a/tools/profiler/tests/gtest/GeckoProfiler.cpp
+++ b/tools/profiler/tests/gtest/GeckoProfiler.cpp
@@ -765,17 +765,17 @@ void DoSuspendAndSample(int aTid, nsIThr
       "GeckoProfiler_SuspendAndSample_Test::TestBody",
       [&]() {
         uint32_t features = ProfilerFeature::Leaf;
         GTestStackCollector collector;
         profiler_suspend_and_sample_thread(aTid, features, collector,
                                            /* sampleNative = */ true);
 
         ASSERT_TRUE(collector.mSetIsMainThread == 1);
-        ASSERT_TRUE(collector.mFrames > 0);
+        ASSERT_TRUE(collector.mFrames > 5); // approximate; must be > 0
       }),
     NS_DISPATCH_SYNC);
 }
 
 TEST(GeckoProfiler, SuspendAndSample)
 {
   nsCOMPtr<nsIThread> thread;
   nsresult rv = NS_NewNamedThread("GeckoProfGTest", getter_AddRefs(thread));