bug 743587 Intermittent Linux talos crash [@ nsHttpConnection::CloseTransaction] r=honzab
authorPatrick McManus <mcmanus@ducksong.com>
Wed, 11 Apr 2012 13:11:10 -0400
changeset 91453 d770f8c6e19b7ab64fb60adbe458429c9f434d1d
parent 91452 69e021051aa5cba60022da60a3a96aa5ffcb7ba2
child 91454 5ed7fadb52aadc7f1b08e72704b86322cd978da0
push id22445
push usereakhgari@mozilla.com
push dateThu, 12 Apr 2012 16:19:55 +0000
treeherdermozilla-central@901dfde60183 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershonzab
bugs743587
milestone14.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 743587 Intermittent Linux talos crash [@ nsHttpConnection::CloseTransaction] r=honzab
netwerk/protocol/http/nsHttpConnection.cpp
--- a/netwerk/protocol/http/nsHttpConnection.cpp
+++ b/netwerk/protocol/http/nsHttpConnection.cpp
@@ -1129,20 +1129,22 @@ nsHttpConnection::CloseTransaction(nsAHt
 
     if (mUsingSpdy) {
         DontReuse();
         // if !mSpdySession then mUsingSpdy must be false for canreuse()
         mUsingSpdy = false;
         mSpdySession = nsnull;
     }
 
-    mHttp1xTransactionCount += mTransaction->Http1xTransactionCount();
+    if (mTransaction) {
+        mHttp1xTransactionCount += mTransaction->Http1xTransactionCount();
 
-    mTransaction->Close(reason);
-    mTransaction = nsnull;
+        mTransaction->Close(reason);
+        mTransaction = nsnull;
+    }
 
     if (mCallbacks) {
         nsIInterfaceRequestor *cbs = nsnull;
         mCallbacks.swap(cbs);
         NS_ProxyRelease(mCallbackTarget, cbs);
     }
 
     if (NS_FAILED(reason))