Bug 1556809, wait for render() method to complete r=julienw
authorNeil Deakin <neil@mozilla.com>
Thu, 06 Jun 2019 17:39:01 +0000
changeset 477862 d6958b63c9a68cf68a46c7eca95c677a1e4cf947
parent 477861 0d7ebb70b7c9e9f18d74084d8eea35e9d993c8e5
child 477863 e7c35e21525554d248df624a3eb0f9165f38814e
push id36125
push userapavel@mozilla.com
push dateFri, 07 Jun 2019 22:00:07 +0000
treeherdermozilla-central@d820bbb356aa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjulienw
bugs1556809
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1556809, wait for render() method to complete r=julienw Differential Revision: https://phabricator.services.mozilla.com/D33802
devtools/client/performance/views/overview.js
--- a/devtools/client/performance/views/overview.js
+++ b/devtools/client/performance/views/overview.js
@@ -219,17 +219,17 @@ const OverviewView = {
     // Check to see if the recording that just stopped is the current recording.
     // If it is, render the high-res graphs. For manual recordings, it will also
     // be the current recording, but profiles generated by `console.profile` can stop
     // while having another profile selected -- in this case, OverviewView should keep
     // rendering the current recording.
     if (recording !== PerformanceController.getCurrentRecording()) {
       return;
     }
-    this.render(FRAMERATE_GRAPH_HIGH_RES_INTERVAL);
+    await this.render(FRAMERATE_GRAPH_HIGH_RES_INTERVAL);
     await this._checkSelection(recording);
   }),
 
   /**
    * Called when a new recording is selected.
    */
   _onRecordingSelected: OverviewViewOnStateChange(async function(recording) {
     this._setGraphVisibilityFromRecordingFeatures(recording);