Bug 1491442 - Add some documentation to mPixelHostingView. r=mattwoodrow
authorMarkus Stange <mstange@themasta.com>
Fri, 16 Aug 2019 01:11:03 +0000
changeset 488404 d66f54731eeb5e3117561152005e9a48a22c3838
parent 488403 9216803cdf01a74cb7f66632e04dae97651f3913
child 488405 8e82722106c0d88adb7cbf322d764e72e7848838
push id36443
push userccoroiu@mozilla.com
push dateFri, 16 Aug 2019 09:48:15 +0000
treeherdermozilla-central@5d4cbfe103bb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1491442
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1491442 - Add some documentation to mPixelHostingView. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D38750
widget/cocoa/nsChildView.h
--- a/widget/cocoa/nsChildView.h
+++ b/widget/cocoa/nsChildView.h
@@ -206,18 +206,25 @@ class WidgetRenderingContext;
   // CGContext painting (i.e. non-accelerated).
   CGImageRef mTopLeftCornerMask;
 
   // Subviews of self, which act as container views for vibrancy views and
   // non-draggable views.
   NSView* mVibrancyViewsContainer;      // [STRONG]
   NSView* mNonDraggableViewsContainer;  // [STRONG]
 
-  // The view that does our drawing. This is a subview of self so that it can
-  // be ordered on top of mVibrancyViewsContainer.
+  // The view that does our drawing. Always non-null.
+  // This is a subview of self so that it can be ordered on top of
+  // mVibrancyViewsContainer. Drawing in this view can be performed in different
+  // ways:
+  // If mUsingOMTCompositor is false, drawing is performed on the main thread
+  // inside the view's drawRect handler. If mUsingOMTCompositor is true,
+  // mGLContext will be non-null and will be associated with mPixelHostingView,
+  // and rendering will be performed on the compositor thread into mGLContext's
+  // primary framebuffer.
   PixelHostingView* mPixelHostingView;
 
   // Last pressure stage by trackpad's force click
   NSInteger mLastPressureStage;
 }
 
 // class initialization
 + (void)initialize;