Bug 965602 - dragexit should always reset dragoveritem in Australis' customize mode, r=mikedeboer
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Thu, 30 Jan 2014 16:30:52 +0000
changeset 166026 d5823c08b120a1c74ddef1d4e5433b73e1ee5362
parent 166025 16dbb9ba6d52e82534828fb2a181b100edef5c6d
child 166027 fe5ce0351d728b289c7b6c4c6ab22771a4283f89
push id26109
push userryanvm@gmail.com
push dateThu, 30 Jan 2014 21:23:09 +0000
treeherdermozilla-central@d0bec3c2be01 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmikedeboer
bugs965602
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 965602 - dragexit should always reset dragoveritem in Australis' customize mode, r=mikedeboer
browser/components/customizableui/src/CustomizeMode.jsm
--- a/browser/components/customizableui/src/CustomizeMode.jsm
+++ b/browser/components/customizableui/src/CustomizeMode.jsm
@@ -1368,16 +1368,20 @@ CustomizeMode.prototype = {
     }
 
     let draggedItemId =
       aEvent.dataTransfer.mozGetDataAt(kDragDataTypePrefix + documentId, 0);
 
     let draggedWrapper = document.getElementById("wrapper-" + draggedItemId);
     draggedWrapper.hidden = false;
     draggedWrapper.removeAttribute("mousedown");
+    if (this._dragOverItem) {
+      this._cancelDragActive(this._dragOverItem);
+      this._dragOverItem = null;
+    }
     this._showPanelCustomizationPlaceholders();
   },
 
   _isUnwantedDragDrop: function(aEvent) {
     // The simulated events generated by synthesizeDragStart/synthesizeDrop in
     // mochitests are used only for testing whether the right data is being put
     // into the dataTransfer. Neither cause a real drop to occur, so they don't
     // set the source node. There isn't a means of testing real drag and drops,