Bug 1210862 - Rename button_corner_radius -> standard_corner_radius & update value. r=ally
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 06 Oct 2015 09:10:04 -0400
changeset 266946 d53aaea8928228b4c86bfd2b76a34ae96963bdd7
parent 266945 a7a050a4ec474c59cd861b3291aa2e30285050bf
child 266947 92ae0a8c5183ec01d9afd3ebb62e77e2dd57fdf2
push id29503
push usercbook@mozilla.com
push dateFri, 09 Oct 2015 09:36:47 +0000
treeherdermozilla-central@462074ffada4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersally
bugs1210862
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1210862 - Rename button_corner_radius -> standard_corner_radius & update value. r=ally
mobile/android/base/ZoomedView.java
mobile/android/base/resources/drawable/button_enabled_action_blue_round.xml
mobile/android/base/resources/drawable/button_enabled_action_orange_round.xml
mobile/android/base/resources/drawable/button_pressed_action_blue_round.xml
mobile/android/base/resources/drawable/button_pressed_action_orange_round.xml
mobile/android/base/resources/drawable/overlay_share_button_background_first.xml
mobile/android/base/resources/drawable/remote_tabs_setup_button_background.xml
mobile/android/base/resources/drawable/toolbar_grey_round.xml
mobile/android/base/resources/values/dimens.xml
--- a/mobile/android/base/ZoomedView.java
+++ b/mobile/android/base/ZoomedView.java
@@ -266,17 +266,17 @@ public class ZoomedView extends FrameLay
         closeButton = (ImageView) findViewById(R.id.dialog_close);
         changeZoomFactorButton = (TextView) findViewById(R.id.change_zoom_factor);
         zoomedImageView = (ImageView) findViewById(R.id.zoomed_image_view);
 
         setTextInZoomFactorButton(zoomFactor);
 
         toolbarHeight = getResources().getDimensionPixelSize(R.dimen.zoomed_view_toolbar_height);
         containterSize = getResources().getDimensionPixelSize(R.dimen.drawable_dropshadow_size);
-        cornerRadius = getResources().getDimensionPixelSize(R.dimen.button_corner_radius);
+        cornerRadius = getResources().getDimensionPixelSize(R.dimen.standard_corner_radius);
 
         moveToolbar(true);
     }
 
     private void setListeners() {
         closeButton.setOnClickListener(new View.OnClickListener() {
             public void onClick(View view) {
                 stopZoomDisplay(true);
--- a/mobile/android/base/resources/drawable/button_enabled_action_blue_round.xml
+++ b/mobile/android/base/resources/drawable/button_enabled_action_blue_round.xml
@@ -2,10 +2,10 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
        android:shape="rectangle" >
   <solid android:color="@color/link_blue_pressed" />
   <corners
-      android:radius="@dimen/button_corner_radius" />
+      android:radius="@dimen/standard_corner_radius" />
 </shape>
--- a/mobile/android/base/resources/drawable/button_enabled_action_orange_round.xml
+++ b/mobile/android/base/resources/drawable/button_enabled_action_orange_round.xml
@@ -2,10 +2,10 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
        android:shape="rectangle" >
   <solid android:color="@color/action_orange" />
   <corners
-      android:radius="@dimen/button_corner_radius" />
+      android:radius="@dimen/standard_corner_radius" />
 </shape>
--- a/mobile/android/base/resources/drawable/button_pressed_action_blue_round.xml
+++ b/mobile/android/base/resources/drawable/button_pressed_action_blue_round.xml
@@ -2,10 +2,10 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
        android:shape="rectangle" >
   <solid android:color="@color/link_blue" />
   <corners
-      android:radius="@dimen/button_corner_radius" />
+      android:radius="@dimen/standard_corner_radius" />
 </shape>
--- a/mobile/android/base/resources/drawable/button_pressed_action_orange_round.xml
+++ b/mobile/android/base/resources/drawable/button_pressed_action_orange_round.xml
@@ -2,10 +2,10 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
        android:shape="rectangle" >
   <solid android:color="@color/action_orange_pressed" />
   <corners
-      android:radius="@dimen/button_corner_radius" />
+      android:radius="@dimen/standard_corner_radius" />
 </shape>
--- a/mobile/android/base/resources/drawable/overlay_share_button_background_first.xml
+++ b/mobile/android/base/resources/drawable/overlay_share_button_background_first.xml
@@ -8,22 +8,22 @@
 <!-- Should be kept in sync with overlay_share_button_background.xml
 
      This first item in the list has rounded corners. -->
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
 
     <item android:state_pressed="true">
         <shape>
             <solid android:color="@color/toolbar_grey_pressed"/>
-            <corners android:topLeftRadius="@dimen/button_corner_radius"
-                     android:topRightRadius="@dimen/button_corner_radius"/>
+            <corners android:topLeftRadius="@dimen/standard_corner_radius"
+                     android:topRightRadius="@dimen/standard_corner_radius"/>
         </shape>
     </item>
 
     <item>
         <shape>
             <solid android:color="@color/toolbar_grey"/>
-            <corners android:topLeftRadius="@dimen/button_corner_radius"
-                     android:topRightRadius="@dimen/button_corner_radius"/>
+            <corners android:topLeftRadius="@dimen/standard_corner_radius"
+                     android:topRightRadius="@dimen/standard_corner_radius"/>
         </shape>
     </item>
 
 </selector>
--- a/mobile/android/base/resources/drawable/remote_tabs_setup_button_background.xml
+++ b/mobile/android/base/resources/drawable/remote_tabs_setup_button_background.xml
@@ -2,19 +2,19 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
     <item android:state_pressed="true">
         <shape android:shape="rectangle">
             <solid android:color="@color/remote_tabs_setup_button_background_hit"/>
-            <corners android:radius="@dimen/button_corner_radius"/>
+            <corners android:radius="@dimen/standard_corner_radius"/>
         </shape>
     </item>
 
     <item>
         <shape android:shape="rectangle">
             <solid android:color="@color/action_orange"/>
-            <corners android:radius="@dimen/button_corner_radius"/>
+            <corners android:radius="@dimen/standard_corner_radius"/>
         </shape>
     </item>
 </selector>
--- a/mobile/android/base/resources/drawable/toolbar_grey_round.xml
+++ b/mobile/android/base/resources/drawable/toolbar_grey_round.xml
@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android">
     <solid android:color="@color/toolbar_grey"/>
-    <corners android:radius="@dimen/button_corner_radius"/>
+    <corners android:radius="@dimen/standard_corner_radius"/>
 </shape>
 
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -1,16 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <resources>
 
-    <dimen name="button_corner_radius">3dp</dimen>
+    <dimen name="standard_corner_radius">4dp</dimen>
 
     <dimen name="autocomplete_min_width">200dp</dimen>
     <dimen name="autocomplete_row_height">32dp</dimen>
 
     <dimen name="browser_toolbar_height">48dp</dimen>
     <!-- This value is the height of the Tabs Panel header view
          (browser_toolbar_height) minus the height of the indicator
          (6dp). This value should change when the height of the view changes. -->