Bug 1547463 Explicit load customElements.js where necessary r=bgrins
authorAndrew Swan <aswan@mozilla.com>
Mon, 29 Apr 2019 18:14:17 +0000
changeset 471785 d507bf325bf77e1513b1e1ebe3bc3714a7ba6998
parent 471784 06792d1b08fd016bfeec0976687989ffe44bae75
child 471786 aec4b19308a9b4eb59e2b988840af1d8996825c8
push id35934
push usershindli@mozilla.com
push dateMon, 29 Apr 2019 21:53:38 +0000
treeherdermozilla-central@f6766ba4ac77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1547463
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1547463 Explicit load customElements.js where necessary r=bgrins commonDialog.xul and profileDowngrade.xul both may load early enough during startup that they don't automatically get customElements.js. The quick workaround here is just to load it explicitly in those documents. Differential Revision: https://phabricator.services.mozilla.com/D29235
toolkit/components/prompts/content/commonDialog.xul
toolkit/profile/content/profileDowngrade.xul
--- a/toolkit/components/prompts/content/commonDialog.xul
+++ b/toolkit/components/prompts/content/commonDialog.xul
@@ -13,16 +13,17 @@
 <dialog id="commonDialog"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
         aria-describedby="infoBody"
         onunload="commonDialogOnUnload();"
         buttonpack="center">
 
   <script src="chrome://global/content/commonDialog.js"/>
   <script src="chrome://global/content/globalOverlay.js"/>
+  <script src="chrome://global/content/customElements.js"/>
   <script>
     document.addEventListener("DOMContentLoaded", function() {
       commonDialogOnLoad();
     });
   </script>
 
   <commandset id="selectEditMenuItems">
     <command id="cmd_copy" oncommand="goDoCommand('cmd_copy')" disabled="true"/>
--- a/toolkit/profile/content/profileDowngrade.xul
+++ b/toolkit/profile/content/profileDowngrade.xul
@@ -23,16 +23,17 @@
 #ifdef XP_WIN
         buttonlabelaccept="&window.quit-win;"
 #else
         buttonlabelaccept="&window.quit-nonwin;"
 #endif
         buttons="accept,extra1" buttonpack="end">
 
   <script src="profileDowngrade.js"/>
+  <script src="chrome://global/content/customElements.js"/>
 
   <hbox flex="1" align="start">
     <image id="info" role="presentation"/>
     <vbox flex="1">
       <description id="nosync">&window.nosync;</description>
 #ifdef MOZ_SERVICES_SYNC
       <description id="sync">&window.sync;</description>
 #endif