Bug 1457863 - 1. Update kotlin to 1.2.20; r=nalexander
☠☠ backed out by 6340700abe0f ☠ ☠
authorJim Chen <nchen@mozilla.com>
Tue, 01 May 2018 14:17:11 -0400
changeset 416445 d4e8c9ea8f0e7041cde174758867bd85d6f1c5b7
parent 416444 d858e46ec74a7963d4c0519c29e1fe3754614e8a
child 416446 a9e4a1af13b92a150a30dd9d89f12c9c4e2e97e4
push id33928
push usercsabou@mozilla.com
push dateWed, 02 May 2018 09:26:14 +0000
treeherdermozilla-central@d28c45ebedcc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1457863
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457863 - 1. Update kotlin to 1.2.20; r=nalexander Update the kotlin version used for GeckoView tests to 1.2.20. Also turn on "warnings-as-errors", which is a compiler option introduced in kotlin 1.2. MozReview-Commit-ID: EjVPQebAuaS
build.gradle
mobile/android/geckoview/build.gradle
--- a/build.gradle
+++ b/build.gradle
@@ -45,17 +45,17 @@ buildscript {
             }
         }
         // For in tree plugins.
         maven {
             url "file://${gradle.mozconfig.topsrcdir}/mobile/android/gradle/m2repo"
         }
     }
 
-    ext.kotlin_version = '1.1.51'
+    ext.kotlin_version = '1.2.20'
     ext.support_library_version = '23.4.0'
 
     if (gradle.mozconfig.substs.MOZ_ANDROID_GOOGLE_PLAY_SERVICES) {
         ext.google_play_services_version = '8.4.0'
     }
 
     dependencies {
         classpath 'com.android.tools.build:gradle:3.0.1'
--- a/mobile/android/geckoview/build.gradle
+++ b/mobile/android/geckoview/build.gradle
@@ -165,16 +165,20 @@ tasks.withType(org.jetbrains.kotlin.grad
             }
             def (_, type, file, line, column, message) = matches[0]
             type = (type == 'w') ? 'warning' : 'error'
             // Use logger.lifecycle, which does not go through stderr again.
             logger.lifecycle "$file:$line:$column: $type: $message"
         }
     } as StandardOutputListener
 
+    kotlinOptions {
+        allWarningsAsErrors = true
+    }
+
     doFirst {
         logging.addStandardErrorListener(listener)
     }
     doLast {
         logging.removeStandardErrorListener(listener)
     }
 }