Bug 1518374 - Remove obsolete comment in Animation.h about kNoIndex; r=hiro
authorBrian Birtles <birtles@gmail.com>
Tue, 08 Jan 2019 06:41:34 +0000
changeset 452807 d497b0f223c9f1836cf320b594964794fd54f4bd
parent 452806 3ff9725e0c3a53a71fb3af3c1f4fd9f49828fa5b
child 452808 c19867adc2c78839543c18eecd2c6425e736b894
push id35330
push useropoprus@mozilla.com
push dateTue, 08 Jan 2019 09:41:12 +0000
treeherdermozilla-central@4ad5b70956ab [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1518374, 1203009
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518374 - Remove obsolete comment in Animation.h about kNoIndex; r=hiro As of bug 1203009 / changeset 37b6deedaab6 and per spec, we no longer reset the animation index when an Animation re-enters the idle state and kNoIndex is no longer defined. Depends on D15898 Differential Revision: https://phabricator.services.mozilla.com/D15899
dom/animation/Animation.h
--- a/dom/animation/Animation.h
+++ b/dom/animation/Animation.h
@@ -531,18 +531,16 @@ class Animation : public DOMEventTargetH
   // finished but then a state change makes it not finished.
   // This object is lazily created by GetFinished.
   // See http://drafts.csswg.org/web-animations/#current-finished-promise
   RefPtr<Promise> mFinished;
 
   static uint64_t sNextAnimationIndex;
 
   // The relative position of this animation within the global animation list.
-  // This is kNoIndex while the animation is in the idle state and is updated
-  // each time the animation transitions out of the idle state.
   //
   // Note that subclasses such as CSSTransition and CSSAnimation may repurpose
   // this member to implement their own brand of sorting. As a result, it is
   // possible for two different objects to have the same index.
   uint64_t mAnimationIndex;
 
   // While ordering Animation objects for event dispatch, the index of the
   // target node in its parent may be cached in mCachedChildIndex.