Backed out changeset ba6b75f29652 (bug 1288031) for web platform e10s test failure
authorIris Hsiao <ihsiao@mozilla.com>
Thu, 21 Jul 2016 17:44:44 +0800
changeset 306053 d3c449980296db1bc307e56ca78022bc49dd823b
parent 306052 fff92b2a76ecb3b4d81a33e10fa98dcfd167ed93
child 306054 0a0f2f8db1e6faa3a56fa69aa280bfbae507c4d3
push id30474
push usercbook@mozilla.com
push dateThu, 21 Jul 2016 14:25:10 +0000
treeherdermozilla-central@6b180266ac16 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1288031
milestone50.0a1
backs outba6b75f296522d9e351d1201ed8c981824c61da8
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset ba6b75f29652 (bug 1288031) for web platform e10s test failure
dom/workers/WorkerPrivate.cpp
--- a/dom/workers/WorkerPrivate.cpp
+++ b/dom/workers/WorkerPrivate.cpp
@@ -600,19 +600,17 @@ private:
   }
 };
 
 class CloseEventRunnable final : public WorkerRunnable
 {
 public:
   explicit CloseEventRunnable(WorkerPrivate* aWorkerPrivate)
   : WorkerRunnable(aWorkerPrivate, WorkerThreadUnchangedBusyCount)
-  {
-    aWorkerPrivate->CloseHandlerStarted();
-  }
+  { }
 
 private:
   virtual bool
   PreDispatch(WorkerPrivate* aWorkerPrivate) override
   {
     MOZ_CRASH("Don't call Dispatch() on CloseEventRunnable!");
   }
 
@@ -620,16 +618,18 @@ private:
   PostDispatch(WorkerPrivate* aWorkerPrivate, bool aDispatchResult) override
   {
     MOZ_CRASH("Don't call Dispatch() on CloseEventRunnable!");
   }
 
   virtual bool
   WorkerRun(JSContext* aCx, WorkerPrivate* aWorkerPrivate) override
   {
+    aWorkerPrivate->CloseHandlerStarted();
+
     WorkerGlobalScope* globalScope = aWorkerPrivate->GlobalScope();
 
     RefPtr<Event> event = NS_NewDOMEvent(globalScope, nullptr, nullptr);
 
     event->InitEvent(NS_LITERAL_STRING("close"), false, false);
     event->SetTrusted(true);
 
     globalScope->DispatchDOMEvent(nullptr, event, nullptr, nullptr);