Bug 1361987 - Move maximizeWindow call to not use a return in a generator. r=ato
authorDavid Burns <dburns@mozilla.com>
Fri, 05 May 2017 14:49:41 +0100
changeset 356851 d330e31dcb2345bdf49352249fe533721215cd15
parent 356850 b820c22816054fb93270d66375862913054bee7c
child 356852 ed74f44b40c1cc58bfe3cd628fc5834336be6081
push id31775
push userihsiao@mozilla.com
push dateMon, 08 May 2017 03:10:38 +0000
treeherdermozilla-central@22aaf8bad4df [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs1361987
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1361987 - Move maximizeWindow call to not use a return in a generator. r=ato The maximizeWindow call in Marionette uses return which is not valid javascript. This change update the response that is then picked up by the server before returning to the remote end. MozReview-Commit-ID: JJzsTHba0AK
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -2901,17 +2901,17 @@ GeckoDriver.prototype.maximizeWindow = f
 
     if (win.windowState == win.STATE_MAXIMIZED) {
       win.restore();
     } else {
       win.maximize();
     }
   });
 
-  return {
+  resp.body.value = {
     x: win.screenX,
     y: win.screenY,
     width: win.outerWidth,
     height: win.outerHeight,
   };
 };
 
 /**