Bug 1459403: Add a FIXME comment which I think reveals a bug but I haven't confirmed it. r=hiro
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sat, 26 May 2018 23:44:50 +0200
changeset 420139 d32d6cdc2c9789b3e2ba63b5ad6b493b65ad69bb
parent 420138 b9099625aff28399340e193e314483ff9ff0899f
child 420140 1f3548d0baf6641ceda7db61ae29a41c4845acb4
push id34065
push useraciure@mozilla.com
push dateMon, 28 May 2018 21:54:18 +0000
treeherdermozilla-central@35aa0dde259f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1459403
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1459403: Add a FIXME comment which I think reveals a bug but I haven't confirmed it. r=hiro MozReview-Commit-ID: DgCfqA5TNzP
servo/components/style/properties/helpers/animated_properties.mako.rs
--- a/servo/components/style/properties/helpers/animated_properties.mako.rs
+++ b/servo/components/style/properties/helpers/animated_properties.mako.rs
@@ -2473,16 +2473,18 @@ impl Animate for ComputedScale {
     fn animate(
         &self,
         other: &Self,
         procedure: Procedure,
     ) -> Result<Self, ()> {
         let from = ComputedScale::resolve(self);
         let to = ComputedScale::resolve(other);
 
+        // FIXME(emilio, bug 1464791): why does this do something different than
+        // Scale3D / TransformOperation::Scale3D?
         if procedure == Procedure::Add {
             // scale(x1,y1,z1)*scale(x2,y2,z2) = scale(x1*x2, y1*y2, z1*z2)
             return Ok(Scale::Scale3D(from.0 * to.0, from.1 * to.1, from.2 * to.2));
         }
 
         Ok(Scale::Scale3D(
             animate_multiplicative_factor(from.0, to.0, procedure)?,
             animate_multiplicative_factor(from.1, to.1, procedure)?,