Bug 1534673 - Part 2: Update a couple of mochitests to stop checking track ids. r=jib
authorByron Campen [:bwc] <docfaraday@gmail.com>
Tue, 19 Mar 2019 16:03:32 +0000
changeset 465102 d31734f7868376035c56c9b5eeb17c9bd8b98168
parent 465101 99269d93d2bfcfad806581779a104057e6e266ed
child 465103 5701b7be457c0f1de1b15eb5793946198fe95381
push id35732
push useropoprus@mozilla.com
push dateWed, 20 Mar 2019 10:52:37 +0000
treeherdermozilla-central@708979f9c3f3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1534673
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534673 - Part 2: Update a couple of mochitests to stop checking track ids. r=jib Differential Revision: https://phabricator.services.mozilla.com/D23207
dom/media/tests/mochitest/test_peerConnection_addtrack_removetrack_events.html
dom/media/tests/mochitest/test_peerConnection_constructedStream.html
--- a/dom/media/tests/mochitest/test_peerConnection_addtrack_removetrack_events.html
+++ b/dom/media/tests/mochitest/test_peerConnection_addtrack_removetrack_events.html
@@ -47,17 +47,16 @@ runNetworkTest(function (options) {
 
           eventsPromise = haveEvent(remoteStream, "addtrack",
               wait(50000, new Error("No addtrack event for " + newTrack.id)))
             .then(trackEvent => {
               ok(trackEvent instanceof MediaStreamTrackEvent,
                  "Expected event to be instance of MediaStreamTrackEvent");
               is(trackEvent.type, "addtrack",
                  "Expected addtrack event type");
-              is(test.pcRemote.getWebrtcTrackId(trackEvent.track), newTrack.id, "Expected track in event");
               is(trackEvent.track.readyState, "live",
                  "added track should be live");
             })
             .then(() => haveNoEvent(remoteStream, "addtrack"));
         });
       },
     ],
     [
--- a/dom/media/tests/mochitest/test_peerConnection_constructedStream.html
+++ b/dom/media/tests/mochitest/test_peerConnection_constructedStream.html
@@ -44,19 +44,16 @@ runNetworkTest(() => {
       test.pcRemote._pc.getRemoteStreams().find(s => s.id == sentStreamId);
     ok(receivedStream, "We should receive a stream with with the sent stream's id (" + sentStreamId + ")");
     if (!receivedStream) {
       return;
     }
 
     is(receivedStream.getTracks().length, sentTracks.length,
        "Should receive same number of tracks as were sent");
-    sentTracks.forEach(t =>
-      ok(receivedStream.getTracks().find(t2 => t.id == test.pcRemote.getWebrtcTrackId(t2)),
-         "The sent track (" + t.id + ") should exist on the receive side"));
   };
 
   test.chain.append([
     function PC_REMOTE_CHECK_RECEIVED_CONSTRUCTED_STREAM() {
       checkSentTracksReceived(constructedStream.id, constructedStream.getTracks());
     },
     function PC_REMOTE_CHECK_RECEIVED_DUMMY_STREAM() {
       checkSentTracksReceived(dummyStream.id, dummyStreamTracks);