Bug 1275672 - Remove accidental trailing /D from makecab.exe arguments; r=me
authorGregory Szorc <gps@mozilla.com>
Tue, 31 May 2016 09:09:03 -0700
changeset 299753 d3137e8822b36c71e406224d8140b6608b9dcb34
parent 299752 7dacef36b2dc491e115f1057b20a20829fd36015
child 299754 b7b7ea5b410ea4b02432d26fbd09a7d43bae4f2a
push id30302
push usercbook@mozilla.com
push dateWed, 01 Jun 2016 13:08:19 +0000
treeherdermozilla-central@111970c73823 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1275672
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1275672 - Remove accidental trailing /D from makecab.exe arguments; r=me This was causing the "path" argument to get swallowed because makecab.exe thought it was the argument to /D. Derp. MozReview-Commit-ID: 6Bd3l7ISsPj
toolkit/crashreporter/tools/symbolstore.py
--- a/toolkit/crashreporter/tools/symbolstore.py
+++ b/toolkit/crashreporter/tools/symbolstore.py
@@ -780,17 +780,17 @@ class Dumper_Win32(Dumper):
         self.fixedFilenameCaseCache[file] = result
         return result
 
     def CopyDebug(self, file, debug_file, guid, code_file, code_id):
         def compress(path):
             compressed_file = path[:-1] + '_'
             # ignore makecab's output
             success = subprocess.call(["makecab.exe", "/D",
-                                       "CompressionType=MSZIP", "/D",
+                                       "CompressionType=MSZIP",
                                        path, compressed_file],
                                       stdout=open(os.devnull, 'w'),
                                       stderr=subprocess.STDOUT)
             if success == 0 and os.path.exists(compressed_file):
                 os.unlink(path)
                 return True
             return False