Bug 474369 - get rid of nsVoidArray, uninitialized warning fix; r+sr=sicking
--- a/content/svg/content/src/nsSVGNumberList.cpp
+++ b/content/svg/content/src/nsSVGNumberList.cpp
@@ -368,29 +368,29 @@ nsSVGNumberList::RemoveElementAt(PRInt32
mNumbers.RemoveElementAt(index);
NS_RELEASE(number);
DidModify();
}
nsresult
nsSVGNumberList::InsertElementAt(nsIDOMSVGNumber* aElement, PRInt32 index)
{
- nsresult rv;
- WillModify();
- NS_ADDREF(aElement);
-
// The SVG specs state that 'if newItem is already in a list, it
// is removed from its previous list before it is inserted into this
// list':
// aElement->SetListOwner(this);
- if (mNumbers.InsertElementAt(index, aElement))
- NS_ADD_SVGVALUE_OBSERVER(aElement);
+ if (!mNumbers.InsertElementAt(index, aElement)) {
+ return NS_ERROR_OUT_OF_MEMORY;
+ }
+ WillModify();
+ NS_ADDREF(aElement);
+ NS_ADD_SVGVALUE_OBSERVER(aElement);
DidModify();
- return rv;
+ return NS_OK;
}
////////////////////////////////////////////////////////////////////////
// Exported creation functions:
nsresult
NS_NewSVGNumberList(nsIDOMSVGNumberList** result)