Bug 1534858 - Include crashinject.exe and minidumpwriter.exe in windows artifacts; r=chmanchester
authorGeoff Brown <gbrown@mozilla.com>
Thu, 21 Mar 2019 22:12:52 +0000
changeset 465557 d12b8cd1cee80c0c85d427bb2c507eaf240deabb
parent 465549 a06641525adc519013e0b51ae564cd3b387647b2
child 465558 ac38291d9c56a0aa6d9e3142261f90ac45e82224
push id35744
push userapavel@mozilla.com
push dateFri, 22 Mar 2019 16:44:08 +0000
treeherdermozilla-central@e66a2b59914d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1534858
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534858 - Include crashinject.exe and minidumpwriter.exe in windows artifacts; r=chmanchester Test automation code assumes crashinject.exe is available on Win32: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/build/automation.py.in#356 and minidumpwriter.exe on Windows when there is a 32/64 bit mismatch between python and the application build: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/testing/mozbase/mozcrash/mozcrash/mozcrash.py#428 so I think these should be available for Windows tests, and I suspect they have only been left out accidentally. I will file a new bug to get minidumpwriter working on aarch64. Differential Revision: https://phabricator.services.mozilla.com/D23895
python/mozbuild/mozbuild/artifacts.py
--- a/python/mozbuild/mozbuild/artifacts.py
+++ b/python/mozbuild/mozbuild/artifacts.py
@@ -499,18 +499,21 @@ class WinArtifactJob(ArtifactJob):
 
     # These are a subset of TEST_HARNESS_BINS in testing/mochitest/Makefile.in.
     test_artifact_patterns = {
         ('bin/BadCertServer.exe', ('bin', 'bin')),
         ('bin/GenerateOCSPResponse.exe', ('bin', 'bin')),
         ('bin/OCSPStaplingServer.exe', ('bin', 'bin')),
         ('bin/SymantecSanctionsServer.exe', ('bin', 'bin')),
         ('bin/certutil.exe', ('bin', 'bin')),
+        ('bin/crashinject.exe', ('bin', 'bin')),
+        ('bin/crashinjectdll.dll', ('bin', 'bin')),
         ('bin/fileid.exe', ('bin', 'bin')),
         ('bin/geckodriver.exe', ('bin', 'bin')),
+        ('bin/minidumpwriter.exe', ('bin', 'bin')),
         ('bin/pk12util.exe', ('bin', 'bin')),
         ('bin/screenshot.exe', ('bin', 'bin')),
         ('bin/ssltunnel.exe', ('bin', 'bin')),
         ('bin/xpcshell.exe', ('bin', 'bin')),
         ('bin/plugins/gmp-*/*/*', ('bin/plugins', 'bin')),
         ('bin/plugins/*', ('bin/plugins', 'plugins')),
         ('bin/components/*', ('bin/components', 'bin/components')),
     }