bug 962719 remove notified blocked warning of finished stream r=padenot
authorKarl Tomlinson <karlt+@karlt.net>
Fri, 31 Jul 2015 22:49:55 +1200
changeset 257991 d0b0a8015ca0c5fb5df88c14bcd8101d48b1a080
parent 257990 51ab07894b4937a86e37ac8a8c2a8802b9df48eb
child 257992 c790c2fe70dafd681810f7b592113a029c290220
push id29238
push userryanvm@gmail.com
push dateMon, 17 Aug 2015 13:06:57 +0000
treeherdermozilla-central@a6eeb28458fd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs962719
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 962719 remove notified blocked warning of finished stream r=padenot Finished can be determined immediately after mFinished is set, but blocked is not determined until RecomputeBlocking() has run.
dom/media/MediaStreamGraph.cpp
--- a/dom/media/MediaStreamGraph.cpp
+++ b/dom/media/MediaStreamGraph.cpp
@@ -342,18 +342,16 @@ MediaStreamGraphImpl::StreamReadyToFinis
 {
   MOZ_ASSERT(aStream->mFinished);
   MOZ_ASSERT(!aStream->mNotifiedFinished);
 
   // The stream is fully finished when all of its track data has been played
   // out.
   if (mProcessedTime >=
       aStream->StreamTimeToGraphTime(aStream->GetStreamBuffer().GetAllTracksEnd()))  {
-    NS_WARN_IF_FALSE(aStream->mNotifiedBlocked,
-      "Should've notified blocked=true for a fully finished stream");
     aStream->mNotifiedFinished = true;
     SetStreamOrderDirty();
     for (uint32_t j = 0; j < aStream->mListeners.Length(); ++j) {
       MediaStreamListener* l = aStream->mListeners[j];
       l->NotifyEvent(this, MediaStreamListener::EVENT_FINISHED);
     }
   }
 }