Bug 1549589 - scroll-snap-coordinate shouldn't use NotInitial. r=hiro
authorEmilio Cobos Álvarez <emilio@crisal.io>
Mon, 06 May 2019 21:31:16 +0000
changeset 472786 cf7b6547cfb26608ba79093ed78f85a56dfbfd56
parent 472785 93e59a14b907071d2059c66f8391ed6c0904ca3c
child 472787 f776e9e5e817c9f1acd0451e915042089e80ce14
push id35978
push usershindli@mozilla.com
push dateTue, 07 May 2019 09:44:39 +0000
treeherdermozilla-central@7aee5a30dd15 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1549589
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549589 - scroll-snap-coordinate shouldn't use NotInitial. r=hiro The initial value for this is indeed `none` (and thus empty). The Rust code was confused. This property is disabled by default these days, and I think the get_initial_value() function, which is what could get confused, is not called for this property, so I think this shouldn't be observable. Differential Revision: https://phabricator.services.mozilla.com/D30124
servo/components/style/properties/longhands/box.mako.rs
--- a/servo/components/style/properties/longhands/box.mako.rs
+++ b/servo/components/style/properties/longhands/box.mako.rs
@@ -332,21 +332,21 @@
     animation_value_type="discrete",
 )}
 
 ${helpers.predefined_type(
     "scroll-snap-coordinate",
     "Position",
     "computed::Position::zero()",
     vector=True,
+    allow_empty=True,
     products="gecko",
     gecko_pref="layout.css.scroll-snap.enabled",
     spec="Nonstandard (https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-snap-destination)",
     animation_value_type="discrete",
-    allow_empty="NotInitial",
 )}
 
 <% transform_extra_prefixes = "moz:layout.css.prefixes.transforms webkit" %>
 
 ${helpers.predefined_type(
     "transform",
     "Transform",
     "generics::transform::Transform::none()",