Bug 1525646 - Remove aTkhd arg from MoofParser::ParseMdia as it is unused. r=jya
authorBryce Van Dyk <bvandyk@mozilla.com>
Tue, 12 Feb 2019 19:19:53 +0000
changeset 458808 cf6f7992935c
parent 458807 081476483f25
child 458809 91ac960f7b59
push id35548
push useropoprus@mozilla.com
push dateWed, 13 Feb 2019 09:48:26 +0000
treeherdermozilla-central@93e37c529818 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1525646
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1525646 - Remove aTkhd arg from MoofParser::ParseMdia as it is unused. r=jya Differential Revision: https://phabricator.services.mozilla.com/D19022
dom/media/mp4/MoofParser.cpp
dom/media/mp4/MoofParser.h
--- a/dom/media/mp4/MoofParser.cpp
+++ b/dom/media/mp4/MoofParser.cpp
@@ -268,28 +268,28 @@ void MoofParser::ParseTrak(Box& aBox) {
   LOG_DEBUG(Trak, "Starting.");
   Tkhd tkhd;
   for (Box box = aBox.FirstChild(); box.IsAvailable(); box = box.Next()) {
     if (box.IsType("tkhd")) {
       tkhd = Tkhd(box);
     } else if (box.IsType("mdia")) {
       if (mTrackParseMode.is<ParseAllTracks>() ||
           tkhd.mTrackId == mTrackParseMode.as<uint32_t>()) {
-        ParseMdia(box, tkhd);
+        ParseMdia(box);
       }
     } else if (box.IsType("edts") &&
                (mTrackParseMode.is<ParseAllTracks>() ||
                 tkhd.mTrackId == mTrackParseMode.as<uint32_t>())) {
       mEdts = Edts(box);
     }
   }
   LOG_DEBUG(Trak, "Done.");
 }
 
-void MoofParser::ParseMdia(Box& aBox, Tkhd& aTkhd) {
+void MoofParser::ParseMdia(Box& aBox) {
   LOG_DEBUG(Mdia, "Starting.");
   for (Box box = aBox.FirstChild(); box.IsAvailable(); box = box.Next()) {
     if (box.IsType("mdhd")) {
       mMdhd = Mdhd(box);
     } else if (box.IsType("minf")) {
       ParseMinf(box);
     }
   }
--- a/dom/media/mp4/MoofParser.h
+++ b/dom/media/mp4/MoofParser.h
@@ -297,17 +297,17 @@ class MoofParser : public DecoderDoctorL
   bool RebuildFragmentedIndex(const mozilla::MediaByteRangeSet& aByteRanges,
                               bool* aCanEvict);
   bool RebuildFragmentedIndex(BoxContext& aContext);
   MP4Interval<Microseconds> GetCompositionRange(
       const mozilla::MediaByteRangeSet& aByteRanges);
   bool ReachedEnd();
   void ParseMoov(Box& aBox);
   void ParseTrak(Box& aBox);
-  void ParseMdia(Box& aBox, Tkhd& aTkhd);
+  void ParseMdia(Box& aBox);
   void ParseMvex(Box& aBox);
 
   void ParseMinf(Box& aBox);
   void ParseStbl(Box& aBox);
   void ParseStsd(Box& aBox);
   void ParseEncrypted(Box& aBox);
 
   bool BlockingReadNextMoof();