Bug 1030343 - Fix compile error in UnionTypes.cpp in old gcc (r=bz)
authorBill McCloskey <wmccloskey@mozilla.com>
Mon, 30 Jun 2014 14:36:45 -0700
changeset 191599 cf4395934bcaf153e1776817b962b51106d3f313
parent 191598 b409824b125d62257b116ce1b91a6015b1285316
child 191600 efc431bf9e242d383756261ad1e4a3babea1ad9b
push id27055
push usercbook@mozilla.com
push dateTue, 01 Jul 2014 12:01:46 +0000
treeherdermozilla-central@4a9353b5762d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1030343
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1030343 - Fix compile error in UnionTypes.cpp in old gcc (r=bz)
dom/bindings/Codegen.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -8361,17 +8361,17 @@ class CGUnionStruct(CGThing):
                     "ToJSVal",
                     "bool",
                     [
                         Argument("JSContext*", "cx"),
                         Argument("JS::Handle<JSObject*>", "scopeObj"),
                         Argument("JS::MutableHandle<JS::Value>", "rval")
                     ],
                     body=CGSwitch("mType", toJSValCases,
-                                  default=CGGeneric("return false;\n")).define(),
+                                  default=CGGeneric("return false;\n")).define() + "\nreturn false;\n",
                     const=True))
 
         constructors = [ctor]
         selfName = CGUnionStruct.unionTypeName(self.type, self.ownsMembers)
         if self.ownsMembers:
             if traceCases:
                 traceBody = CGSwitch("mType", traceCases,
                                      default=CGGeneric("")).define()