Bug 1496359 - Don't set _GLIBCXX_DEBUG in webrtc.org build config; r=ng
authorDan Minor <dminor@mozilla.com>
Mon, 15 Apr 2019 17:12:31 +0000
changeset 469868 ceed4e0b33737af65853e8cff1242b8b74060b41
parent 469867 56329e6eb549344038fc9572be9af64a0af4fcbc
child 469869 3f0981f37c1c499ad52016e526239b390703ba2a
push id35883
push userbtara@mozilla.com
push dateWed, 17 Apr 2019 21:47:29 +0000
treeherdermozilla-central@02b89c29412b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersng
bugs1496359
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496359 - Don't set _GLIBCXX_DEBUG in webrtc.org build config; r=ng This define is not set in the current gn generated json and moz.build files. If I rerun gn, this define ends up being set, and the build will fail with a variety of link time errors. My guess is that enable_iterator_debugging was not set when I last ran gn for x64 Linux, and that it was subsequently enabled without regenerating the gn files and noticing that it causes problems. Differential Revision: https://phabricator.services.mozilla.com/D27367
media/webrtc/trunk/webrtc/build/config/BUILD.gn
--- a/media/webrtc/trunk/webrtc/build/config/BUILD.gn
+++ b/media/webrtc/trunk/webrtc/build/config/BUILD.gn
@@ -171,17 +171,17 @@ config("debug") {
       # Iterator debugging is enabled by default by the compiler on debug
       # builds, and we have to tell it to turn it off.
       defines += [ "_HAS_ITERATOR_DEBUGGING=0" ]
     }
   } else if (is_linux && current_cpu == "x64" && enable_iterator_debugging) {
     # Enable libstdc++ debugging facilities to help catch problems early, see
     # http://crbug.com/65151 .
     # TODO(phajdan.jr): Should we enable this for all of POSIX?
-    defines += [ "_GLIBCXX_DEBUG=1" ]
+    #defines += [ "_GLIBCXX_DEBUG=1" ]
   }
 }
 
 config("release") {
   defines = [ "NDEBUG" ]
 
   # Sanitizers.
   if (is_tsan) {