Bug 1384766 - Reduce expected frame count for GeckoProfiler.SuspendAndSample. r=njn.
authorMichael Layzell <michael@thelayzells.com>
Mon, 14 Aug 2017 11:11:57 +1000
changeset 374519 cecc62945523b2ff6df76b8d3a7f8563de30fbcf
parent 374518 fc0632f12445bf09b839b4190412852fee350162
child 374520 f5cd0326e13535a051334c3ef97dd4847f8dc24b
push id32329
push userarchaeopteryx@coole-files.de
push dateMon, 14 Aug 2017 09:57:36 +0000
treeherdermozilla-central@df9beb781895 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1384766
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1384766 - Reduce expected frame count for GeckoProfiler.SuspendAndSample. r=njn.
tools/profiler/tests/gtest/GeckoProfiler.cpp
--- a/tools/profiler/tests/gtest/GeckoProfiler.cpp
+++ b/tools/profiler/tests/gtest/GeckoProfiler.cpp
@@ -765,17 +765,17 @@ void DoSuspendAndSample(int aTid, nsIThr
       "GeckoProfiler_SuspendAndSample_Test::TestBody",
       [&]() {
         uint32_t features = ProfilerFeature::Leaf;
         GTestStackCollector collector;
         profiler_suspend_and_sample_thread(aTid, features, collector,
                                            /* sampleNative = */ true);
 
         ASSERT_TRUE(collector.mSetIsMainThread == 1);
-        ASSERT_TRUE(collector.mFrames > 5); // approximate; must be > 0
+        ASSERT_TRUE(collector.mFrames > 0);
       }),
     NS_DISPATCH_SYNC);
 }
 
 TEST(GeckoProfiler, SuspendAndSample)
 {
   nsCOMPtr<nsIThread> thread;
   nsresult rv = NS_NewNamedThread("GeckoProfGTest", getter_AddRefs(thread));