Backed out changeset fde4dfc0464a (bug 1536043) for failures in browser_aboutdebugging_debug-target-pane_collapsibilities_interaction.js CLOSED TREE
authorNoemi Erli <nerli@mozilla.com>
Wed, 27 Mar 2019 22:07:34 +0200
changeset 466430 ce74ea6aae1dcddfd2dfd2a1e84452456265081c
parent 466429 30d00ba2923587b2b82f7fe05a85d37532168210
child 466431 4d9740676fab3043128e1b04e23b1c784f4e61b3
push id35768
push useropoprus@mozilla.com
push dateThu, 28 Mar 2019 09:55:54 +0000
treeherdermozilla-central@c045dd97faf2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1536043
milestone68.0a1
backs outfde4dfc0464ab070c72ed8bd591aaea7379ca73a
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset fde4dfc0464a (bug 1536043) for failures in browser_aboutdebugging_debug-target-pane_collapsibilities_interaction.js CLOSED TREE
devtools/client/aboutdebugging-new/src/base.css
devtools/client/aboutdebugging-new/src/components/App.css
devtools/client/aboutdebugging-new/src/components/debugtarget/DebugTargetPane.css
--- a/devtools/client/aboutdebugging-new/src/base.css
+++ b/devtools/client/aboutdebugging-new/src/base.css
@@ -73,17 +73,16 @@
   --base-font-weight: var(--body-10-font-weight);
   --base-line-height: 1.8;
   --message-font-size: 13px; /* Body 10 in Photon - https://design.firefox.com/photon/visuals/typography.html */
   --button-font-size: var(--base-font-size);
   --micro-font-size: 11px;
   --monospace-font-family: monospace;
 
   --card-separator-color: var(--grey-20);
-  --card-shadow-blur-radius: var(--base-unit);
 
   /*
    * Variables particular to about:debugging
    */
   --alt-heading-icon-size: calc(var(--base-unit) * 6);
   --alt-heading-icon-gap: var(--base-unit);
   --main-heading-icon-size: calc(var(--base-unit) * 17); /* 4px * 17 = 68px */
   --main-heading-icon-gap: calc(var(--base-unit) * 3);
@@ -392,17 +391,17 @@ Form controls
   background: var(--error-50);
 }
 
 /*
  * Card UI, from Photon
  */
 .card {
   background-color: var(--white-100); /* from common.inc.css */
-  border-radius: var(--card-shadow-blur-radius); /* from common.inc.css */
+  border-radius: var(--base-unit); /* from common.inc.css */
   box-shadow: 0 1px 4px var(--grey-90-a10); /* from common.inc.css */
   padding-block: calc(var(--base-unit) * 3) calc(var(--base-unit) * 2);
 }
 
 .card__heading {
   font-size: var(--title-20-font-size); /* Note: this is from Photon Title 20 */
   font-weight: var(--title-20-font-weight); /* Note: this is from Photon Title 20 */
 }
--- a/devtools/client/aboutdebugging-new/src/components/App.css
+++ b/devtools/client/aboutdebugging-new/src/components/App.css
@@ -43,18 +43,13 @@
 }
 
 .app__content {
   padding-block-start: var(--app-top-padding);
   padding-block-end: var(--app-bottom-padding);
 
   /* we want to scroll only the main content, not the sidebar */
   overflow-y: auto;
-
-  /* padding will give space for card shadow to appear and
-     margin will correct the alignment */
-  margin-inline: calc(var(--card-shadow-blur-radius) * -1);
-  padding-inline: var(--card-shadow-blur-radius);
 }
 
 .page {
   max-width: var(--page-width);
 }
--- a/devtools/client/aboutdebugging-new/src/components/debugtarget/DebugTargetPane.css
+++ b/devtools/client/aboutdebugging-new/src/components/debugtarget/DebugTargetPane.css
@@ -23,17 +23,13 @@
 }
 
 .debug-target-pane__title {
   cursor: pointer;
 }
 
 .debug-target-pane__collapsable {
   overflow: hidden;
-  /* padding will give space for card shadow to appear and
-     margin will correct the alignment */
-  margin: calc(var(--card-shadow-blur-radius) * -1);
-  padding: var(--card-shadow-blur-radius);
 }
 
 .debug-target-pane__collapsable--collapsed {
   max-height: 0;
 }