Bug 590201 - Remove buttons are difficult to discover in list view. r=bmcbride, a=blocking-beta6
authorPaolo Amadini <paolo.02.prg@amadzone.org>
Mon, 06 Sep 2010 19:07:49 +1200
changeset 52071 cda6a4cf9839872f87fbe6b74fcb12267955aff2
parent 52070 1376f2e60e6bd4583c14176cfec60619c5380a54
child 52072 f40c03aed78fa9b9e3977888841cdb80d74db944
push id15524
push userbmcbride@mozilla.com
push dateMon, 06 Sep 2010 07:12:14 +0000
treeherdermozilla-central@cda6a4cf9839 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbmcbride, blocking-beta6
bugs590201
milestone2.0b6pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 590201 - Remove buttons are difficult to discover in list view. r=bmcbride, a=blocking-beta6
toolkit/mozapps/extensions/content/extensions.xml
toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
toolkit/themes/pinstripe/mozapps/extensions/extensions.css
toolkit/themes/winstripe/mozapps/extensions/extensions.css
--- a/toolkit/mozapps/extensions/content/extensions.xml
+++ b/toolkit/mozapps/extensions/content/extensions.xml
@@ -812,22 +812,21 @@
 #endif
                         oncommand="document.getBindingParent(this).showPreferences();"/>
             <xul:button anonid="enable-btn"  class="addon-control enable"
                         label="&cmd.enableAddon.label;"
                         oncommand="document.getBindingParent(this).userDisabled = false;"/>
             <xul:button anonid="disable-btn" class="addon-control disable"
                         label="&cmd.disableAddon.label;"
                         oncommand="document.getBindingParent(this).userDisabled = true;"/>
+            <xul:button anonid="remove-btn" class="addon-control remove"
+                        label="&cmd.uninstallAddon.label;"
+                        oncommand="document.getBindingParent(this).uninstall();"/>
           </xul:hbox>
         </xul:vbox>
-        <xul:vbox pack="start" class="remove-container">
-          <xul:button anonid="remove-btn" class="remove-button"
-                      oncommand="document.getBindingParent(this).uninstall();"/>
-        </xul:vbox>
       </xul:hbox>
     </content>
 
     <implementation>
       <constructor><![CDATA[
         this._installStatus.mControl = this;
         this._installStatus.mAddon = this.mAddon;
 
--- a/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css
@@ -763,36 +763,16 @@
 
 
 /*** buttons ***/
 
 .addon-control[disabled="true"] {
   display: none;
 }
 
-.remove-button {
-  -moz-appearance: toolbarbutton;
-  margin: 0;
-  list-style-image: url("moz-icon://stock/gtk-close?size=menu");
-  min-width: 0;
-  margin: 0;
-}
-
-.remove-button .button-text {
-  display: none;
-}
-
-.remove-button .button-icon {
-  margin: 0;
-}
-
-.remove-button .button-box {
-  padding: 0;
-}
-
 .button-link {
   -moz-appearance: none;
   background: transparent;
   border: none;
   text-decoration: underline;
   color: -moz-nativehyperlinktext;
   cursor: pointer;
   min-width: 0;
--- a/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
@@ -488,20 +488,16 @@
 .addon .relnotes-toggle > .button-box > .button-icon {
   -moz-padding-start: 4px;
 }
 
 .addon[show-relnotes] .relnotes-toggle {
   list-style-image: url("chrome://global/skin/arrow/arrow-up.gif");
 }
 
-.remove-container {
-  width: 16px;
-}
-
 /*** item - uninstalled ***/
 
 .addon[status="uninstalled"] {
   border: none;
 }
 
 .addon[status="uninstalled"] > .container {
   -moz-box-align: center;
@@ -824,38 +820,16 @@
 .addon-control.remove:hover {
   -moz-box-shadow: #FF0000 0px 0px 6px -1px;
 }
 
 .addon-control[disabled="true"] {
   display: none;
 }
 
-.remove-button {
-  -moz-appearance: none;
-  padding: 0;
-  margin: 0;
-  list-style-image: url("chrome://global/skin/icons/closetab.png");
-  border: none;
-  min-width: 0;
-  margin: 0;
-}
-
-.remove-button .button-text {
-  display: none;
-}
-
-.remove-button:hover {
-  list-style-image: url("chrome://global/skin/icons/closetab-hover.png");
-}
-
-.remove-button:hover:active {
-  list-style-image: url("chrome://global/skin/icons/closetab-active.png");
-}
-  
 .button-link {
   -moz-appearance: none;
   background: transparent;
   border: none;
   text-decoration: underline;
   color: -moz-nativehyperlinktext;
   cursor: pointer;
   min-width: 0;
--- a/toolkit/themes/winstripe/mozapps/extensions/extensions.css
+++ b/toolkit/themes/winstripe/mozapps/extensions/extensions.css
@@ -464,20 +464,16 @@
 .addon .relnotes-toggle > .button-box > .button-icon {
   -moz-padding-start: 4px;
 }
 
 .addon[show-relnotes] .relnotes-toggle {
   list-style-image: url("chrome://global/skin/arrow/arrow-up.gif");
 }
 
-.remove-container {
-  width: 16px;
-}
-
 /*** item - uninstalled ***/
 
 .addon[status="uninstalled"] {
   border: none;
 }
 
 .addon[status="uninstalled"] > .container {
   -moz-box-align: center;
@@ -782,48 +778,16 @@
 
 
 /*** buttons ***/
 
 .addon-control[disabled="true"] {
   display: none;
 }
 
-.remove-button {
-  -moz-appearance: none;
-  background: transparent;
-  padding: 0;
-  margin: 0;
-  list-style-image: url("chrome://global/skin/icons/close.png");
-  -moz-image-region: rect(0, 64px, 16px, 48px);
-  border: none;
-  min-width: 0;
-  margin: 0;
-}
-
-.remove-button .button-box {
-  padding: 0;
-}
-
-.addon[selected] .remove-button:not(:hover):not(:active) {
-  -moz-image-region: rect(0, 16px, 16px, 0);
-}
-
-.remove-button:hover {
-  -moz-image-region: rect(0, 32px, 16px, 16px);
-}
-
-.remove-button:active {
-  -moz-image-region: rect(0, 48px, 16px, 32px);
-}
-
-.remove-button .button-text {
-  display: none;
-}
-
 .button-link {
   -moz-appearance: none;
   background: transparent;
   border: none;
   text-decoration: underline;
   color: -moz-nativehyperlinktext;
   cursor: pointer;
   min-width: 0;